[HOLD for payment 2023-12-18] [HOLD for payment 2023-12-15] [$500] Chat - Focus is lost after deleting letter in a word in the emoji search bar

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.9-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

1. Go to staging.new.expensify.com on desktop browser or open Desktop App
2. Login with any account
3. Go to any chat
4. Select Emoji Picker
5. Type any word in Search bar
6. Delete by Backspace last letter in this word

Expected Result:

The letter is removed and focus remains in the search bar

Actual Result:

The letter is removed but the focus is lost in the search bar and moved to the first emoji

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6304117_1701930291733.Desktop-Emoji-Search-focus-lost-after-delete-char.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0168e5e4d901d26abc
• Upwork Job ID: 1732716256100392960
• Last Price Increase: 2023-12-07
• Automatic offers:
• dukenv0307 | Contributor | 27997975

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0168e5e4d901d26abc

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @MariaHCD (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[izarutskaya]

Not reproducible on production

Recording.1984.mp4

[MariaHCD]

I think this is a regression from #31899 (comment)

cc: @TMisiukiewicz @robertKozik

[dukenv0307]

@MariaHCD Please assign me. I can raise the PR to fix it now as the author of the PR which cause the regression.

[dukenv0307]

@rushatgabhane PR to fix regression is here.

[muttmuure]

Ah OK, I can reproduce this if the following steps are taken:

1. Open the emoji selector
2. Add text (I chose "laugh")
3. Press down then up on the keyboard
4. Delete some text
5. Focus is lost

2024-01-08_11-25-48.mp4

[muttmuure]

@dukenv0307 can you reproduce using the steps above?

[muttmuure]

Still reproducible - waiting on proposals

[TMisiukiewicz]

@muttmuure I'm currently working on #30911 where I am refactoring keyboard navigation in the emoji picker. It might solve the existing issue - I'll let you know when I finish

[TMisiukiewicz]

@muttmuure I can confirm my solution in #34581 fixes that issue

[aimane-chnaif]

Nice! Happy to review PR

[muttmuure]

Thanks @TMisiukiewicz!

[muttmuure]

Waiting on fix

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[muttmuure]

Looks like the linked PR caused a regression, but we might be all good now

[melvin-bot]

This issue has not been updated in over 15 days. @MariaHCD, @muttmuure, @dukenv0307 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[melvin-bot]

@MariaHCD, @muttmuure, @dukenv0307, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.