-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix regression of keybord in emoji picker #32654
Conversation
@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: Nativenot affected Android: mWeb Chromemchrome.moviOS: NativeNot affected iOS: mWeb Safarimsafari.movMacOS: Chrome / Safariweb.movMacOS: Desktopdesktop.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed this fixes all these issues:
- [HOLD for payment 2023-12-18] [HOLD for payment 2023-12-15] [$500] Chat - Focus is lost after deleting letter in a word in the emoji search bar #32644
- [$500] Chat - When typing on emoji search the keyboard is dismissed after typing a character #32652
- [HOLD for payment 2023-12-15] [$500] Chat - The Emoji search field is focused when clicking on Modifier keys #30867 (original)
Console error on press Esc key while showing emoji picker but not related to this PR:
Hi, despite this being a regression issue, I worked it to gain some practice and get to know the project before I start contributing properly. I just compared my findings to your solution. I assume you didn't want to change the new implementation of function shouldBlurOnKeyPress(event: KeyboardEvent): boolean {
if(event.key === 'Tab' || event.key === 'Enter') {
return true;
}
return false;
} if (searchInputRef.current && searchInputRef.current.isFocused() && ReportUtils.shouldBlurOnKeyPress(keyBoardEvent)) {
setIsUsingKeyboardMovement(true);
return;
}
if (searchInputRef.current && !searchInputRef.current.isFocused() && ReportUtils.shouldAutoFocusOnKeyPress(keyBoardEvent)) {
searchInputRef.current.focus();
} If i understood it correctly, space also blurred in the old behavior, so we might need to add that to The surrounding comments of this code turned a bit misleading in the previous changes. |
Thanks for the speedy work folks! |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Fix regression of keybord in emoji picker (cherry picked from commit 12b6a77)
🚀 Cherry-picked to staging by https://github.com/yuwenmemon in version: 1.4.9-3 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.4.9-5 🚀
|
Details
Fix regression of keybord in emoji picker
Fixed Issues
$ #32644
#32652
PROPOSAL:
Tests
Offline tests
Same as above
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
Screen.Recording.2023-12-07.at.19.23.24.mov
MacOS: Chrome / Safari
Screen.Recording.2023-12-07.at.19.23.38.mov
MacOS: Desktop