Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-12-20] [HOLD for payment 2023-12-18] Chat - Skeleton has no animation in the LHN and in the report at the time the user logs in #32719

Closed
6 tasks done
lanitochka17 opened this issue Dec 8, 2023 · 9 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering

Comments

@lanitochka17
Copy link

lanitochka17 commented Dec 8, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.10-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #32328

Action Performed:

  1. Open https://staging.new.expensify.com/
  2. Log in under any account

Expected Result:

he skeleton must have animation in the LHN and in the report at the time the user logs in

Actual Result:

Skeleton has no animation in the LHN and in the report at the time the user logs in

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6305661_1702041568236.Recording_PR_32328_Web.1.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Dec 8, 2023
Copy link
Contributor

github-actions bot commented Dec 8, 2023

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Dec 8, 2023

Triggered auto assignment to @pecanoro (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@situchan
Copy link
Contributor

situchan commented Dec 8, 2023

Commented in offending PR with the root cause and solution.

This is the correct fix:

-   skeletonLHNOut: colors.productDark400,
+   skeletonLHNOut: colors.productDark600,

cc: @grgia

@grgia
Copy link
Contributor

grgia commented Dec 8, 2023

I'll add to this PR - #32721

Copy link

melvin-bot bot commented Dec 8, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@yuwenmemon yuwenmemon removed the DeployBlockerCash This issue or pull request should block deployment label Dec 8, 2023
@yuwenmemon
Copy link
Contributor

Cp'ed, removing blocker

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Dec 11, 2023
@melvin-bot melvin-bot bot changed the title Chat - Skeleton has no animation in the LHN and in the report at the time the user logs in [HOLD for payment 2023-12-18] Chat - Skeleton has no animation in the LHN and in the report at the time the user logs in Dec 11, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 11, 2023
Copy link

melvin-bot bot commented Dec 11, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Dec 11, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.10-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-12-18. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Dec 13, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-12-18] Chat - Skeleton has no animation in the LHN and in the report at the time the user logs in [HOLD for payment 2023-12-20] [HOLD for payment 2023-12-18] Chat - Skeleton has no animation in the LHN and in the report at the time the user logs in Dec 13, 2023
Copy link

melvin-bot bot commented Dec 13, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.11-25 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-12-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Dec 18, 2023
@grgia grgia closed this as completed Dec 20, 2023
@melvin-bot melvin-bot bot removed the Overdue label Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

5 participants