[HOLD for payment 2023-12-28] [$500] Login - "Account closed successfully" on login screen not shown for old existing accounts

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.10-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Log in New Expensify with an old existing account
2. Navigate to Settings > Security > Close account
3. Enter default contact method and close account

Expected Result:

User should be redirected to the log in page and an "Account closed successfully" message should be displayed below email field

Actual Result:

User is redirected to the log in page. However, the message indicating account closure is not shown
Notes:
Issue is not reproducible with completely new accounts

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6305807_1702050927436.2023-12-08_16-24-44.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011705658b0d3f1aa4
• Upwork Job ID: 1733186029523935232
• Last Price Increase: 2023-12-08
• Automatic offers:
• bernhardoj | Contributor | 28042756

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~011705658b0d3f1aa4

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 (External)

[shubham1206agra]

@ZhenjaHorbach, Your RCA is wrong. I have tested this. Its closing the account.
@stephanieelliott Can we check the backend for this? It looks like a backend issue as success message comes from backend

[ZhenjaHorbach]

Yeah
Sorry

But what's interesting is that we expect the parameter here
Which should be responsible for the error message

https://github.com/Expensify/App/blob/6e11da581e1322b144abc0a1220bd7acac9f25ea/src/libs/actions/User.js#L72C1-L73

[shubham1206agra]

Ah, maybe I can guess the problem here. And why the problem is with the old account only?

[shubham1206agra]

Yeah Sorry

But what's interesting is that we expect the parameter here Which should be responsible for the error message

The parameter is optional in that

[shubham1206agra]

@ZhenjaHorbach Do you have an old account which can be deleted?

[ZhenjaHorbach]

Unfortunately, no longer)

[shubham1206agra]

Do you have onyx response while closing the account?
And maybe try re-login to the account

[ZhenjaHorbach]

Actually yes
The account remains)
The problem is that we are not successfully deleting our account

So we probably need to fix the unsuccessful deletion
And display a new message
That we cannot delete an account

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Closing an account doesn't show the success message.

What is the root cause of that problem?

We can reproduce this with an account that has a workspace with other members in it. When we close the account, we will get an error, so the close account is actually not successful, but we always redirect the user to sign in no matter the API result.

App/src/libs/actions/User.js

Lines 72 to 73 in 632c5c6

	// Run cleanup actions to prevent reconnection callbacks from blocking logging in again
	redirectToSignIn();

It's to fix this issue #25793 where NetworkConnection listener is never cleared when we sign out. The C+ then suggest to use redirectToSignIn as it also clears other things on sign out.

What changes do you think we should make in order to solve the problem?

We shouldn't call redirectToSignIn immediately every time we press close account. Instead, we can clear the NetworkConnection listener when AuthScreens component unmounts.

App/src/libs/Navigation/AppNavigator/AuthScreens.tsx

Lines 243 to 248 in 632c5c6

	return () => {
	unsubscribeShortcutsOverviewShortcut();
	unsubscribeSearchShortcut();
	unsubscribeChatShortcut();
	Session.cleanupSession();
	};

NetworkConnection.clearReconnectionCallbacks();

or

redirectToSignIn()

[narefyev91]

Proposal from @bernhardoj looks good to me #32733 (comment)
We should correctly clean data and not just swap it in all cases. Also we should check that new logic will also work for #25793 - and we will not get more regressions
🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @Gonals, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[bernhardoj]

@narefyev91 before opening the PR, I'm thinking of a different approach to the solution. The concept is still the same. We still won't call redirectToSignIn immediately after pressing the close account button.

The concern I have is, if we call redirectToSignIn() when AuthScreens is unmounted, redirectToSignIn() will be called twice when we press Sign Out from the settings page (we call redirectToSignIn when pressing sign out). There is no problem so far with it but I'm thinking of a cleaner way to do the sign-out cleanup.

What if we move all cleanup (except clearStorageAndRedirect) from redirectToSignIn to Session.cleanupSession?

App/src/libs/actions/SignInRedirect.ts

Lines 76 to 84 in 2f337d5

	function redirectToSignIn(errorMessage?: string) {
	MainQueue.clear();
	HttpUtils.cancelPendingRequests();
	PersistedRequests.clear();
	NetworkConnection.clearReconnectionCallbacks();
	clearStorageAndRedirect(errorMessage);
	resetHomeRouteParams();
	SessionUtils.resetDidUserLogInDuringSession();
	}

App/src/libs/actions/Session/index.ts

Lines 586 to 594 in 2f337d5

	/**
	* Put any logic that needs to run when we are signed out here. This can be triggered when the current tab or another tab signs out.
	*/
	function cleanupSession() {
	Pusher.disconnect();
	Timers.clearAll();
	Welcome.resetReadyCheck();
	PriorityMode.resetHasReadRequiredDataFromStorage();
	}

App/src/libs/Navigation/AppNavigator/AuthScreens.tsx

Lines 243 to 248 in 632c5c6

	return () => {
	unsubscribeShortcutsOverviewShortcut();
	unsubscribeSearchShortcut();
	unsubscribeChatShortcut();
	Session.cleanupSession();
	};

This way, if the user presses Sign Out, clearStorageAndRedirect will be called to clear the Onyx, and Session.cleanupSession will be called once AuthScreen is unmounted. Session.cleanupSession will always be called when signing out, including when we close the account.

This works fine so far.

What do you think?

[narefyev91]

Yup i think we can try that approach to not having multiple calls for nothing. In any case it's mostly just an order for cleaning data during logout

[bernhardoj]

PR is ready

cc: @narefyev91

[stephanieelliott]

PR is on staging

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.14-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix fail close account log the user out instead of showing the error message #32936

If no regressions arise, payment will be issued on 2023-12-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @narefyev91 does not require payment (Contractor)
• @bernhardoj requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@narefyev91] The PR that introduced the bug has been identified. Link to the PR:
• [@narefyev91] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@narefyev91] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@narefyev91] Determine if we should create a regression test for this bug.
• [@narefyev91] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

@Gonals, @narefyev91, @stephanieelliott, @bernhardoj Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@Gonals, @narefyev91, @stephanieelliott, @bernhardoj Huh... This is 4 days overdue. Who can take care of this?

[bernhardoj]

I think we are waiting for the checklist

[narefyev91]

• The PR that introduced the bug has been identified. Link to the PR - it was a new functionality - no regressions
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment - N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion - N/A
• Determine if we should create a regression test for this bug - N/A

[stephanieelliott]

Summarizing payment on this issue:

• Contributor: @bernhardoj $500, paid via Upwork
• Contributor+: @narefyev91, no payment due

Upwork job is here:https://www.upwork.com/jobs/~011705658b0d3f1aa4

[stephanieelliott]

All paid, thanks!