[HOLD for payment 2023-12-20] [$500] Split - Participants under “Split with” list disappear after unselecting them

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.11-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com.
2. Go to group chat > + > Split bill.
3. Enter amount > Next.
4. Unselect the participants.

Expected Result:

Group participants will not disappear from the “Split with” list after unselecting them.

Actual Result:

Group participants disappear from the “Split with” list after unselecting them.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6308971_1702302486695.bandicam_2023-12-11_19-56-33-445__1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01103b76f36fd3edb8
• Upwork Job ID: 1734224694853259264
• Last Price Increase: 2023-12-11
• Automatic offers:
• s-alves10 | Contributor | 28035106

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @nkuoch (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[tgolen]

I'll look into it this morning.

[dummy-1111]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Participants under "Split with" list disappear when unselecting them

What is the root cause of that problem?

This is a regression of the PR #28618

The root cause is in the following code segment

App/src/components/MoneyTemporaryForRefactorRequestConfirmationList.js

Line 371 in a16df0d

const unselectedParticipants = _.filter(selectedParticipantsFiltered, (participant) => !participant.selected);

In the above code, selectedParticipantsFiltered is a filtered participants list(selected = true) as you can see here

App/src/components/MoneyTemporaryForRefactorRequestConfirmationList.js

Line 361 in a16df0d

const selectedParticipantsFiltered = useMemo(() => _.filter(selectedParticipants, (participant) => participant.selected), [selectedParticipants]);

What changes do you think we should make in order to solve the problem?

Update the above line to

        const unselectedParticipants = _.filter(selectedParticipants, (participant) => !participant.selected);

This works as expected

What alternative solutions did you explore? (Optional)

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01103b76f36fd3edb8

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[melvin-bot]

📣 @s-alves10 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[tgolen]

The above proposal from @s-alves10 is correct. It was a fix that I missed adding to the refactored component.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.11-25 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: getting unselected participants #32823

If no regressions arise, payment will be issued on 2023-12-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @s-alves10 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@tgolen] The PR that introduced the bug has been identified. Link to the PR: Refactor the money request creation flow #28618
• [@tgolen] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/28618/files#r1425588580
• [@tgolen] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: https://expensify.slack.com/archives/C07J32337/p1702402026394659
• [@s-alves10] Determine if we should create a regression test for this bug.
• [@s-alves10] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[tgolen]

I don't think we need a regression test. This was caught during regression testing.

[dummy-1111]

• [@s-alves10] Determine if we should create a regression test for this bug.
• [@s-alves10] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

This is a regression of refactoring PR #28618. I don't think we need regression test here

Do we agree 👍 or 👎

[melvin-bot]

@tgolen, @s-alves10 Eep! 4 days overdue now. Issues have feelings too...

[tgolen]

It looks like this can be closed out and we agree that we don't need a regression test.

[tgolen]

Oops, it looks like this hasn't been paid out. Reopening and assigning someone to help with the payout.

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[tgolen]

@bfitzexpensify Could you please help pay this issue according to #32808 (comment)?

[bfitzexpensify]

Payment complete, closing this out.