[$500] Android - Split scan - Unable to select workspace as recipient when creating split scan in WS chat

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.11-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Launch New Expensify app.
2. Go to workspace chat > + > Request money.
3. Tap Split bill > Scan.
4. Upload a photo.
   Note that we cannot select a workspace in participant page although we are now in the workspace chat.

Expected Result:

User will be redirected to the confirmation page without the need to select a workspace since user is already in the workspace chat.

Actual Result:

User is redirected to participant selection page and there is no way to select a workspace since workspace is not in the list.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6308990_1702303061277.Screen_Recording_20231211_200248_New_Expensify.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0135d3b2a39137f316
• Upwork Job ID: 1734225777714790400
• Last Price Increase: 2023-12-11
• Automatic offers:
• 0xmiroslav | Reviewer | 28035664
• mkhutornyi | Contributor | 28035665

Issue Owner

Current Issue Owner: @anmurali

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @rlinoz (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[tgolen]

I'll take this and look into it.

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0135d3b2a39137f316

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

[tgolen]

I'd love to get any proposals for fixing this. If not, I'll be looking into it in 30 minutes or so.

[melvin-bot]

📣 @VenusWhisperer! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[mkhutornyi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Participants are selectable even though money request created from composer + in selected report

What is the root cause of that problem?

App/src/pages/iou/request/step/IOURequestStepScan/index.native.js

Line 293 in a16df0d

export default IOURequestStepScan;

withWritableReportOrNotFound HOC is missing here unlike web:

App/src/pages/iou/request/step/IOURequestStepScan/index.js

Line 344 in a16df0d

export default withWritableReportOrNotFound(IOURequestStepScan);

So this caused report empty json {} and report.reportID = undefined

App/src/pages/iou/request/step/IOURequestStepScan/index.native.js

Lines 151 to 158 in a16df0d

	// If a reportID exists in the report object, it's because the user started this flow from using the + button in the composer
	// inside a report. In this case, the participants can be automatically assigned from the report and the user can skip the participants step and go straight
	// to the confirm step.
	if (report.reportID) {
	IOU.setMoneyRequestParticipantsFromReport(transactionID, report);
	Navigation.navigate(ROUTES.MONEY_REQUEST_STEP_CONFIRMATION.getRoute(iouType, transactionID, reportID));
	return;
	}

And in scan tab, withFullTransactionOrNotFound was missing unlike other 2 tabs (manual, distance)

App/src/pages/iou/request/step/IOURequestStepDistance.js

Line 234 in a16df0d

export default compose(withWritableReportOrNotFound, withFullTransactionOrNotFound)(IOURequestStepDistance);

What changes do you think we should make in order to solve the problem?

wrap with withWritableReportOrNotFound and withFullTransactionOrNotFound HOC in both web and native files

[tgolen]

@mkhutornyi thanks. I think your proposal is close, but I think what I actually missed was using both withWritableReportOrNotFound and withFullTransactionOrNotFound for IOURequestStartPage. Could you look at updating your proposal to update IOURequestStartPage with those two HOCs instead?

[mkhutornyi]

@tgolen I think you meant to update IOURequestStepScan, not IOURequestStartPage right?
IOURequestStartPage has 3 tabs. And 2 tabs are already wrapped with withWritableReportOrNotFound and withFullTransactionOrNotFound.
The only bug to fix here is scan tab to wrap with both withWritableReportOrNotFound and withFullTransactionOrNotFound in both web and native

[mkhutornyi]

Proposal

Updated

[tgolen]

Ah, you're right... because those tabs can be opened directly sometimes, so they each need to be wrapped in those HOCs. I just noticed that IOURequestStartPage is also connecting to the same report and transaction in withOnyx, but it's probably overkill to wrap IOURequestStartPage as well as all the tabs.

[melvin-bot]

📣 @0xmiroslav 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @mkhutornyi 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

This issue has not been updated in over 15 days. @tgolen, @anmurali, @0xmiroslav, @mkhutornyi eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[0xmiros]

Automation didn't work. This is awaiting payment

[mallenexpensify]

Contributor: @mkhutornyi paid $500 via Upwork
Contributor+: @0xmiroslav owed $500 via Upwork

I saw another contributor was hired, Volodymry L, but I don't see a reference here for work they've completed so I didn't pay.

• fix "Split scan - Unable to select workspace as recipient when creating split scan in WS chat" #32830 (comment)

PR hit production over a month ago, automation wasn't working so the Reviewing label wasn't removed and this hasn't gone overdue.

Think we're good to close this