[$500] Wallet-Tapping "Enable wallet",add bank account page with select Chase is displayed.

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.11
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

1. Launch app
2. Tap profile icon
3. Tap Workspaces ---- Workspace
4. Tap bank account
5. Tap Connect online with plaid
6. Select Chase
7. Select Plaid saving 1111 and complete the flow
8. Note the Bank account is added
9. Navigate back to Wallet
10. Tap Enable Wallet

Expected Result:

After adding BA using chase, if user taps enable wallet, add bank account page with select Chase must not be displayed.

Actual Result:

After adding BA using chase, if user taps "Enable wallet", add bank account page with select Chase is displayed.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6310026_1702361134771.chase.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d4b60b3ea27982ee
• Upwork Job ID: 1734518482870845440
• Last Price Increase: 2024-01-02

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d4b60b3ea27982ee

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @cristipaval (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[cristipaval]

Hmm.. I could reproduce it, and it seems this happens only once after the setup. There must be something remaining in the cache. I'll continue looking.

[cristipaval]

I think this is reproducible in production as well. I couldn't find a PR that could have introduced this regression. But I found the reason why this happens. It's because the plaidLinkToken Onyx key is not cleared when the user goes to WalletPage and this code flow opens the PlaidBankAccountSelector

[luacmartins]

Nice! @cristipaval can you work on a PR to fix this?

[nkuoch]

What is called when clicking on enabled wallet?
I thought it would call this:

but maybe not as Plaid is not cleared.
So just follow what is called in this flow and make sure clearPlaid() is called before Plaid view gets rendered

[luacmartins]

We navigate straight to the add bank account page: BaseKYCWall > continueAction > selectPaymentMethod

[luacmartins]

Put up fix PR

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.11-25 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Clear plaid data when trying to enable wallet #32949

If no regressions arise, payment will be issued on 2023-12-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @fedirjh requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
• [@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@fedirjh] Determine if we should create a regression test for this bug.
• [@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

@JmillsExpensify, @cristipaval, @luacmartins, @fedirjh Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@JmillsExpensify, @cristipaval, @luacmartins, @fedirjh 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[JmillsExpensify]

@fedirjh Mind kicking off the BZ checklist above?

[JmillsExpensify]

Payment summary:

• Contributor+: $500 for PR review

[fedirjh]

BugZero Checklist:

• Link to the PR:
  • Fix and refactor VBBA setup flow #13236
  • feat: add enable wallet button #29573
• Link to comment:
  • Fix and refactor VBBA setup flow #13236 (comment)
  • feat: add enable wallet button #29573 (comment)
• Link to discussion: N/A Nothing to add to the checklist.
• Determine if we should create a regression test for this bug: yes.

---

Regression Test Proposal

1. Launch app
2. Tap profile icon
3. Tap Workspaces -> select Workspace
4. Tap bank account
5. Tap Connect online with plaid
6. Select Chase
7. Select Plaid saving 1111 and complete the flow
8. Note the Bank account is added
9. Navigate back to Wallet
10. Tap Enable Wallet
11. Verify that the Plaid flow starts

• Do we agree 👍 or 👎

[cristipaval]

Thank you @fedirjh!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@JmillsExpensify @cristipaval @luacmartins @fedirjh this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[JmillsExpensify]

Thanks @fedirjh! Sent you an offer via Upwork just now.

[fedirjh]

@JmillsExpensify Thank you. Accepted.

[JmillsExpensify]

All paid out and regression test created. Thank you!