Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Deploy Checklist: New Expensify 2023-12-13 #32963

Closed
64 tasks done
github-actions bot opened this issue Dec 13, 2023 · 14 comments
Closed
64 tasks done

[$500] Deploy Checklist: New Expensify 2023-12-13 #32963

github-actions bot opened this issue Dec 13, 2023 · 14 comments
Assignees
Labels
Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Dec 13, 2023

Release Version: 1.4.12-2
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01ad8b114ce89fa5e6
  • Upwork Job ID: 1735306198742843392
  • Last Price Increase: 2023-12-14
@kavimuru kavimuru added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Dec 13, 2023
@OSBotify
Copy link
Contributor

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.12-0 🚀

@luacmartins
Copy link
Contributor

Checking off #32803. Will be tested with https://github.com/Expensify/Web-Expensify/pull/39897

@luacmartins
Copy link
Contributor

Checking off #32795, #32906, #32912. They were in the previous checklist and got fixed, we just never removed the label.

@kavimuru
Copy link

Regression is 72% progress.
#32394 failing with existing issue #30683 (checking it off)
#32362 failing with existing issue #32874 (checking it off)

@Julesssss Julesssss self-assigned this Dec 14, 2023
@Julesssss
Copy link
Contributor

Checking off #32106 as this is internal testing only

@Julesssss
Copy link
Contributor

#32592 is testing well for me on 1.4.12-0, checking off. Fixed by #32408

@Julesssss
Copy link
Contributor

Checked off #32857

@kavimuru
Copy link

Regression is completed.

Waiting for the build release to validate the cp #33053

@Julesssss
Copy link
Contributor

#33005 was cherry-picked to resolve #32984
#33053 was cherry-picked to resolve #33009 & #33010

@Julesssss Julesssss added the External Added to denote the issue can be worked on by a contributor label Dec 14, 2023
@melvin-bot melvin-bot bot changed the title Deploy Checklist: New Expensify 2023-12-13 [$500] Deploy Checklist: New Expensify 2023-12-13 Dec 14, 2023
Copy link

melvin-bot bot commented Dec 14, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01ad8b114ce89fa5e6

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 14, 2023
@melvin-bot melvin-bot bot added the Daily KSv2 label Dec 14, 2023
@Expensify Expensify deleted a comment from melvin-bot bot Dec 14, 2023
@Julesssss
Copy link
Contributor

QA is complete

@Julesssss
Copy link
Contributor

Checking off #33009 & #33010

@Julesssss
Copy link
Contributor

  • App Timing nominal
  • Firebase:
    • Android: Single instance of an exception that also occurs in previous version
    • iOS: Single instance of a RangeError: Invalid time value exception that occurs in prev versions
  • Github status nominal

🚀

@Julesssss
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

6 participants