[Wave 6: Referral Program] Promote referral program messaging in NewDot Redesign the Referral page #32362

rezkiy37 · 2023-12-01T16:07:03Z

Details

The PR redesigns a page for Referral Program. Currently, it has 5 variants. For 2 (refer a friend, share code) of them, we changed content.

Fixed Issues

$ #32187
PROPOSAL: N/A

Tests

Money request

Click on the FAB.
Click on "Request money"
Enter any amount.
Click on "Next".
Click on "Request money, get $250.".
Verify that the page looks correctly.

Start chat

Click on the FAB.
Click on "Start a chat"
Click on "Start a chat, get $250..
Verify that the page looks correctly.

Send money

Click on the FAB.
Click on "Send money"
Enter any amount.
Click on "Next".
Click on "Send money, get $250.".
Verify that the page looks correctly.

Refer a friend

Click on the Search.
Click on "Refer a friend, get $250.".
Verify that the page looks correctly.
Click on "Copy referral link".
Verify that the button label has been changed to "Copied!" ("¡Copiado!") for a moment.
Verify that you actually copied a link - https://join.my.expensify.com/?thanks=<YOUR_LOGIN>.

Share code

Go to Settings.
Click on "Share code"
Click on "Get $250".
Verify that the page looks correctly.
Click on "Copy referral link".
Verify that the button label has been changed to "Copied!" ("¡Copiado!") for a moment.
Verify that you actually copied a link - https://join.my.expensify.com/?thanks=<YOUR_LOGIN>.

Same for all cases:

"Learn more" click

Click on "Learn more" button on a page.
Verify that it redirects you to https://help.expensify.com/articles/new-expensify/billing-and-plan-types/Referral-Program.

"Learn more" long press/right-click with mouse

Long press (on mobile devices) / right-click with mouse (on PC) on "Learn more" button on a page.
Verify that a context menu with the link appears.

Verify that no errors appear in the JS console

Offline tests

Same as "Tests".

QA Steps

Same as "Tests".

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

rezkiy37 · 2023-12-02T14:47:32Z

@jamesdeanexpensify, please verify that everything looks good and content is correct.

Share code

Refer a friend

Request money

Start a chat

Send money

jamesdeanexpensify · 2023-12-04T17:47:51Z

I'm going to share these internally today for any final feedback in case we're missing anything. Will be back soon, thanks!

jamesdeanexpensify · 2023-12-04T18:51:12Z

Left comments here.

melvin-bot · 2023-12-06T10:16:57Z

@robertKozik Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

parasharrajat · 2023-12-07T13:50:46Z

BUG: There should not be any gap between the SVG and section.

parasharrajat · 2023-12-07T13:51:24Z

BUG: The description is not left aligned.

parasharrajat · 2023-12-07T14:27:19Z

src/pages/ReferralDetailsPage.js

-                    enterKeyEventListenerPriority={1}
+            }
+            headerContainerStyles={[styles.staticHeaderImage, styles.justifyContentCenter]}
+            backgroundColor={theme.PAGE_THEMES[SCREENS.SETTINGS.WORKSPACES].backgroundColor}


Let's create a new page theme for this page.

Done - 0d31230.

src/pages/ReferralDetailsPage.js

parasharrajat · 2023-12-07T14:38:01Z

src/pages/ReferralDetailsPage.js

+            headerContainerStyles={[styles.staticHeaderImage, styles.justifyContentCenter]}
+            backgroundColor={theme.PAGE_THEMES[SCREENS.SETTINGS.WORKSPACES].backgroundColor}
+        >
+            <Text style={[styles.textHeadline, styles.textAlignCenter, styles.mb3, styles.mt8, styles.ph4]}>{contentHeader}</Text>


All this content should have bottom padding to add gaps under the menu items.

So, it is already has bottom margins. Why do we need paddings?

I mean the whole section. In other words, we can add bottom margin to the last element on this page so that that does not touch bottom edge of the screen on smaller devices.

Agree, makes sense.

Done - 3870b4d.

…ture/32187-referral-page-redesign

rezkiy37 · 2023-12-07T18:22:19Z

Fixed UI bugs.

parasharrajat · 2023-12-07T20:40:51Z

Screenshots

🔲 iOS / native

Screen.Recording.2023-12-08.at.2.18.05.AM.mov

🔲 iOS / Safari

Screen.Recording.2023-12-08.at.2.19.30.AM.mov

🔲 MacOS / Desktop

Screen.Recording.2023-12-08.at.2.20.40.AM.mov

🔲 MacOS / Chrome

Screen.Recording.2023-12-08.at.2.15.38.AM.mov

🔲 Android / Chrome

Screen.Recording.2023-12-08.at.3.04.13.AM.mov

🔲 Android / native

Screen.Recording.2023-12-08.at.2.32.53.AM.mov

jamesdeanexpensify · 2023-12-07T20:55:54Z

We're still making the button "Copy invite link" right? Thanks!

parasharrajat · 2023-12-07T20:57:12Z

Doesn't seem from the code. It says Copy Referral link for now.

jamesdeanexpensify · 2023-12-07T20:58:32Z

OK, let me see if we're handling that in another issue.

parasharrajat · 2023-12-07T21:01:23Z

@grgia Can you please confirm? Section content seems to have more margin-top. Current gap from the illustration background is 20 + 32 = 52px.

grgia · 2023-12-07T21:29:12Z

@parasharrajat it should be 32px

parasharrajat · 2023-12-07T21:30:27Z

Great, thanks. That's what I thought.

parasharrajat · 2023-12-07T21:33:00Z

src/pages/ReferralDetailsPage.js

+            headerContainerStyles={[styles.staticHeaderImage, styles.justifyContentEnd]}
+            backgroundColor={theme.PAGE_THEMES[SCREENS.RIGHT_MODAL.REFERRAL].backgroundColor}
+        >
+            <Text style={[styles.textHeadline, styles.mb3, styles.mt8, styles.ph4]}>{contentHeader}</Text>


Suggested change

<Text style={[styles.textHeadline, styles.mb3, styles.mt8, styles.ph4]}>{contentHeader}</Text>

<Text style={[styles.textHeadline, styles.mb3, styles.mt3, styles.ph4]}>{contentHeader}</Text>

We already have padding top of 20 from the HeaderPagelayout

Done - 6110585.

parasharrajat · 2023-12-08T11:15:04Z

src/languages/es.ts

-            body1: 'Si conoces a alguien que dedique demasiado tiempo a los gastos (literalmente cualquiera: tu vecino, tu jefe, tu amigo de contabilidad), envíale tu enlace de invitación de Expensify:',
-            body2: `Cuando comiencen una suscripción anual, obtendrás $${CONST.REFERRAL_PROGRAM.REVENUE}. Así de fácil.`,
+            header: `Invita a un amigo y obtiene $${CONST.REFERRAL_PROGRAM.REVENUE}`,
+            body: `Sé el primero en invitar a un amigo (o a cualquier otra persona) a Expensify y obtiene $${CONST.REFERRAL_PROGRAM.REVENUE} si se convierte en cliente de Expensify. Comparte tu enlace de invitación por SMS, email o publícalo en las redes sociales.`,
        },
        copyReferralLink: 'Copiar enlace de invitación',


Is this correct?

Bump @rezkiy37

@parasharrajat if it helps, I handled the translation piece and confirming it's:

Invita a un amigo y obtiene $250
Sé el primero en invitar a un amigo (o a cualquier otra persona) a Expensify y obtiene $250 si se convierte en cliente de Expensify. Comparte tu enlace de invitación por SMS, email o publícalo en las redes sociales.

@parasharrajat, yes, it is.

Thanks. PR approved.

parasharrajat

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

melvin-bot · 2023-12-08T14:54:51Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #32187 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

parasharrajat · 2023-12-08T14:55:30Z

@hayata-suenaga There is a translation confirmation request above #32362 (comment).

…ture/32187-referral-page-redesign

hayata-suenaga

LGTM

hayata-suenaga · 2023-12-08T19:33:36Z

conflicts 😢

…ture/32187-referral-page-redesign

rezkiy37 · 2023-12-11T09:54:33Z

The conflicts were resolved.

hayata-suenaga

good work! LGTM!

hayata-suenaga · 2023-12-11T19:36:59Z

there are conflicts 😢

…ture/32187-referral-page-redesign

rezkiy37 · 2023-12-12T09:33:26Z

@hayata-suenaga, resolved.

rezkiy37 · 2023-12-12T09:37:13Z

A bug was found. Investigating...

rezkiy37 · 2023-12-12T09:40:47Z

Fixed.

parasharrajat · 2023-12-12T17:14:23Z

@hayata-suenaga let's merge this before more conflicts popup.

hayata-suenaga

thanks for fixing the merge conflicts 👍

OSBotify · 2023-12-12T18:57:47Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-12-13T11:29:31Z

🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.4.12-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

OSBotify · 2023-12-13T11:50:14Z

🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.4.12-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

OSBotify · 2023-12-13T12:17:48Z

🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.4.12-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-12-14T15:24:31Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.12-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

jamesdeanexpensify · 2023-12-14T16:39:17Z

Shoot - the "Learn more" doesn't work anymore because we recently changed the URL. This shouldn't happen again moving forward, but we need to update it now to: https://help.expensify.com/articles/new-expensify/get-paid-back/Referral-Program

jamesdeanexpensify · 2023-12-14T16:41:02Z

Actually, just kidding. It works! Sorry bout that.

rezkiy37 mentioned this pull request Dec 4, 2023

[Wave 6: Referral Program] Promote referral program messaging in NewDot Redesign the Referral page #32187

Closed

rezkiy37 marked this pull request as ready for review December 6, 2023 10:16

rezkiy37 requested a review from a team as a code owner December 6, 2023 10:16

melvin-bot bot requested review from robertKozik and removed request for a team December 6, 2023 10:16

mountiny removed the request for review from robertKozik December 7, 2023 13:39

parasharrajat suggested changes Dec 7, 2023

View reviewed changes

rezkiy37 added 4 commits December 7, 2023 19:07

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…

6739105

…ture/32187-referral-page-redesign

use a proper const

0d31230

align text left

1a6fc0d

align icon

562937f

rezkiy37 requested a review from parasharrajat December 7, 2023 18:22

add bottom margin for last element

3870b4d

parasharrajat reviewed Dec 7, 2023

View reviewed changes

rezkiy37 added 2 commits December 8, 2023 10:47

translate referral link button

cbd9fec

decrease spacing

6110585

parasharrajat reviewed Dec 8, 2023

View reviewed changes

parasharrajat approved these changes Dec 8, 2023

View reviewed changes

melvin-bot bot requested a review from hayata-suenaga December 8, 2023 14:54

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…

e035dbd

…ture/32187-referral-page-redesign

hayata-suenaga previously approved these changes Dec 8, 2023

View reviewed changes

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…

f5b7305

…ture/32187-referral-page-redesign

rezkiy37 dismissed hayata-suenaga’s stale review via f5b7305 December 11, 2023 09:53

hayata-suenaga previously approved these changes Dec 11, 2023

View reviewed changes

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…

3ae6892

…ture/32187-referral-page-redesign

rezkiy37 dismissed hayata-suenaga’s stale review via 3ae6892 December 12, 2023 09:31

fix merge changes

3d4b568

hayata-suenaga approved these changes Dec 12, 2023

View reviewed changes

hayata-suenaga merged commit d9ea439 into Expensify:main Dec 12, 2023
15 checks passed

github-actions bot mentioned this pull request Dec 13, 2023

[$500] Deploy Checklist: New Expensify 2023-12-13 #32963

Closed

64 tasks

	<Text style={[styles.textHeadline, styles.mb3, styles.mt8, styles.ph4]}>{contentHeader}</Text>
	<Text style={[styles.textHeadline, styles.mb3, styles.mt3, styles.ph4]}>{contentHeader}</Text>

[Wave 6: Referral Program] Promote referral program messaging in NewDot Redesign the Referral page #32362

[Wave 6: Referral Program] Promote referral program messaging in NewDot Redesign the Referral page #32362

Conversation

rezkiy37 commented Dec 1, 2023 • edited Loading

Details

Fixed Issues

Tests

Money request

Start chat

Send money

Refer a friend

Share code

Same for all cases:

"Learn more" click

"Learn more" long press/right-click with mouse

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

rezkiy37 commented Dec 2, 2023

jamesdeanexpensify commented Dec 4, 2023

jamesdeanexpensify commented Dec 4, 2023

melvin-bot bot commented Dec 6, 2023

parasharrajat commented Dec 7, 2023

parasharrajat commented Dec 7, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rezkiy37 commented Dec 7, 2023

parasharrajat commented Dec 7, 2023 • edited Loading

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Desktop

🔲 MacOS / Chrome

🔲 Android / Chrome

🔲 Android / native

jamesdeanexpensify commented Dec 7, 2023

parasharrajat commented Dec 7, 2023

jamesdeanexpensify commented Dec 7, 2023

parasharrajat commented Dec 7, 2023

grgia commented Dec 7, 2023

parasharrajat commented Dec 7, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

parasharrajat Dec 8, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

parasharrajat left a comment

Choose a reason for hiding this comment

Reviewer Checklist

melvin-bot bot commented Dec 8, 2023

parasharrajat commented Dec 8, 2023

hayata-suenaga left a comment

Choose a reason for hiding this comment

hayata-suenaga commented Dec 8, 2023

rezkiy37 commented Dec 11, 2023

hayata-suenaga left a comment

Choose a reason for hiding this comment

hayata-suenaga commented Dec 11, 2023

rezkiy37 commented Dec 12, 2023

rezkiy37 commented Dec 12, 2023

rezkiy37 commented Dec 12, 2023

parasharrajat commented Dec 12, 2023

hayata-suenaga left a comment

Choose a reason for hiding this comment

OSBotify commented Dec 12, 2023

OSBotify commented Dec 13, 2023

OSBotify commented Dec 13, 2023

OSBotify commented Dec 13, 2023

OSBotify commented Dec 14, 2023

jamesdeanexpensify commented Dec 14, 2023

jamesdeanexpensify commented Dec 14, 2023

rezkiy37 commented Dec 1, 2023 •

edited

Loading

parasharrajat commented Dec 7, 2023 •

edited

Loading

parasharrajat Dec 8, 2023 •

edited

Loading