-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Referral article to get paid back #32787
Conversation
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
helpdot is expected to fail because cloudflare doesn't have access to forks |
@parasharrajat it'd be great if you can (blindly) approve the PR to assign someone for merging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forwarding...without testing...
We did not find an internal engineer to review this PR, trying to assign a random engineer to #32523 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
Reviewer Checklist
Screenshots/VideosAndroid: NativeN/A - HelpDot Android: mWeb ChromeN/A - HelpDot iOS: NativeN/A - HelpDot iOS: mWeb SafariN/A - HelpDot MacOS: Chrome / SafariN/A - HelpDot MacOS: DesktopN/A - HelpDot |
@AndrewGable looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
Tests fail on forked PRs for HelpDot deploy. Ignoring. |
🚀 Deployed to staging by https://github.com/AndrewGable in version: 1.4.12-0 🚀
|
🚀 Deployed to staging by https://github.com/AndrewGable in version: 1.4.12-0 🚀
|
🚀 Deployed to staging by https://github.com/AndrewGable in version: 1.4.12-0 🚀
|
🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.12-2 🚀
|
Details
Fixed Issues
$ #32523
PROPOSAL: N.A.
Tests
verify that referral article is in get paid back hub
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.