-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update inline code replace regex to not include code block #32639
Update inline code replace regex to not include code block #32639
Conversation
Reviewer Checklist
Screenshots/VideosAndroid: Nativeandroid.movAndroid: mWeb Chromeandroid.chrome.moviOS: Nativeios.moviOS: mWeb Safariios.safari.movMacOS: Chrome / Safariweb.movMacOS: Desktopdesktop.mov |
Security checks are failing with Out of Sync Error https://docs.snyk.io/more-info/error-catalog?_gl=1*128fjw2*_ga*MTc2Mjg3MzQ0Ni4xNzAyMDMxMzAx*_ga_X9SH3KP7B4*MTcwMjAzMTMwMC4xLjEuMTcwMjAzMTM1OC4wLjAuMA..#snyk-pr-check-0004 @akamefi202 |
@MonilBhavsar Could you please tell me what I should do to fix this error? |
Merging main and |
Signed-off-by: akamefi202 <akamefi202@gmail.com>
0fd00da
to
8df9312
Compare
@MonilBhavsar Could you please tell me more details? I ran "npm install" and pushed again, but the issue still exists. |
e45d35d
to
fb70cb2
Compare
…amefi202/expensify-app into code-block-within-inline-code
@akamefi202 Try removing |
@ArekChr I tried it, but the issue still exists. |
Merging with Snyk tests failing as it is known and we're working on it https://expensify.slack.com/archives/C03TQ48KC/p1700237359186829 |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 1.4.12-0 🚀
|
🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 1.4.12-0 🚀
|
🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 1.4.12-0 🚀
|
🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.12-2 🚀
|
Details
Update inline code replace regex to not include code block
Fixed Issues
$ #26966
PROPOSAL: #26966 (comment)
Tests
(```Test```)
(```Test```)
Offline tests
Same as above
QA Steps
Same as above
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop