[HOLD for payment 2023-12-26] [$500] Web - Chat - Workspace avatar is greyed out in the conversation report preview

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.12.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Create a NewDot workspace if you don't already have one.
2. Open the workspace chat for your workspace.
3. Press the +, Request Money, then Distance and complete a distance request.

Expected Result:

Workspace avatar is visible in the conversation report preview

Actual Result:

Workspace avatar is greyed out in the conversation report preview

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6311868_1702483241237.workspace_avatar_is_greyed_out.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014d0b71872c14469e
• Upwork Job ID: 1735260103087415296
• Last Price Increase: 2023-12-14

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @NikkiWines (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[shubham1206agra]

@kbecciv Can you confirm this problem with new workspace?

[ishpaul777]

Proposal

Problem

Chat - Workspace avatar is greyed out in the conversation report preview

Root Cause

In src/libs/ReportUtils.ts getWorkspaceAvatar returns a empty string incase the workspace has no custom image set while it should fallback to default workspace avatar

Changes

we should check if avatar is not empty and if it is we should fallback to default workspace avatar.

    const avatar = allPolicies?.[`policy_${report?.policyID}`]?.avatar
    return avatar ? avatar : getDefaultWorkspaceAvatar(workspaceName);

[NikkiWines]

Confirmed this isn't happening on prod, and is happening on staging and dev. It's occurring even if the backend is pointed to the commit before the merge commit for https://github.com/Expensify/Web-Expensify/pull/40008 so not tied to the backend PR that was tagged.

It looks like it's most likely the result of #32546 cc: @mountiny @kubabutkiewicz @shubham1206agra

The simplest solution to this is just to use || instead of ?? here

Edit: Based on the linter failing, seems like we might not allow || instead of ??. If that's the case, then @ishpaul777's solution is good 👍

[NikkiWines]

Yep, I'll apply your solution to my PR @ishpaul777 and you can be compensated for providing a valid solution here

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[NikkiWines]

@laurenreidexpensify can we issue payment to @ishpaul777 for providing the solution to this deploy blocker please

[laurenreidexpensify]

Will do, following the process where this is on prod for 7 days

[melvin-bot]

Current assignee @laurenreidexpensify is eligible for the Bug assigner, not assigning anyone new.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[laurenreidexpensify]

@ishpaul777 pls apply to the job in Upwork thanks upwork.com/jobs/~014d0b71872c14469e

[mountiny]

Since it was internal person applying the fix and not the contributor we usually go with 25% of the original reward so that would be $125 to @ishpaul777

[cubuspl42]

Reproduced on latest main. Affects iOS Native too, although I couldn't reproduce this on Android Native. Weird.

PR reviewed & approved.

[Julesssss]

This is showing on the latest checklist as I didn't remove the label. This is now resolved and awaiting payment.

[laurenreidexpensify]

Prod for 7 days will be Dec 21st

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.13-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix greyed out workspace icon for workspace distance requests  #33005

If no regressions arise, payment will be issued on 2023-12-26. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @ishpaul777 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@NikkiWines] The PR that introduced the bug has been identified. Link to the PR: Fix/ Chat - WS custom avatar is not updated in chat conversation after request money #32546
• [@NikkiWines] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Fix/ Chat - WS custom avatar is not updated in chat conversation after request money #32546 (comment)
• [@NikkiWines] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@ishpaul777] Determine if we should create a regression test for this bug.
• [@ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @bfitzexpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[melvin-bot]

### Payment Summary
[Upwork Job](https://www.upwork.com/jobs/~014d0b71872c14469e)
- <Role>: @ishpaul777 paid $(<amount>) via Upwork (<Replace with offer link>)

#### BugZero Checklist (@bfitzexpensify)
- [ ] I have verified the correct assignees and roles are listed above
- [ ] I have verified that there are no duplicate or incorrect contracts on Upwork (https://www.upwork.com/ab/applicants/1735260103087415296/hired)
- [ ] I have paid out the Upwork contracts or cancelled the ones that are incorrect
- [ ] I have verified the payment summary above is correct

[bfitzexpensify]

Offer sent @ishpaul777

[bfitzexpensify]

Also, @ishpaul777 can you please complete the checklist in #32984 (comment)? Thanks!

[ishpaul777]

Actually I dont have access to guidelines to complete checklist items thats basically what C+ does on normal issues, but from my experience with similar issues i think this was minor syntax mistake in code that cause the bug so no regression test requires..

[bfitzexpensify]

Cool, that seems fair to me. OK, let's close this one out then.