Fix the current issue and regression #32647

dukenv0307 · 2023-12-07T11:15:23Z

Details

Fix the current issue and regression.
Pass transactionID prop to AttachmentView in AttachmenModal, pass originalFileName to AttachmentModal in ReportActionItemImage and refactor logic of headerTitle

Fixed Issues

$ #31105
$ #32501
$ #32504
$ #32514
PROPOSAL: #31105 (comment)

Tests

Fix issue 31105

Create a scan request
Go to IOU report
Send an attachment
Open attachment preview
Verify that the receipt image isn't in carousel
Click on the request preview to go to IOU detail page
Send a attachment
Click on receipt image
Verify that the receipt image isn't carousel

Fix issue 32501

Go offline
Create a distance request
Go to transaction thread report of this request
Click on receipt image
Verify that the EReceipt image is displayed

Fix issue 32504

Log in as the WS employee
Navigate to expense request conversation that has a receipt
Click on the receipt thumbnail
Verify there's a 3 dot menu on the top right
Click on replace
Upload a new receipt
Verify the new receipt is displayed in the request
Click on the receipt thumbnail
Click close the receipt thumbnail
Verify that the modal is closed and edit receipt page doesn't appear

Fix issue 32514

Tap on a group chat
Tap header display names
Tap on a profile icon
Verify that display name is displayed in attachment modal

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Fix issue 31105

Create a scan request
Go to IOU report
Send an attachment
Open attachment preview
Verify that the receipt image isn't in carousel
Click on the request preview to go to IOU detail page
Send a attachment
Click on receipt image
Verify that the receipt image isn't carousel

Fix issue 32501

Go offline
Create a distance request
Go to transaction thread report of this request
Click on receipt image
Verify that the EReceipt image is displayed

Fix issue 32504

Log in as the WS employee
Navigate to expense request conversation that has a receipt
Click on the receipt thumbnail
Verify there's a 3 dot menu on the top right
Click on replace
Upload a new receipt
Verify the new receipt is displayed in the request
Click on the receipt thumbnail
Click close the receipt thumbnail
Verify that the modal is closed and edit receipt page doesn't appear

Fix issue 32514

Tap on a group chat
Tap header display names
Tap on a profile icon
Verify that display name is displayed in attachment modal

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2023-11-17.at.11.28.25.mov

Android: mWeb Chrome

Screen.Recording.2023-11-17.at.11.22.29.mov

iOS: Native

Screen.Recording.2023-11-17.at.11.31.50.mov

iOS: mWeb Safari

Screen.Recording.2023-11-17.at.11.24.56.mov

MacOS: Chrome / Safari

Screen.Recording.2023-11-17.at.11.20.39.mov

MacOS: Desktop

Fix issue 31105

Screen.Recording.2023-11-17.at.11.37.15.mov

Fix issue 32501

Screen.Recording.2023-12-07.at.18.07.53.mov

Fix issue 32504

web-1.mov

Fix issue 32514

Screen.Recording.2023-12-07.at.18.09.12.mov

melvin-bot · 2023-12-07T11:15:44Z

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dukenv0307 · 2023-12-11T04:48:47Z

@mananjadhav Friendly bump

shubham1206agra · 2023-12-11T12:59:19Z

src/components/Attachments/AttachmentCarousel/index.js

@@ -241,15 +229,6 @@ export default compose(
            canEvict: false,
        },
    }),
-    // eslint-disable-next-line rulesdir/no-multiple-onyx-in-file


Please remove this line from above too

@shubham1206agra Updated.

shubham1206agra · 2023-12-11T13:35:59Z

And one more thing. AttachmentView has transaction coming from withOnyx as well as from prop in AttachmentModal. Can you fix this? Maybe just pass transactionID instead of whole transaction

dukenv0307 · 2023-12-11T13:40:25Z

@shubham1206agra Updated to pass transactionID.

shubham1206agra · 2023-12-11T13:41:18Z

Please update the details section too

dukenv0307 · 2023-12-11T13:42:36Z

@shubham1206agra Done.

shubham1206agra · 2023-12-11T13:58:20Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2023-12-11.at.7.15.34.PM.mov

Android: mWeb Chrome

Screen.Recording.2023-12-11.at.6.32.54.PM.mov

iOS: Native

Screen.Recording.2023-12-11.at.6.52.55.PM.mov

iOS: mWeb Safari

Screen.Recording.2023-12-11.at.6.23.17.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2023-12-11.at.6.04.06.PM.mov

MacOS: Desktop

Screen.Recording.2023-12-11.at.6.42.02.PM.mov

shubham1206agra

LGTM!

hayata-suenaga

LGTM! thank you for the work!

OSBotify · 2023-12-11T20:26:05Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-12-13T11:30:28Z

🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.4.12-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

OSBotify · 2023-12-13T11:51:11Z

🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.4.12-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

OSBotify · 2023-12-13T12:18:45Z

🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.4.12-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-12-14T15:25:28Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.12-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

dukenv0307 added 2 commits December 7, 2023 17:29

fix the current issue and regression

7754956

remove call back

0e7b5cf

dukenv0307 marked this pull request as ready for review December 7, 2023 11:15

dukenv0307 requested a review from a team as a code owner December 7, 2023 11:15

melvin-bot bot requested review from mananjadhav and removed request for a team December 7, 2023 11:15

dukenv0307 added 2 commits December 7, 2023 18:37

fix lint

8ec3cb5

merge main

d0ec622

situchan mentioned this pull request Dec 11, 2023

Fix: Attachment - Hmm its not here page displayed on login with receipt attachment URL #30561

Closed

58 tasks

mountiny requested review from shubham1206agra and removed request for mananjadhav December 11, 2023 12:01

shubham1206agra reviewed Dec 11, 2023

View reviewed changes

remove comment

bed8319

pass transactionID to AttachmentView

e963f05

shubham1206agra approved these changes Dec 11, 2023

View reviewed changes

melvin-bot bot requested a review from hayata-suenaga December 11, 2023 14:10

hayata-suenaga approved these changes Dec 11, 2023

View reviewed changes

hayata-suenaga merged commit 3358b03 into Expensify:main Dec 11, 2023
17 checks passed

aimane-chnaif mentioned this pull request Dec 12, 2023

The app should take the user back to the profile page when the user clicks the back button in the web browser #28999

Merged

50 tasks

github-actions bot mentioned this pull request Dec 13, 2023

[$500] Deploy Checklist: New Expensify 2023-12-13 #32963

Closed

64 tasks

shubham1206agra mentioned this pull request Dec 15, 2023

[Awaiting Payment 11th Jan] [$500] Chat-"Hmm... it's not here" appears after clicking Previous arrow from an attachment preview #31105

Closed

6 tasks

situchan mentioned this pull request Dec 20, 2023

[HOLD for payment 2024-01-11] [$500] IOU- When replacing receipt and downloading it, previous receipt with new receipt name is downloaded #33363

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix the current issue and regression #32647

Fix the current issue and regression #32647

dukenv0307 commented Dec 7, 2023 •

edited

Loading

melvin-bot bot commented Dec 7, 2023

dukenv0307 commented Dec 11, 2023

shubham1206agra Dec 11, 2023

dukenv0307 Dec 11, 2023

shubham1206agra commented Dec 11, 2023 •

edited

Loading

dukenv0307 commented Dec 11, 2023

shubham1206agra commented Dec 11, 2023

dukenv0307 commented Dec 11, 2023

shubham1206agra commented Dec 11, 2023

shubham1206agra left a comment

hayata-suenaga left a comment

OSBotify commented Dec 11, 2023

OSBotify commented Dec 13, 2023

OSBotify commented Dec 13, 2023

OSBotify commented Dec 13, 2023

OSBotify commented Dec 14, 2023

Fix the current issue and regression #32647

Fix the current issue and regression #32647

Conversation

dukenv0307 commented Dec 7, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 7, 2023

dukenv0307 commented Dec 11, 2023

shubham1206agra Dec 11, 2023

Choose a reason for hiding this comment

dukenv0307 Dec 11, 2023

Choose a reason for hiding this comment

shubham1206agra commented Dec 11, 2023 • edited Loading

dukenv0307 commented Dec 11, 2023

shubham1206agra commented Dec 11, 2023

dukenv0307 commented Dec 11, 2023

shubham1206agra commented Dec 11, 2023

Reviewer Checklist

Screenshots/Videos

shubham1206agra left a comment

Choose a reason for hiding this comment

hayata-suenaga left a comment

Choose a reason for hiding this comment

OSBotify commented Dec 11, 2023

OSBotify commented Dec 13, 2023

OSBotify commented Dec 13, 2023

OSBotify commented Dec 13, 2023

OSBotify commented Dec 14, 2023

dukenv0307 commented Dec 7, 2023 •

edited

Loading

shubham1206agra commented Dec 11, 2023 •

edited

Loading