[HOLD for payment 2024-01-11] [$500] IOU - While editing amount for manual request with receipt, "next" button is displayed below

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.12
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Tap fab
3. Tap request money ----Manual
4. Enter an amount
5. Tap next
6. Select a contact
7. Tap 3 dots on top right and add a receipt
8. Tap request
9. Tap on the manual request newly created
10. Tap on amount & change the amount
11. Note Next button displayed below
12. Tap description and note Save button displayed below

Expected Result:

While editing amount for manual request with receipt, "next" button must be displayed

Actual Result:

While editing amount for manual request with receipt, "next" button is displayed below instead of "save" button

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6312163_1702497303682.next.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0159762618665c827d
• Upwork Job ID: 1735034314000285696
• Last Price Increase: 2023-12-13
• Automatic offers:
• situchan | Reviewer | 28062582
• neonbhai | Contributor | 28062583

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0159762618665c827d

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

While editing amount for manual request with receipt, "next" button is displayed below

What is the root cause of that problem?

We don't pass the isEditing prop in EditRequestAmountPage here:

App/src/pages/EditRequestAmountPage.js

Lines 51 to 58 in 3df907c

	<MoneyRequestAmountForm
	buttonTranslationText="common.save"
	currency={defaultCurrency}
	amount={defaultAmount}
	ref={(e) => (textInput.current = e)}
	onCurrencyButtonPress={onNavigateToCurrency}
	onSubmitButtonPress={onSubmit}
	/>

isEditing is false by default, and this makes the button text as "next":

App/src/pages/iou/steps/MoneyRequestAmountForm.js

Line 251 in 3df907c

const buttonText = isEditing ? translate('common.save') : translate('common.next');

What changes do you think we should make in order to solve the problem?

We should pass the isEditing prop here

[samilabud]

Proposal

Please re-state the problem that we are trying to solve in this issue.

While editing amount for manual request with receipt, "next" button is displayed below

What is the root cause of that problem?

When we use the MoneyRequestView component to open EditRequestAmountPage component we should specify that we are editing.

What changes do you think we should make in order to solve the problem?

We should pass the editing prop in EditRequestAmountPage component as true like:

<MoneyRequestAmountForm
                buttonTranslationText="common.save"
                currency={defaultCurrency}
                amount={defaultAmount}
                ref={(e) => (textInput.current = e)}
                onCurrencyButtonPress={onNavigateToCurrency}
                onSubmitButtonPress={onSubmit}
                isEditing
            />

Result:

Screen.Recording.2023-12-13.at.4.51.05.PM.mov

[isabelastisser]

@situchan can you please review the proposals above? Thanks!

[situchan]

@neonbhai's proposal looks good to me.
Let's also remove buttonTranslationText which is no longer used.
🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @Gonals, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @neonbhai 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[Gonals]

@neonbhai's proposal looks good to me. Let's also remove buttonTranslationText which is no longer used. 🎀 👀 🎀 C+ reviewed

Sounds good!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.21-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [IOU] Manual request flow button fix #33263

If no regressions arise, payment will be issued on 2024-01-11. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @neonbhai requires payment automatic offer (Contributor)
• @situchan requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @kadiealexander you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[isabelastisser]

@situchan, can you please complete the checklist above? Thanks!

[isabelastisser]

Payment summary:

@neonbhai (Contributor) $500 already paid in Upwork.
@situchan(Reviewer) $500 already paid in Upwork.

cc @kadiealexander

[situchan]

• The PR that introduced the bug has been identified. Link to the PR: Refactor/23149 money request page #23979
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/23979/files#r1449295106
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug.
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

No need regression test as caught by QA team

[isabelastisser]

All set!

[kadiealexander]

Melvin's a liar, there was an excellent BugZero teammate assigned! Thanks Isa.