[$500] Web - When a user changes their profile status, the app brings you to the end of the conversation. #33110

lanitochka17 · 2023-12-14T18:48:48Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.13.0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Launch the app
Log in with any account
Open the 1:1 conversation
Scroll to the middle
Go to the seating - Profile - Status
Change the status

Expected Result:

When a user changes their profile status, the app should stay in the same conversation position

Actual Result:

When a user changes their profile status, the app brings you to the end of the conversation

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6313458_1702578893863.Recording__5707.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~017a47704cf8762519
Upwork Job ID: 1735371288086798336
Last Price Increase: 2024-01-04

melvin-bot · 2023-12-14T18:48:53Z

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-12-14T18:48:53Z

Job added to Upwork: https://www.upwork.com/jobs/~017a47704cf8762519

melvin-bot · 2023-12-14T18:48:55Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

melvin-bot · 2023-12-14T18:48:59Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

FitseTLT · 2023-12-14T19:42:57Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

When a user changes their profile status, the app brings you to the end of the conversation.

What is the root cause of that problem?

Currently we are popingToTop after saving a profile status as we set setShouldPopAllStateOnUP when we come from the status button flow (not profile > status flow) here

App/src/pages/home/sidebar/AvatarWithOptionalStatus.js

Lines 32 to 39 in 904cf56

    
           const showStatusPage = useCallback(() => { 
        
               if (isCreateMenuOpen) { 
        
                   // Prevent opening Settings page when click profile avatar quickly after clicking FAB icon 
        
                   return; 
        
               } 
        
               Navigation.setShouldPopAllStateOnUP(); 
        
               Navigation.navigate(ROUTES.SETTINGS_STATUS);

so the page is unnecessarily reloading and the report screen is scrolled to bottom creating a disturbing user experience and I think we should avoid this unnecessary reloading.

What changes do you think we should make in order to solve the problem?

We should use goBack when we come from the status button flow without fallbackRoute we can do that by saving an indicator that the user comes from the status button flow (like fromStatusButonFlow in onyx) here

App/src/pages/home/sidebar/AvatarWithOptionalStatus.js

Lines 32 to 39 in 904cf56

    
           const showStatusPage = useCallback(() => { 
        
               if (isCreateMenuOpen) { 
        
                   // Prevent opening Settings page when click profile avatar quickly after clicking FAB icon 
        
                   return; 
        
               } 
        
               Navigation.setShouldPopAllStateOnUP(); 
        
               Navigation.navigate(ROUTES.SETTINGS_STATUS);

App/src/pages/settings/Profile/CustomStatus/StatusPage.js

Line 72 in 904cf56

    
           const navigateBackToPreviousScreen = useCallback(() => Navigation.goBack(ROUTES.SETTINGS_PROFILE, false, true), []);

 const navigateBackToPreviousScreen = useCallback(() => {
        if (fromStatusButtonFlow) {
            resetFromStatusButtonFlow();
            Navigation.goBack();
        } else Navigation.goBack(ROUTES.SETTINGS_PROFILE, false, true);
    }, []);

The necessity of saving it in onyx is to make it work perfectly on page refresh. otherwise, we can also use global variable just similar to shouldPopAllStateOnUP. By the way, currently, if you press the status button and then on the status page refresh and press back on the status page it navigates to profile page which is wrong (related bug) it should pop the RHP as it would if you haven't refreshed.

What alternative solutions did you explore? (Optional)

bernhardoj · 2023-12-15T07:01:55Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

If we open another chat, then open the status page from the sidebar (settings) avatar, and then close it, a new chat will open.

What is the root cause of that problem?

When we open the status page from the sidebar avatar, we set shouldPopAllStateOnUP.

App/src/pages/home/sidebar/AvatarWithOptionalStatus.js

Lines 38 to 39 in 3a44f77

    
           Navigation.setShouldPopAllStateOnUP(); 
        
           Navigation.navigate(ROUTES.SETTINGS_STATUS);

Then, on pressing back/save, we call goBack with shouldPopToTop (3rd param) as true.

App/src/pages/settings/Profile/CustomStatus/StatusPage.js

Line 72 in 3a44f77

    
           const navigateBackToPreviousScreen = useCallback(() => Navigation.goBack(ROUTES.SETTINGS_PROFILE, false, true), []);

If both shouldPopAllStateOnUP and shouldPopToTop are true, it will pop all screens up to the LHN.

App/src/libs/Navigation/Navigation.ts

Lines 146 to 152 in 3a44f77

    
           if (shouldPopToTop) { 
        
               if (shouldPopAllStateOnUP) { 
        
                   shouldPopAllStateOnUP = false; 
        
                   navigationRef.current?.dispatch(StackActions.popToTop()); 
        
                   return; 
        
               } 
        
           }

So, the current report is also popped out from the stack, and a new one will be added.

What changes do you think we should make in order to solve the problem?

I would like to propose a quite different solution. First of all, I think we shouldn't use setShouldPopAllStateOnUP. I see 1 flaw with that approach.

If we open the status page from the sidebar avatar, shouldPopAllStateOnUP will be true. If we close the status page by pressing the overlay, shouldPopAllStateOnUP will stay true (we only reset shouldPopAllStateOnUP when calling goBack).

Because it's still true if we open the status page from the profile page and press back, it will pop out all screens, even though it should go back to the profile page.

So, the solution I would like to propose is to have a different route path for the status page, depending on where we open it. If we open it from the sidebar avatar, we will navigate to /status, but if we open it from the profile page, then we will navigate to the same route we have now, that is /settings/profile/status.

App/src/pages/home/sidebar/AvatarWithOptionalStatus.js

Lines 38 to 39 in 3a44f77

    
           Navigation.setShouldPopAllStateOnUP(); 
        
           Navigation.navigate(ROUTES.SETTINGS_STATUS);

Navigation.navigate(ROUTES.STATUS);

Then, based on the current route, we can decide whether we need the fallback route or not.

const navigateBackToPreviousScreen = useCallback(() => {
    const path = Navigation.getActiveRoute();
    const fallbackRoute = path.startsWith(ROUTES.SETTINGS_PROFILE) ? ROUTES.SETTINGS_PROFILE : '';
    // or const fallbackRoute = route.name === SCREENS.SETTINGS.PROFILE.STATUS ? ROUTES.SETTINGS_PROFILE : '';
    Navigation.goBack(fallbackRoute);
}, []);

Here is how you add the new route

Add a new entry to ROUTES.ts (this is the route path)
STATUS: 'status'
Add a new entry to SCREENS.ts (this is the route name)
STATUS: 'Status'
Add a new entry to linkingConfig.ts (binding it up, you can add it above SCREENS.SETTINGS.PROFILE.STATUS)

[SCREENS.STATUS]: {
    path: ROUTES.STATUS,
    exact: true,
},

Add a new screen in ModalStackNavigators.tsx, specifically in SettingsModalStackNavigator navigator. (you can add it above SCREENS.SETTINGS.PROFILE.STATUS)

[SCREENS.STATUS]: () => require('../../../pages/settings/Profile/CustomStatus/StatusPage').default as React.ComponentType,

github-actions · 2023-12-15T23:43:16Z

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

melvin-bot · 2023-12-15T23:43:17Z

Current assignee @puneetlath is eligible for the Engineering assigner, not assigning anyone new.

suneox · 2023-12-17T17:13:13Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - When a user changes their profile status, the app brings you to the end of the conversation.

What is the root cause of that problem?

After save status will Navigation.goBack at function navigateBackToPreviousScreen after that the state of the report screen will be reset

What changes do you think we should make in order to solve the problem?

We have to check the current state has topmostReportId and route history then we will navigate to report screen instead of go back at this line

    const routesHistory = useNavigationState((state) => state.routes || []);
    const navigateBackToPreviousScreen = useCallback(() => {
        const topmostReportId = Navigation.getTopmostReportId();
        if (topmostReportId && routesHistory.length === 1 && !routesHistory[0].path) {
            Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(topmostReportId));
        } else {
            Navigation.goBack(ROUTES.SETTINGS_PROFILE, false, true)
        }
    }, [routesHistory]);

POC

33110_2.mp4

What alternative solutions did you explore? (Optional)

mananjadhav · 2023-12-17T19:00:57Z

@lanitochka17 Is this still reproducible? I can't seem to be able to reproduce this.

Screen.Recording.2023-12-18.at.12.29.55.AM.mov

mananjadhav · 2023-12-17T19:20:34Z

@FitseTLT I don't think so. The linked commit is not merged, but used as a part of the proposal.

FitseTLT · 2023-12-17T19:26:06Z

@mananjadhav Now it is opening another report when I save status. Before 3 days it was reloading the current report. Odd!!

suneox · 2023-12-18T00:28:54Z

@lanitochka17 Is this still reproducible? I can't seem to be able to reproduce this.

@mananjadhav it still reproduce by click on a status icon on the left of avatar, the description is missed step click on the icon next to avatar. you can view a video attachment in description

puneetlath · 2023-12-18T16:46:57Z

I am able to reproduce it @mananjadhav. However, I don't think this needs to be a deploy blocker.

DylanDylann · 2024-02-06T06:07:19Z

@suneox

You have provided a reference issue and then you changed the expected behavior.

I do not change the expected behavior. The reproduce steps in here are not the same as the one I mentioned above. So the expected in both cases are not the same
Generally, the expected is that, clicking on back button will bring user to the previous screen

suneox · 2024-02-06T06:39:15Z

I do not change the expected behavior. The reproduce steps in here are not the same as the one I mentioned above. So the expected in both cases are not the same

The reproduce step do not include reload step.
@DylanDylann
First you have raised regression is #33002

Generally, the expected is that, clicking on back button will bring user to the previous screen

And now your expected behavior is the same for reload case, I think you not fair when you raise regression and then you update the current behavior is a regression, so how about your the expected behavior on you issue has linked when reload?

DylanDylann · 2024-02-06T06:43:02Z

The reproduce step do not include reload step.

I mentioned it in step 4

so how about your the expected behavior on you issue #33002 when reload?

I think the expected is: clicking on back button will bring user to the previous screen

suneox · 2024-02-06T06:49:21Z

so how about your the expected behavior on you issue #33002 when reload?

I think the expected is: clicking on back button will bring user to the previous screen

The expected behavior in #33002 after reload is App should open profile page on click on back on status page so let @puneetlath and @mananjadhav confirm the expected behavior

DylanDylann · 2024-02-06T06:52:05Z

@suneox Sure. FYI, there was a similar issue #30509

puneetlath · 2024-02-20T21:30:22Z

@mananjadhav what are your thoughts on this issue?

mananjadhav · 2024-02-21T00:05:09Z

I checked the PR, but I'll check all the comments today.

puneetlath · 2024-02-22T15:46:02Z

@mananjadhav bump!

mananjadhav · 2024-02-25T17:58:11Z

Was unwell past few days, will get to this by tomorrow.

puneetlath · 2024-03-01T21:06:41Z

@mananjadhav any update?

mananjadhav · 2024-03-05T16:52:04Z

I went through the PR and the comments discussion. There was substantial delay from my side to review the comments.

But I don't think this is still reproducible anymore. We don't have a Profile modal, we have the Profile page. Opening the status shows the Profile page, moving away from the report page. Reloading the page should go back to the Profile page, so I think this is working as expected.

@lanitochka17 Can you confirm if this is still reproducible at your end?

web-status-profile-reload.mov

mvtglobally · 2024-03-06T01:00:53Z

Since the page goes to profile, it resets back to the bottom. If the expectation is to reset, than issue is no longer applicable,
https://github.com/Expensify/App/assets/43995119/f3d7fd48-fee3-40ca-81e1-6056812f6813

mananjadhav · 2024-03-10T18:47:02Z

@puneetlath What should we do here?

puneetlath · 2024-03-14T16:52:51Z

I think we should close this out. The original bug isn't there anymore and I think what is shown in @mvtglobally's video is fine.

Thanks for your input everyone!

puneetlath · 2024-04-18T17:02:29Z

Reopening this since the work was completed, so there should be some payment made. Being discussed here: https://expensify.slack.com/archives/C02NK2DQWUX/p1713323524607299

suneox · 2024-04-21T04:39:49Z

Hi @puneetlath,

I believe that fair compensation is warranted for the time I spent investigating solutions, creating and updating the PR. This is because another contributor raised a regression issue that was not clearly communicated. Additionally, this contributor made multiple updates without notifying others after my solution works he also continued to update, and the reviewer also delayed reviewing the PR.

puneetlath · 2024-05-04T16:46:27Z

Ok, I've reviewed the thread/PR and I think that @suneox is due compensation since they did do the work they were hired for, though we didn't end up using it.

I think @mananjadhav is due 50% compensation since they did partial work, but did not review/test the PR.

Payment summary:
C - @suneox - $500 - to be paid via Upwork
C+ - @mananjadhav $250 - to be paid via NewDot

@suneox can you please send me a link to your upwork profile?
@mananjadhav please request on NewDot.

mananjadhav · 2024-05-04T16:51:08Z

Thanks @puneetlath. Agreed with the assessment.

suneox · 2024-05-04T16:56:31Z

@puneetlath Thanks for recognizing the effort put into our work, here is my upwork profile

JmillsExpensify · 2024-05-04T17:12:40Z

$250 approved for @mananjadhav

puneetlath · 2024-05-04T17:23:51Z

Np y'all. Thanks for your patience. @suneox offer is here: https://www.upwork.com/nx/wm/offer/102163593

Please ping me on the issue when you've accepted it.

suneox · 2024-05-04T17:28:53Z

Please ping me on the issue when you've accepted it.

@puneetlath I have accepted an offer. Thank you!

puneetlath · 2024-05-04T17:37:42Z

Ok all paid. Thanks y'all!

lanitochka17 added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Dec 14, 2023

melvin-bot bot changed the title ~~Web - When a user changes their profile status, the app brings you to the end of the conversation.~~ [$500] Web - When a user changes their profile status, the app brings you to the end of the conversation. Dec 14, 2023

melvin-bot bot assigned puneetlath Dec 14, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 14, 2023

melvin-bot bot assigned mananjadhav Dec 14, 2023

lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Dec 15, 2023

github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Dec 15, 2023

github-actions bot mentioned this issue Dec 15, 2023

Deploy Checklist: New Expensify 2023-12-14 #33072

Closed

77 tasks

melvin-bot bot added the Overdue label Dec 17, 2023

melvin-bot bot removed the Overdue label Dec 17, 2023

puneetlath removed the DeployBlockerCash This issue or pull request should block deployment label Dec 18, 2023

quinthar moved this from MEDIUM to LOW in [#whatsnext] #vip-vsb Feb 9, 2024

puneetlath closed this as completed Mar 14, 2024

github-project-automation bot moved this from LOW to CRITICAL in [#whatsnext] #vip-vsb Mar 14, 2024

puneetlath reopened this Apr 18, 2024

quinthar moved this from CRITICAL to MEDIUM in [#whatsnext] #vip-vsb Apr 18, 2024

puneetlath closed this as completed May 4, 2024

suneox mentioned this issue Aug 14, 2024

[$250] Assign task - Reply Activity Not Displayed in "Share Somewhere" Section #40891

Closed

6 tasks

[$500] Web - When a user changes their profile status, the app brings you to the end of the conversation. #33110

[$500] Web - When a user changes their profile status, the app brings you to the end of the conversation. #33110

Comments

lanitochka17 commented Dec 14, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Dec 14, 2023

melvin-bot bot commented Dec 14, 2023

melvin-bot bot commented Dec 14, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot bot commented Dec 14, 2023

FitseTLT commented Dec 14, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

bernhardoj commented Dec 15, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

github-actions bot commented Dec 15, 2023

melvin-bot bot commented Dec 15, 2023

suneox commented Dec 17, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

mananjadhav commented Dec 17, 2023

mananjadhav commented Dec 17, 2023

FitseTLT commented Dec 17, 2023

suneox commented Dec 18, 2023 • edited Loading

puneetlath commented Dec 18, 2023

DylanDylann commented Feb 6, 2024 • edited Loading

suneox commented Feb 6, 2024

DylanDylann commented Feb 6, 2024

suneox commented Feb 6, 2024

DylanDylann commented Feb 6, 2024

puneetlath commented Feb 20, 2024

mananjadhav commented Feb 21, 2024

puneetlath commented Feb 22, 2024

mananjadhav commented Feb 25, 2024

puneetlath commented Mar 1, 2024

mananjadhav commented Mar 5, 2024 • edited Loading

mvtglobally commented Mar 6, 2024

mananjadhav commented Mar 10, 2024

puneetlath commented Mar 14, 2024

puneetlath commented Apr 18, 2024 • edited Loading

suneox commented Apr 21, 2024

puneetlath commented May 4, 2024

mananjadhav commented May 4, 2024 • edited Loading

suneox commented May 4, 2024

JmillsExpensify commented May 4, 2024

puneetlath commented May 4, 2024

suneox commented May 4, 2024

puneetlath commented May 4, 2024

lanitochka17 commented Dec 14, 2023 •

edited by melvin-bot bot

Loading

FitseTLT commented Dec 14, 2023 •

edited

Loading

bernhardoj commented Dec 15, 2023 •

edited

Loading

suneox commented Dec 17, 2023 •

edited

Loading

suneox commented Dec 18, 2023 •

edited

Loading

DylanDylann commented Feb 6, 2024 •

edited

Loading

mananjadhav commented Mar 5, 2024 •

edited

Loading

puneetlath commented Apr 18, 2024 •

edited

Loading

mananjadhav commented May 4, 2024 •

edited

Loading