-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-12-28] [Theme Switching] 🐛 - Animation on 2FA confirmation has a dark background when light theme applied #33116
Comments
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Triggered auto assignment to @stitesExpensify ( |
same root cause as #33106 |
cool, thanks! |
Gonna take this one if that's alright @stitesExpensify |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.14-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-12-28. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
|
@grgia Eep! 4 days overdue now. Issues have feelings too... |
1 similar comment
@grgia Eep! 4 days overdue now. Issues have feelings too... |
Triggered auto assignment to @peterdbarkerUK ( |
This comment was marked as resolved.
This comment was marked as resolved.
@peterdbarkerUK could you help ensure that @rushatgabhane is paid $500 C+ review for the review of #33189 |
Payment handled here #33189 (comment) |
Closing as complete! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.13-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Precondition: set the light theme in the app
Expected Result:
The animation on the confirmation screen has a light background
Actual Result:
The animation has a black background
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6313462_1702579069795.video_2023-12-14_13-33-31.mp4
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: