Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-12-28] [Theme Switching] 🐛 - Animation on 2FA confirmation has a dark background when light theme applied #33116

Closed
6 tasks done
lanitochka17 opened this issue Dec 14, 2023 · 14 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@lanitochka17
Copy link

lanitochka17 commented Dec 14, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.13-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Precondition: set the light theme in the app

  1. Open the app and log in
  2. Tap Settings > Security > Two-factor authentication
  3. Set up Two-factor authentication

Expected Result:

The animation on the confirmation screen has a light background

Actual Result:

The animation has a black background

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6313462_1702579069795.video_2023-12-14_13-33-31.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Dec 14, 2023
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Dec 14, 2023

Triggered auto assignment to @stitesExpensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@grgia
Copy link
Contributor

grgia commented Dec 14, 2023

same root cause as #33106
removing the deploy blocker label

@stitesExpensify
Copy link
Contributor

cool, thanks!

@grgia grgia changed the title Theme - Animation on 2FA confirmation has a dark background when light theme applied [Theme Switching] 🐛 - Animation on 2FA confirmation has a dark background when light theme applied Dec 14, 2023
@grgia grgia assigned grgia and unassigned stitesExpensify Dec 14, 2023
@grgia
Copy link
Contributor

grgia commented Dec 14, 2023

Gonna take this one if that's alright @stitesExpensify

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 Weekly KSv2 labels Dec 15, 2023
@melvin-bot melvin-bot bot changed the title [Theme Switching] 🐛 - Animation on 2FA confirmation has a dark background when light theme applied [HOLD for payment 2023-12-28] [Theme Switching] 🐛 - Animation on 2FA confirmation has a dark background when light theme applied Dec 21, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 21, 2023
Copy link

melvin-bot bot commented Dec 21, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Dec 21, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.14-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-12-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Dec 27, 2023
@melvin-bot melvin-bot bot added the Overdue label Dec 29, 2023
Copy link

melvin-bot bot commented Jan 1, 2024

@grgia Eep! 4 days overdue now. Issues have feelings too...

1 similar comment
Copy link

melvin-bot bot commented Jan 1, 2024

@grgia Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot melvin-bot bot removed the Overdue label Jan 2, 2024
@grgia grgia added Overdue Bug Something is broken. Auto assigns a BugZero manager. labels Jan 2, 2024
Copy link

melvin-bot bot commented Jan 2, 2024

Triggered auto assignment to @peterdbarkerUK (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot removed the Overdue label Jan 2, 2024

This comment was marked as resolved.

@grgia
Copy link
Contributor

grgia commented Jan 2, 2024

@peterdbarkerUK could you help ensure that @rushatgabhane is paid $500 C+ review for the review of #33189

@rushatgabhane
Copy link
Member

rushatgabhane commented Jan 3, 2024

Payment handled here #33189 (comment)
Thank you!

@melvin-bot melvin-bot bot added the Overdue label Jan 5, 2024
@grgia
Copy link
Contributor

grgia commented Jan 5, 2024

Closing as complete!

@grgia grgia closed this as completed Jan 5, 2024
@melvin-bot melvin-bot bot removed the Overdue label Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
No open projects
Development

No branches or pull requests

5 participants