Use transparent lottie animations #33189

grgia · 2023-12-15T19:03:57Z

Details

Two of our animations had a colored background, I've replaced these with animations with a transparent background

Screen.Recording.2023-12-15.at.11.19.41.AM.mov

Screen.Recording.2023-12-15.at.11.22.20.AM.mov

Screen.Recording.2023-12-15.at.11.21.01.AM.mov

Screen.Recording.2023-12-15.at.11.21.18.AM.mov

Fixed Issues

$ #33106
$ #33116

Tests

Verify that no errors appear in the JS console

Apply this diff

diff --git a/assets/animations/Fireworks.lottie b/assets/animations/Fireworks.lottie
index f5a782c62f..142efdcd8f 100644
Binary files a/assets/animations/Fireworks.lottie and b/assets/animations/Fireworks.lottie differ
diff --git a/assets/animations/ReviewingBankInfo.lottie b/assets/animations/ReviewingBankInfo.lottie
index 93addc052e..a9974366ca 100644
Binary files a/assets/animations/ReviewingBankInfo.lottie and b/assets/animations/ReviewingBankInfo.lottie differ
diff --git a/src/pages/EnablePayments/EnablePaymentsPage.js b/src/pages/EnablePayments/EnablePaymentsPage.js
index 257eab1d38..2eb2e73403 100644
--- a/src/pages/EnablePayments/EnablePaymentsPage.js
+++ b/src/pages/EnablePayments/EnablePaymentsPage.js
@@ -70,7 +70,7 @@ function EnablePaymentsPage({userWallet}) {
                     );
                 }

-                const currentStep = userWallet.currentStep || CONST.WALLET.STEP.ADDITIONAL_DETAILS;
+                const currentStep = CONST.WALLET.STEP.ACTIVATE;

                 switch (currentStep) {
                     case CONST.WALLET.STEP.ADDITIONAL_DETAILS:
diff --git a/src/pages/settings/Security/TwoFactorAuth/TwoFactorAuthSteps.js b/src/pages/settings/Security/TwoFactorAuth/TwoFactorAuthSteps.js
index 720c2e02b3..46c06835a0 100644
--- a/src/pages/settings/Security/TwoFactorAuth/TwoFactorAuthSteps.js
+++ b/src/pages/settings/Security/TwoFactorAuth/TwoFactorAuthSteps.js
@@ -47,7 +47,7 @@ function TwoFactorAuthSteps({account = defaultAccount}) {
     const contextValue = useMemo(() => ({setStep: handleSetStep}), [handleSetStep]);

     const renderStep = () => {
-        switch (currentStep) {
+        switch (CONST.TWO_FACTOR_AUTH_STEPS.SUCCESS) {
             case CONST.TWO_FACTOR_AUTH_STEPS.CODES:
                 return <CodesStep backTo={backTo} />;
             case CONST.TWO_FACTOR_AUTH_STEPS.VERIFY:
(END)

Go to https://dev.new.expensify.com:8082/enable-payments
Toggle Light/Dark Mode and ensure animation is transparent ✅
Go to https://dev.new.expensify.com:8082/settings/security/two-factor-auth
Toggle Light/Dark Mode and ensure animation is transparent ✅

Offline tests

QA Steps

Verify that no errors appear in the JS console

ACCESS BANK ANIMATION

Sign into a valid account
Access Light theme
Follow the enable payments flow and note the "Loading" transition page animation has a transparent BG ✅
Access Dark theme
Follow the enable payments flow and note the "Loading" transition page animation has a transparent BG ✅

ACCESS FIREWORKS ANIMATION

Sign into a valid account
Tap Settings > Security > Two-factor authentication
Set up Two-factor authentication
Toggle Light/Dark Theme and note that the animation has a transparent background ✅

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2023-12-15T19:04:02Z

@shawnborton @rushatgabhane One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

rushatgabhane · 2023-12-16T03:20:33Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2023-12-16T03:31:29Z

@nkuoch Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

OSBotify · 2023-12-17T14:19:46Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

shawnborton · 2023-12-18T13:24:33Z

Ack - I didn't get a chance to review this before we merged! The new animations look good but they also look way too large compared to what we previously had. Can you show a side-by-side of what size we had previously and what this new size looks like?

OSBotify · 2023-12-19T02:45:12Z

🚀 Deployed to staging by https://github.com/nkuoch in version: 1.4.14-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-12-19T03:48:33Z

🚀 Deployed to staging by https://github.com/nkuoch in version: 1.4.14-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

mvtglobally · 2023-12-19T05:29:52Z

@grgia @rushatgabhane Do we need to QA this one? Can you pls help with Staging QA steps if yes

rushatgabhane · 2023-12-19T07:02:54Z

@mvtglobally yes, you can follow the steps under QA Tests section of this PR

shawnborton · 2023-12-19T13:52:31Z

@grgia can you follow up and make a quick adjustment to the animation size? Thanks!

OSBotify · 2023-12-21T05:16:08Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.4.14-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

JmillsExpensify · 2023-12-28T22:12:35Z

@nkuoch Can I get a payment summary for this issue? @rushatgabhane is requesting payment.

peterdbarkerUK · 2023-12-29T15:35:08Z

I think Rushat should be eligible for standard review payment here, $500 - but will defer to @grgia @nkuoch

JmillsExpensify · 2024-01-02T15:29:08Z

$500 payment approved for @rushatgabhane based on the comment (and emoji reaction) above.

Use transparent lottie animations

8defc1d

grgia self-assigned this Dec 15, 2023

grgia requested a review from a team as a code owner December 15, 2023 19:03

melvin-bot bot requested review from rushatgabhane and shawnborton and removed request for a team December 15, 2023 19:04

rushatgabhane approved these changes Dec 16, 2023

View reviewed changes

melvin-bot bot requested a review from nkuoch December 16, 2023 03:31

nkuoch approved these changes Dec 17, 2023

View reviewed changes

nkuoch merged commit 990815f into main Dec 17, 2023
9 of 13 checks passed

nkuoch deleted the georgia-transparentLottie branch December 17, 2023 14:15

github-actions bot mentioned this pull request Dec 19, 2023

Deploy Checklist: New Expensify 2023-12-19 #33264

Closed

98 tasks

shawnborton mentioned this pull request Jan 24, 2024

[Wave 6] Bank Account Flow Refactor #34498

Merged

50 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use transparent lottie animations #33189

Use transparent lottie animations #33189

grgia commented Dec 15, 2023 •

edited

Loading

melvin-bot bot commented Dec 15, 2023

rushatgabhane commented Dec 16, 2023 •

edited

Loading

melvin-bot bot commented Dec 16, 2023

OSBotify commented Dec 17, 2023

shawnborton commented Dec 18, 2023

OSBotify commented Dec 19, 2023

OSBotify commented Dec 19, 2023

mvtglobally commented Dec 19, 2023

rushatgabhane commented Dec 19, 2023

shawnborton commented Dec 19, 2023

OSBotify commented Dec 21, 2023

JmillsExpensify commented Dec 28, 2023

peterdbarkerUK commented Dec 29, 2023

JmillsExpensify commented Jan 2, 2024

Use transparent lottie animations #33189

Use transparent lottie animations #33189

Conversation

grgia commented Dec 15, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 15, 2023

rushatgabhane commented Dec 16, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

melvin-bot bot commented Dec 16, 2023

OSBotify commented Dec 17, 2023

shawnborton commented Dec 18, 2023

OSBotify commented Dec 19, 2023

OSBotify commented Dec 19, 2023

mvtglobally commented Dec 19, 2023

rushatgabhane commented Dec 19, 2023

shawnborton commented Dec 19, 2023

OSBotify commented Dec 21, 2023

JmillsExpensify commented Dec 28, 2023

peterdbarkerUK commented Dec 29, 2023

JmillsExpensify commented Jan 2, 2024

grgia commented Dec 15, 2023 •

edited

Loading

rushatgabhane commented Dec 16, 2023 •

edited

Loading