[Wave 6] Bank Account Flow Refactor

[barttom]

Details

Fixed Issues

$ #22901
PROPOSAL: -

Tests

1. Go the the Worksp[ace settings: Click Left icon -> choose workspace -> click settings icon (right bottom corner) -> click 'Bank Account' option
2. Choose "Connect with plaid"
3. Go through the process:
   • Click "Log into your bank"
   • Plaid modal - Choose Wells Fargo (use Bank of America if Wells Fargo is not available)
   • Plaid modal - User Id: user_good
   • Plaid modal - Password: pass_good
   • Plaid modal - Submit
   • Plaid modal - If they request a verification code via mobile sms, enter: credential_good when required
   • Choose the Saving account: Plaid Saving11122XXXXXX111
   • Save & Continue
4. Confirm and go to the Personal info steps with dataset (all fields are required):
   • First name: Alberta
   • Second name: Charleson
   • Birth date: 2000-08-08
   • last 4 SSN: 3333
   • Enter a faux US address
   • Confirm (Note: You will receive an error asking to "Please verify you name and date of birth". Hit "Save & Continue" again without changing any inputs.)
5. Go through steps for Business info with attached data, (all fields are required) :
   • Legal Business Name: Alberta Bobbeth Charleson
   • Tax ID number: 123456789
   • Company website: Enter any valid formatted website
   • Enter a faux phone number
   • Enter a faux US address
   • Select your company’s type
   • Select your company’s incorporation date
   • Select incorporation state
   • CHeck I confirm that this company is not on the list of restricted businesses.
   • Click Confirm button
6. Go through Beneficial owner steps
   • Select Yes/No if You own of 25% or more of company.
   • Test two scenarios separately:
     • Check 'Yes' in `Do any individuals own 25% or more of [company]?' step
       • Go through the process adding new owner, similar to the personal info. you cane use faux data and click Confirm button to go to the next step
       • You will be moved to the Do any individuals own 25% or more of [company]? step. You can add up to 3 owners by answering 'Yes' in this step (or 4 if You choose No in Do you own 25% or more of step)
       • Go to the summary step and review data
     • Check 'No' in `Do any individuals own 25% or more of [company]?' step
       • Go to the summary step and review data
7. Check all checkboxes (all are required) in Complete verification step and click 'Saver & Continue' button
8. Follow additional actions if needed

Important notes:

• The user should be able to stop the process by clicking 'x' button in the header and should be able to back to the abandoned step
• The user should be able to back to the previous step by clicking '<' button in the header.
• The user should be able to update data in the confirmation steps.
• Verify that no errors appear in the JS console

Offline tests

QA Steps

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

new_vbba_android.mp4

Android: mWeb Chrome

new_vbba_web_android.mp4

iOS: Native

new_vbba_ios.mp4

iOS: mWeb Safari

new_vbba_web_ios.mp4

MacOS: Chrome / Safari

new_vbba_web.mp4

MacOS: Desktop

new_vbba_desktop.mp4

[akinwale]

LGTM.

[shubham1206agra]

@mountiny

[pecanoro]

I didn't get to review everything, only half for now. Sorry for being a pain in the ass about the docs, but it's part of the style guide: https://github.com/Expensify/Style-Guides/blob/main/javascript.md#jsdocs

[barttom]

@pecanoro Why do we need js docs in Typescript files?

[barttom]

@pecanoro this PR addressed Your comments barttom#23
I've sent You an invitation if You want to add comments there.

[mountiny]

Thanks for addressing those comments, chatted with Rocio and we can go ahead if this was addressed soon enough. Already got C+ approvals and approvals from @nkuoch @MariaHCD and me so going to merge this

Addressed in 8e4a414

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.41-12 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[ikevin127]

We had some styling issues related to the padding on most pages coming from submitButtonStyles which led to this issue:

• [HOLD for Payment 2024-09-06][$250] Add bank account flow has too much padding below bottom button #47569

To fix this we had to remove the extra padding-bottom from all the pages where the issue was present. Find more details in the attached issue / proposal.