Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD App#35519] [$500] [LOW] Android - App crashes after personal info page #36453

Closed
1 of 6 tasks
kavimuru opened this issue Feb 14, 2024 · 22 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2

Comments

@kavimuru
Copy link

kavimuru commented Feb 14, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.41-2
Reproducible in staging?: y
Reproducible in production?: n (new flow)
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

  1. Open app
  2. Select a workspace
  3. Go to settings
  4. Tap Bank account
  5. Select "Connect manually"
  6. Fill in random data for the personal info screens
  7. Tap confirm on the personal info confirmation page

Expected Result:

Onfido loads

Actual Result:

App crashes

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

az_recorder_20240213_182223.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~018d63458c77f02719
  • Upwork Job ID: 1757570563966742528
  • Last Price Increase: 2024-02-14
  • Automatic offers:
    • akinwale | Contributor | 0
@kavimuru kavimuru added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor labels Feb 14, 2024
@melvin-bot melvin-bot bot changed the title Android - App crashes after personal info page [$500] Android - App crashes after personal info page Feb 14, 2024
Copy link

melvin-bot bot commented Feb 14, 2024

Job added to Upwork: https://www.upwork.com/jobs/~018d63458c77f02719

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 14, 2024
Copy link

melvin-bot bot commented Feb 14, 2024

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Copy link

melvin-bot bot commented Feb 14, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Feb 14, 2024

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@marcaaron
Copy link
Contributor

cc @barttom

@marcaaron
Copy link
Contributor

related to #34498

@mountiny
Copy link
Contributor

@akinwale @shubham1206agra @MrMuzyk This one seems to crash when loading onfido

@ntdiary
Copy link
Contributor

ntdiary commented Feb 14, 2024

@garrettmknight, @mountiny, I'm still unavailable, please feel free to reassign another c+ if needed. :)

@mountiny mountiny assigned akinwale and unassigned ntdiary Feb 14, 2024
@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 14, 2024
Copy link

melvin-bot bot commented Feb 14, 2024

📣 @akinwale 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@mountiny mountiny added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 14, 2024
@mountiny
Copy link
Contributor

@jeremy-croff
Copy link
Contributor

Took me a good while to build android. But unable to reproduce - is this because of the whitelisted account used again?
Screenshot 2024-02-13 at 7 48 00 PM

@shubham1206agra
Copy link
Contributor

@kavimuru Can you confirm the flow with a previous build?

@akinwale
Copy link
Contributor

This may be device-specific as I am unable to reproduce this.

@MrMuzyk
Copy link
Contributor

MrMuzyk commented Feb 14, 2024

Screen.Recording.2024-02-14.at.10.54.08.mov

Im also unable to reproduce that. Tested on Pixel 6 emulator

@mountiny mountiny removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Feb 14, 2024
@mountiny
Copy link
Contributor

Thanks removing the blocker label as this seems very narrow case. Will keep monitoring for more cases though

@mountiny mountiny added the Weekly KSv2 label Feb 14, 2024
@garrettmknight garrettmknight added Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Feb 14, 2024
Copy link

melvin-bot bot commented Feb 14, 2024

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Feb 14, 2024
@garrettmknight
Copy link
Contributor

@sakluger just reassigning in case this needs help while I'm OOO this week - will be back 2/21 to pick it back up

@mkhutornyi
Copy link
Contributor

This is dupe of #35519
Crash happens only on release build, which came from enabling proguard

@mountiny mountiny changed the title [$500] Android - App crashes after personal info page [HOLD App#35519] [$500] Android - App crashes after personal info page Feb 15, 2024
@greg-schroeder greg-schroeder changed the title [HOLD App#35519] [$500] Android - App crashes after personal info page [HOLD App#35519] [$500] [LOW] Android - App crashes after personal info page Feb 15, 2024
@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Feb 23, 2024
@sakluger
Copy link
Contributor

Still on hold for #35519.

@mkhutornyi
Copy link
Contributor

PR was merged so we can retest once it hit staging next week.

@melvin-bot melvin-bot bot added the Overdue label Mar 4, 2024
@garrettmknight
Copy link
Contributor

Good call @mkhutornyi - closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2
Projects
No open projects
Development

No branches or pull requests