Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Bank account - Error flickers when trying to add bank account after deleting previous one #37271

Closed
2 of 6 tasks
izarutskaya opened this issue Feb 27, 2024 · 25 comments
Closed
2 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review Weekly KSv2

Comments

@izarutskaya
Copy link

izarutskaya commented Feb 27, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.44-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+vd_web022624@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal Team

Action Performed:

Pre-requisite: the user must be logged in and have created a workspace.

  1. Go to Workspace > Bank account.
  2. Using Connect online with Plaid, select Chase and complete the add BA flow.
  3. After BA has been added, disconnect the BA.
  4. Again, using Connect online with Plaid, select Regions and try to add the BA.
  5. On the account confirmation screen, click on "Confirm" button.
  6. Verify an error flickers and the user can not proceed with the flow.
  7. Exit the add BA modal.
  8. Go to Workspace > Bank account.
  9. Verify the new BA appears as connected.

Expected Result:

There should be any issue on the flow when trying to add the new BA.

Actual Result:

When trying to confirm the bank account, an error flickers and the user is not able to proceed with the flow. Also, if the user returns to the add BA modal, the new account seems to be connected.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6393621_1709011624372.bandicam_2024-02-26_20-58-47-575.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01bcfec6134c6b50b2
  • Upwork Job ID: 1762427912527470592
  • Last Price Increase: 2024-02-27
@izarutskaya izarutskaya added DeployBlockerCash This issue or pull request should block deployment External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Feb 27, 2024
@melvin-bot melvin-bot bot changed the title Bank account - Error flickers when trying to add bank account after deleting previous one [$500] Bank account - Error flickers when trying to add bank account after deleting previous one Feb 27, 2024
Copy link

melvin-bot bot commented Feb 27, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01bcfec6134c6b50b2

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 27, 2024
Copy link

melvin-bot bot commented Feb 27, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

Copy link

melvin-bot bot commented Feb 27, 2024

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Feb 27, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Feb 27, 2024

Triggered auto assignment to @danieldoglas (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@danieldoglas
Copy link
Contributor

hm, that's very strange.

Also, in the first flow, you connected through plaid but you had to fill everything again.

@danieldoglas
Copy link
Contributor

We just reviewed the bank account flow recently on #34498

@danieldoglas
Copy link
Contributor

@nkuoch can you please check this video and confirm if the flow the video is showing is correct?

@danieldoglas
Copy link
Contributor

danieldoglas commented Feb 27, 2024

Also @izarutskaya can you please confirm and post a video of this not happening in production?

Copy link

melvin-bot bot commented Feb 27, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@danieldoglas
Copy link
Contributor

I wonder if the whole flow is failing because of the issue with the Radiobutton described on #37290

@brunovjk
Copy link
Contributor

@danieldoglas I tested ZhenjaHorbach's proposal, and the issue with RadioButtons disappears when we "modify the useEffect to only set a new value if it exists." However, the issue with the "add bank account flow" persists.

Please review the response when calling `ConnectBankAccountWithPlaid` in step 5:

image

Is there a missing _ separating reimbursementAccount from the id?

Continuing to press Confirm results in the observed issue:

Consecutive responses to `ConnectBankAccountWithPlaid` call in step 5:

image

I will further investigate. Additionally, along with the mentioned issue, I suspect it could be related to how we manage/clean Onyx. If, for some reason, BA registration is unsuccessful and there's an opportunity to redo it, calling RestartBankAccountSetup also exhibits the same issue.

@danieldoglas
Copy link
Contributor

Is there a missing _ separating reimbursementAccount from the id?

I think we should have added, but looking into the backend and the app code, it was prepared to not have the _ so we should be all good here.

Can you also send me the requestIDs for those responses? That way I can check the logs on my side.

@brunovjk
Copy link
Contributor

brunovjk commented Feb 27, 2024

I think we should have added, but looking into the backend and the app code, it was prepared to not have the _ so we should be all good here.

humm ... I see

Can you also send me the requestIDs

Like this?

First/Successful `ConnectBankAccountWithPlaid` response:
{
    "onyxData": [
        {
            "onyxMethod": "merge",
            "key": "reimbursementAccount",
            "value": {
                "achData": {
                    "routingNumber": "011401533",
                    "accountNumber": "XXXXXXXXXXXX1111",
                    "addressName": "XXXXXXXXXXXX1111",
                    "isSavings": true,
                    "bankAccountID": 3953947,
                    "created": "2024-02-27 23:51:20",
                    "state": "SETUP",
                    "bankName": "Regions Bank",
                    "country": "US",
                    "currency": "USD",
                    "enableCardAfterVerified": true,
                    "fieldsType": "local",
                    "hasFullSSN": false,
                    "mask": "1111",
                    "plaidAccountID": "oVG1eVgQgLfa5ZbGavVRiMm8qwEJk6foLDkdr",
                    "policyID": "C2D04064D2525A53",
                    "setupType": "plaid",
                    "verifications": [],
                    "currentStep": "RequestorStep"
                },
                "errors": null
            }
        },
        {
            "onyxMethod": "merge",
            "key": "reimbursementAccountC2D04064D2525A53",
            "value": {
                "achData": {
                    "routingNumber": "011401533",
                    "accountNumber": "XXXXXXXXXXXX1111",
                    "addressName": "XXXXXXXXXXXX1111",
                    "isSavings": true,
                    "bankAccountID": 3953947,
                    "created": "2024-02-27 23:51:20",
                    "state": "SETUP",
                    "bankName": "Regions Bank",
                    "country": "US",
                    "currency": "USD",
                    "enableCardAfterVerified": true,
                    "fieldsType": "local",
                    "hasFullSSN": false,
                    "mask": "1111",
                    "plaidAccountID": "oVG1eVgQgLfa5ZbGavVRiMm8qwEJk6foLDkdr",
                    "policyID": "C2D04064D2525A53",
                    "setupType": "plaid",
                    "verifications": [],
                    "currentStep": "RequestorStep"
                },
                "errors": null
            }
        },
        {
            "onyxMethod": "set",
            "key": "onfidoToken",
            "value": ""
        },
        {
            "key": "reimbursementAccount",
            "onyxMethod": "merge",
            "value": {
                "achData": {
                    "accountNumber": "XXXXXXXXXXXX1111",
                    "addressName": "XXXXXXXXXXXX1111",
                    "bankAccountID": 3953947,
                    "bankName": "Regions Bank",
                    "country": "US",
                    "created": "2024-02-27 23:51:20",
                    "currency": "USD",
                    "enableCardAfterVerified": true,
                    "fieldsType": "local",
                    "hasFullSSN": false,
                    "isSavings": true,
                    "mask": "1111",
                    "plaidAccountID": "oVG1eVgQgLfa5ZbGavVRiMm8qwEJk6foLDkdr",
                    "policyID": "C2D04064D2525A53",
                    "routingNumber": "011401533",
                    "setupType": "plaid",
                    "state": "SETUP",
                    "verifications": []
                }
            }
        },
        {
            "key": "reimbursementAccountC2D04064D2525A53",
            "onyxMethod": "merge",
            "value": {
                "achData": {
                    "accountNumber": "XXXXXXXXXXXX1111",
                    "addressName": "XXXXXXXXXXXX1111",
                    "bankAccountID": 3953947,
                    "bankName": "Regions Bank",
                    "country": "US",
                    "created": "2024-02-27 23:51:20",
                    "currency": "USD",
                    "enableCardAfterVerified": true,
                    "fieldsType": "local",
                    "hasFullSSN": false,
                    "isSavings": true,
                    "mask": "1111",
                    "plaidAccountID": "oVG1eVgQgLfa5ZbGavVRiMm8qwEJk6foLDkdr",
                    "policyID": "C2D04064D2525A53",
                    "routingNumber": "011401533",
                    "setupType": "plaid",
                    "state": "SETUP",
                    "verifications": []
                }
            }
        }
    ],
    "jsonCode": 200,
    "requestID": "85c455d219243553-CNF",
    "previousUpdateID": 138593653,
    "lastUpdateID": 138757556
}
`RestartBankAccountSetup`
{
    "jsonCode": 200,
    "requestID": "85c47d65f8a83559-CNF",
    "onyxData": [
        {
            "key": "report_8080116427258102",
            "onyxMethod": "merge",
            "value": {
                "lastReadTime": "2024-02-28 00:18:22.037"
            }
        },
        {
            "key": "report_8080116427258102",
            "onyxMethod": "merge",
            "value": {
                "lastActorAccountID": 16460731,
                "lastMentionedTime": null,
                "lastMessageText": "updated the default business bank account to \"None\"",
                "lastReadTime": "2024-02-28 00:18:22.037",
                "lastVisibleActionCreated": "2024-02-28 00:18:22.037",
                "maxSequenceNumber": null,
                "reportID": "8080116427258102"
            }
        },
        {
            "key": "reportActions_8080116427258102",
            "onyxMethod": "merge",
            "shouldNotify": true,
            "value": {
                "1265675800217017416": {
                    "actionName": "POLICYCHANGELOG_UPDATE_ACH_ACCOUNT",
                    "actorAccountID": 16460731,
                    "automatic": false,
                    "avatar": "https:\/\/d2k5nsl2zxldvw.cloudfront.net\/images\/avatars\/default-avatar_20.png",
                    "created": "2024-02-28 00:18:22.037",
                    "isAttachment": false,
                    "lastModified": "2024-02-28 00:18:22.037",
                    "message": [
                        {
                            "html": "updated the default business bank account to \"None\"",
                            "isDeletedParentAction": false,
                            "isEdited": false,
                            "reactions": [],
                            "text": "updated the default business bank account to \"None\"",
                            "type": "COMMENT",
                            "whisperedTo": []
                        }
                    ],
                    "originalMessage": {
                        "bankAccountName": "",
                        "lastModified": "2024-02-28 00:18:22.037",
                        "maskedBankAccountNumber": ""
                    },
                    "person": [
                        {
                            "style": "strong",
                            "text": "Bruno Rocha",
                            "type": "TEXT"
                        }
                    ],
                    "previousReportActionID": "3512067784918861444",
                    "reportActionID": "1265675800217017416",
                    "reportActionTimestamp": 1709079502037,
                    "sequenceNumber": null,
                    "shouldShow": true,
                    "timestamp": 1709079502,
                    "whisperedToAccountIDs": []
                }
            }
        }
    ],
    "previousUpdateID": 138790143,
    "lastUpdateID": 138790448
}
First after restart `ConnectBankAccountWithPlaid` response:
{
    "onyxData": [
        {
            "onyxMethod": "merge",
            "key": "reimbursementAccount",
            "value": {
                "achData": {
                    "routingNumber": "011401533",
                    "accountNumber": "XXXXXXXXXXXX1111",
                    "addressName": "Alberta Bobbeth Charleson",
                    "isSavings": true,
                    "bankAccountID": 3953947,
                    "created": "2024-02-27 23:51:20",
                    "state": "VERIFYING",
                    "acceptTerms": true,
                    "addressCity": "Anchorage",
                    "addressState": "AK",
                    "addressStreet": "123 Place Street",
                    "addressZipCode": "99504",
                    "bankName": "Regions Bank",
                    "beneficialOwners": [],
                    "certifyTrueInformation": true,
                    "companyName": "Alberta Bobbeth Charleson",
                    "companyPhone": "4404521379",
                    "companyTaxID": "123456789",
                    "country": "US",
                    "currency": "USD",
                    "dateSigned": "2024-02-28 00:17:55",
                    "dob": "2006-02-02",
                    "enableCardAfterVerified": true,
                    "fieldsType": "local",
                    "firstName": "Alberta",
                    "hasFullSSN": true,
                    "hasNoConnectionToCannabis": true,
                    "incorporationDate": "2024-02-01",
                    "incorporationState": "AK",
                    "incorporationType": "LLC",
                    "industryCode": "623110",
                    "isAuthorizedToUseBankAccount": true,
                    "isControllingOfficer": false,
                    "isOnfidoSetupComplete": true,
                    "lastName": "Charleson",
                    "lastUpdate": "2024-02-28 00:18:22",
                    "mask": "1111",
                    "ownsMoreThan25Percent": false,
                    "plaidAccountID": "zPRaBWlPPRtk77rEBnqVtPmAzDGaLBtlNEVE7",
                    "previousState": 2,
                    "requestorAddressCity": "Anchorage",
                    "requestorAddressState": "AK",
                    "requestorAddressStreet": "123 Place Street",
                    "requestorAddressZipCode": "99504",
                    "setupType": "plaid",
                    "ssnLast4": "3333",
                    "verifications": {
                        "blackListed": {
                            "isBankAccountCopy": false,
                            "isBlackListedAddress": false,
                            "isBlackListedName": false,
                            "isBlackListedUser": false,
                            "isFlagged": false
                        }
                    },
                    "website": "https:\/\/g.com",
                    "currentStep": "RequestorStep"
                },
                "errors": null
            }
        },
        {
            "onyxMethod": "merge",
            "key": "reimbursementAccountC2D04064D2525A53",
            "value": {
                "achData": {
                    "routingNumber": "011401533",
                    "accountNumber": "XXXXXXXXXXXX1111",
                    "addressName": "Alberta Bobbeth Charleson",
                    "isSavings": true,
                    "bankAccountID": 3953947,
                    "created": "2024-02-27 23:51:20",
                    "state": "VERIFYING",
                    "acceptTerms": true,
                    "addressCity": "Anchorage",
                    "addressState": "AK",
                    "addressStreet": "123 Place Street",
                    "addressZipCode": "99504",
                    "bankName": "Regions Bank",
                    "beneficialOwners": [],
                    "certifyTrueInformation": true,
                    "companyName": "Alberta Bobbeth Charleson",
                    "companyPhone": "4404521379",
                    "companyTaxID": "123456789",
                    "country": "US",
                    "currency": "USD",
                    "dateSigned": "2024-02-28 00:17:55",
                    "dob": "2006-02-02",
                    "enableCardAfterVerified": true,
                    "fieldsType": "local",
                    "firstName": "Alberta",
                    "hasFullSSN": true,
                    "hasNoConnectionToCannabis": true,
                    "incorporationDate": "2024-02-01",
                    "incorporationState": "AK",
                    "incorporationType": "LLC",
                    "industryCode": "623110",
                    "isAuthorizedToUseBankAccount": true,
                    "isControllingOfficer": false,
                    "isOnfidoSetupComplete": true,
                    "lastName": "Charleson",
                    "lastUpdate": "2024-02-28 00:18:22",
                    "mask": "1111",
                    "ownsMoreThan25Percent": false,
                    "plaidAccountID": "zPRaBWlPPRtk77rEBnqVtPmAzDGaLBtlNEVE7",
                    "previousState": 2,
                    "requestorAddressCity": "Anchorage",
                    "requestorAddressState": "AK",
                    "requestorAddressStreet": "123 Place Street",
                    "requestorAddressZipCode": "99504",
                    "setupType": "plaid",
                    "ssnLast4": "3333",
                    "verifications": {
                        "blackListed": {
                            "isBankAccountCopy": false,
                            "isBlackListedAddress": false,
                            "isBlackListedName": false,
                            "isBlackListedUser": false,
                            "isFlagged": false
                        }
                    },
                    "website": "https:\/\/g.com",
                    "currentStep": "RequestorStep"
                },
                "errors": null
            }
        },
        {
            "onyxMethod": "set",
            "key": "onfidoToken",
            "value": ""
        },
        {
            "key": "reimbursementAccount",
            "onyxMethod": "set",
            "value": {
                "acceptTerms": true,
                "accountNumber": "XXXXXXXXXXXX1111",
                "addressCity": "Anchorage",
                "addressName": "Alberta Bobbeth Charleson",
                "addressState": "AK",
                "addressStreet": "123 Place Street",
                "addressZipCode": "99504",
                "bankAccountID": 3953947,
                "bankName": "Regions Bank",
                "beneficialOwners": [],
                "certifyTrueInformation": true,
                "companyName": "Alberta Bobbeth Charleson",
                "companyPhone": "4404521379",
                "companyTaxID": "123456789",
                "country": "US",
                "created": "2024-02-27 23:51:20",
                "currency": "USD",
                "currentStep": "RequestorStep",
                "dateSigned": "2024-02-28 00:17:55",
                "dob": "2006-02-02",
                "enableCardAfterVerified": true,
                "fieldsType": "local",
                "firstName": "Alberta",
                "hasFullSSN": true,
                "hasNoConnectionToCannabis": true,
                "incorporationDate": "2024-02-01",
                "incorporationState": "AK",
                "incorporationType": "LLC",
                "industryCode": "623110",
                "isAuthorizedToUseBankAccount": true,
                "isControllingOfficer": false,
                "isOnfidoSetupComplete": true,
                "isSavings": true,
                "lastName": "Charleson",
                "lastUpdate": "2024-02-28 00:18:22",
                "mask": "1111",
                "ownsMoreThan25Percent": false,
                "plaidAccountID": "vNKzgbgrPdF3Llx1D6NkFz4g5LplQJCqDgvRG",
                "policyID": "C2D04064D2525A53",
                "previousState": 2,
                "requestorAddressCity": "Anchorage",
                "requestorAddressState": "AK",
                "requestorAddressStreet": "123 Place Street",
                "requestorAddressZipCode": "99504",
                "routingNumber": "011401533",
                "setupType": "plaid",
                "ssnLast4": "3333",
                "state": "VERIFYING",
                "verifications": {
                    "blackListed": {
                        "isBankAccountCopy": false,
                        "isBlackListedAddress": false,
                        "isBlackListedName": false,
                        "isBlackListedUser": false,
                        "isFlagged": false
                    }
                },
                "website": "https:\/\/g.com"
            }
        },
        {
            "key": "reimbursementAccountC2D04064D2525A53",
            "onyxMethod": "set",
            "value": {
                "acceptTerms": true,
                "accountNumber": "XXXXXXXXXXXX1111",
                "addressCity": "Anchorage",
                "addressName": "Alberta Bobbeth Charleson",
                "addressState": "AK",
                "addressStreet": "123 Place Street",
                "addressZipCode": "99504",
                "bankAccountID": 3953947,
                "bankName": "Regions Bank",
                "beneficialOwners": [],
                "certifyTrueInformation": true,
                "companyName": "Alberta Bobbeth Charleson",
                "companyPhone": "4404521379",
                "companyTaxID": "123456789",
                "country": "US",
                "created": "2024-02-27 23:51:20",
                "currency": "USD",
                "currentStep": "RequestorStep",
                "dateSigned": "2024-02-28 00:17:55",
                "dob": "2006-02-02",
                "enableCardAfterVerified": true,
                "fieldsType": "local",
                "firstName": "Alberta",
                "hasFullSSN": true,
                "hasNoConnectionToCannabis": true,
                "incorporationDate": "2024-02-01",
                "incorporationState": "AK",
                "incorporationType": "LLC",
                "industryCode": "623110",
                "isAuthorizedToUseBankAccount": true,
                "isControllingOfficer": false,
                "isOnfidoSetupComplete": true,
                "isSavings": true,
                "lastName": "Charleson",
                "lastUpdate": "2024-02-28 00:18:22",
                "mask": "1111",
                "ownsMoreThan25Percent": false,
                "plaidAccountID": "vNKzgbgrPdF3Llx1D6NkFz4g5LplQJCqDgvRG",
                "policyID": "C2D04064D2525A53",
                "previousState": 2,
                "requestorAddressCity": "Anchorage",
                "requestorAddressState": "AK",
                "requestorAddressStreet": "123 Place Street",
                "requestorAddressZipCode": "99504",
                "routingNumber": "011401533",
                "setupType": "plaid",
                "ssnLast4": "3333",
                "state": "VERIFYING",
                "verifications": {
                    "blackListed": {
                        "isBankAccountCopy": false,
                        "isBlackListedAddress": false,
                        "isBlackListedName": false,
                        "isBlackListedUser": false,
                        "isFlagged": false
                    }
                },
                "website": "https:\/\/g.com"
            }
        },
        {
            "key": "reimbursementAccountDraft",
            "onyxMethod": "set",
            "value": null
        },
        {
            "key": "reimbursementAccountC2D04064D2525A53Draft",
            "onyxMethod": "set",
            "value": null
        },
        {
            "key": "onfidoApplicantID",
            "onyxMethod": "set",
            "value": null
        },
        {
            "key": "onfidoToken",
            "onyxMethod": "set",
            "value": null
        },
        {
            "key": "plaidData",
            "onyxMethod": "set",
            "value": null
        },
        {
            "key": "plaidLinkToken",
            "onyxMethod": "set",
            "value": null
        },
        {
            "key": "reimbursementAccount",
            "onyxMethod": "merge",
            "value": {
                "achData": {
                    "acceptTerms": true,
                    "accountNumber": "XXXXXXXXXXXX1111",
                    "addressCity": "Anchorage",
                    "addressName": "Alberta Bobbeth Charleson",
                    "addressState": "AK",
                    "addressStreet": "123 Place Street",
                    "addressZipCode": "99504",
                    "bankAccountID": 3953947,
                    "bankName": "Regions Bank",
                    "beneficialOwners": [],
                    "certifyTrueInformation": true,
                    "companyName": "Alberta Bobbeth Charleson",
                    "companyPhone": "4404521379",
                    "companyTaxID": "123456789",
                    "country": "US",
                    "created": "2024-02-27 23:51:20",
                    "currency": "USD",
                    "dateSigned": "2024-02-28 00:17:55",
                    "dob": "2006-02-02",
                    "enableCardAfterVerified": true,
                    "fieldsType": "local",
                    "firstName": "Alberta",
                    "hasFullSSN": true,
                    "hasNoConnectionToCannabis": true,
                    "incorporationDate": "2024-02-01",
                    "incorporationState": "AK",
                    "incorporationType": "LLC",
                    "industryCode": "623110",
                    "isAuthorizedToUseBankAccount": true,
                    "isControllingOfficer": false,
                    "isOnfidoSetupComplete": true,
                    "isSavings": true,
                    "lastName": "Charleson",
                    "lastUpdate": "2024-02-28 00:18:22",
                    "mask": "1111",
                    "ownsMoreThan25Percent": false,
                    "plaidAccountID": "zPRaBWlPPRtk77rEBnqVtPmAzDGaLBtlNEVE7",
                    "previousState": 2,
                    "requestorAddressCity": "Anchorage",
                    "requestorAddressState": "AK",
                    "requestorAddressStreet": "123 Place Street",
                    "requestorAddressZipCode": "99504",
                    "routingNumber": "011401533",
                    "setupType": "plaid",
                    "ssnLast4": "3333",
                    "state": "VERIFYING",
                    "verifications": {
                        "blackListed": {
                            "isBankAccountCopy": false,
                            "isBlackListedAddress": false,
                            "isBlackListedName": false,
                            "isBlackListedUser": false,
                            "isFlagged": false
                        }
                    },
                    "website": "https:\/\/g.com"
                }
            }
        },
        {
            "key": "reimbursementAccountC2D04064D2525A53",
            "onyxMethod": "merge",
            "value": {
                "achData": {
                    "acceptTerms": true,
                    "accountNumber": "XXXXXXXXXXXX1111",
                    "addressCity": "Anchorage",
                    "addressName": "Alberta Bobbeth Charleson",
                    "addressState": "AK",
                    "addressStreet": "123 Place Street",
                    "addressZipCode": "99504",
                    "bankAccountID": 3953947,
                    "bankName": "Regions Bank",
                    "beneficialOwners": [],
                    "certifyTrueInformation": true,
                    "companyName": "Alberta Bobbeth Charleson",
                    "companyPhone": "4404521379",
                    "companyTaxID": "123456789",
                    "country": "US",
                    "created": "2024-02-27 23:51:20",
                    "currency": "USD",
                    "dateSigned": "2024-02-28 00:17:55",
                    "dob": "2006-02-02",
                    "enableCardAfterVerified": true,
                    "fieldsType": "local",
                    "firstName": "Alberta",
                    "hasFullSSN": true,
                    "hasNoConnectionToCannabis": true,
                    "incorporationDate": "2024-02-01",
                    "incorporationState": "AK",
                    "incorporationType": "LLC",
                    "industryCode": "623110",
                    "isAuthorizedToUseBankAccount": true,
                    "isControllingOfficer": false,
                    "isOnfidoSetupComplete": true,
                    "isSavings": true,
                    "lastName": "Charleson",
                    "lastUpdate": "2024-02-28 00:18:22",
                    "mask": "1111",
                    "ownsMoreThan25Percent": false,
                    "plaidAccountID": "zPRaBWlPPRtk77rEBnqVtPmAzDGaLBtlNEVE7",
                    "previousState": 2,
                    "requestorAddressCity": "Anchorage",
                    "requestorAddressState": "AK",
                    "requestorAddressStreet": "123 Place Street",
                    "requestorAddressZipCode": "99504",
                    "routingNumber": "011401533",
                    "setupType": "plaid",
                    "ssnLast4": "3333",
                    "state": "VERIFYING",
                    "verifications": {
                        "blackListed": {
                            "isBankAccountCopy": false,
                            "isBlackListedAddress": false,
                            "isBlackListedName": false,
                            "isBlackListedUser": false,
                            "isFlagged": false
                        }
                    },
                    "website": "https:\/\/g.com"
                }
            }
        }
    ],
    "jsonCode": 200,
    "requestID": "85c480f6380c3553-CNF",
    "previousUpdateID": 138790448,
    "lastUpdateID": 138793030
}
Sequential/Failure`ConnectBankAccountWithPlaid` response:
{
    "code": 666,
    "jsonCode": 666,
    "type": "Expensify\\Libs\\Error\\ExpError",
    "UUID": "fc38abb3-e3d1-4abd-b6fd-4e05be7a751b",
    "message": "An unexpected error occurred while trying to add your bank account via Plaid.",
    "title": "",
    "data": {
        "onyxData": [
            {
                "onyxMethod": "merge",
                "key": "reimbursementAccountC2D04064D2525A53",
                "value": {
                    "errors": {
                        "1709079671718244": "An unexpected error occurred while trying to add your bank account via Plaid."
                    }
                }
            },
            {
                "onyxMethod": "merge",
                "key": "reimbursementAccount",
                "value": {
                    "errors": {
                        "1709079671718251": "An unexpected error occurred while trying to add your bank account via Plaid."
                    }
                }
            }
        ]
    },
    "htmlMessage": "",
    "onyxData": [
        {
            "onyxMethod": "merge",
            "key": "reimbursementAccountC2D04064D2525A53",
            "value": {
                "errors": {
                    "1709079671718244": "An unexpected error occurred while trying to add your bank account via Plaid."
                }
            }
        },
        {
            "onyxMethod": "merge",
            "key": "reimbursementAccount",
            "value": {
                "errors": {
                    "1709079671718251": "An unexpected error occurred while trying to add your bank account via Plaid."
                }
            }
        }
    ],
    "requestID": "85c481893ed73553-CNF"
}

In the example above, I was unable to register the bank account successfully, instead I receive a message to confirm data in the chat. I click on 'reset registration', follow the flow again, and the reported issue appears.

@danieldoglas
Copy link
Contributor

@brunovjk I can see in the logs that the issue on the failure request is that plaidAccessToken is being sent as empty string when you resend the request. So probably we're erasing it in the frontend code - that should help you find out what's happening.

@puneetlath puneetlath added Daily KSv2 DeployBlockerCash This issue or pull request should block deployment and removed Hourly KSv2 labels Feb 28, 2024
@puneetlath
Copy link
Contributor

Whoops, sorry got my issues mixed up. I believe this is still a blocker.

@github-actions github-actions bot added Hourly KSv2 and removed Daily KSv2 labels Feb 28, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@puneetlath puneetlath added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Feb 28, 2024
@brunovjk
Copy link
Contributor

I reverted this PR and was unable to reproduce the issue. Can anyone confirm please? Thanks. I continue working on a solution, any help is welcome :D

@slafortune slafortune added the retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause label Feb 29, 2024
@slafortune
Copy link
Contributor

I've added the retest tag

@melvin-bot melvin-bot bot added the Overdue label Mar 4, 2024
@danieldoglas danieldoglas added Weekly KSv2 and removed Daily KSv2 labels Mar 4, 2024
@melvin-bot melvin-bot bot removed the Overdue label Mar 4, 2024
@mvtglobally
Copy link

Issue is reproducible during KI retests.

@mvtglobally mvtglobally removed the retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause label Mar 5, 2024
@nkuoch nkuoch self-assigned this Mar 5, 2024
@nkuoch
Copy link
Contributor

nkuoch commented Mar 5, 2024

Will take a look myself, to see if I see any BE or FE issue.

@nkuoch nkuoch added Internal Requires API changes or must be handled by Expensify staff and removed External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors labels Mar 5, 2024
Copy link

melvin-bot bot commented Mar 5, 2024

Current assignee @abdulrahuman5196 is eligible for the Internal assigner, not assigning anyone new.

@nkuoch
Copy link
Contributor

nkuoch commented Mar 5, 2024

This will be a BE PR, no need for contributor plus

@nkuoch nkuoch added the Reviewing Has a PR in review label Mar 5, 2024
@slafortune
Copy link
Contributor

@nkuoch no payment is due on this one, right? Can this be closed now?

@nkuoch nkuoch closed this as completed Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

8 participants