-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-02-05] [$500] IOU - Amount is not preserved in Manual page when the amount is changed in confirmation page #33125
Comments
Job added to Upwork: https://www.upwork.com/jobs/~0100d59ba09cfb0bc4 |
Triggered auto assignment to @garrettmknight ( |
Bug0 Triage Checklist (Main S/O)
|
Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.Amount is not preserved in Manual page when the amount is changed in confirmation page What is the root cause of that problem?This happens as on the App/src/pages/iou/steps/MoneyRequestAmountForm.js Lines 79 to 81 in 06662fa
When we navigate back to this page, the Video: This can be clearly seen when we log both variables7ea2240d-791e-4975-87b4-db5e678ac0a8.mp4What changes do you think we should make in order to solve the problem?We should add a useEffect that updates the current amount when useEffect(() => {
setCurrentAmount(selectedAmountAsString);
}, [selectedAmountAsString, setCurrentAmount]); Resultc5846578-4c56-468a-adcd-5fb359be318b.mp4 |
Can't reproduce on latest main branch. |
ProposalPlease re-state the problem that we are trying to solve in this issue.IOU - Amount is not preserved in Manual page when the amount is changed in confirmation page What is the root cause of that problem?We have logic of updating amount but only when tab is changed: App/src/pages/iou/steps/MoneyRequestAmountForm.js Lines 121 to 128 in 9d2ea87
What changes do you think we should make in order to solve the problem?add This also fixes #33123 which has the same root cause: App/src/pages/iou/request/IOURequestStartPage.js Lines 82 to 87 in 9d2ea87
But not updated because of useEffect without amount dependency
|
ProposalUpdated |
ProposalPlease re-state the problem that we are trying to solve in this issue.The new amount is not preserved in Manual page What is the root cause of that problem?We use It's just updated to App/src/pages/iou/steps/MoneyRequestAmountForm.js Lines 79 to 81 in 4592a7c
When users go to other pages, this component is still in the stack that why We have the logic to update What changes do you think we should make in order to solve the problem?We should create the useEffect to update
We need to use What alternative solutions did you explore? (Optional)NA |
ProposalPlease re-state the problem that we are trying to solve in this issue.The new amount is not preserved in Manual page What is the root cause of that problem?we didn't set What changes do you think we should make in order to solve the problem?
We need to replace selectedTab to amount to avoid several calculate.
What alternative solutions did you explore? (Optional) |
@garrettmknight, @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
@garrettmknight, @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick! |
reviewing proposals |
@situchan any proposals look good? |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
@garrettmknight, @situchan Huh... This is 4 days overdue. Who can take care of this? |
@situchan Can you review the proposals when you get a chance? |
Back from ooo. We can add amount back to the dependency array, but we should make sure that the amount is reset when we change tabs |
📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
📣 @mkhutornyi 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
@situchan can you give the PR a review when you get a chance? |
sorry not sure why this was not in my list. reviewing in an hour |
review complete |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.32-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-02-05. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Paid - dropping to weekly for @situchan to finish the checklist. |
|
Done |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.13.0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause- Internal Team
Slack conversation:
Action Performed:
Expected Result:
The new amount is preserved in Manual page
Actual Result:
The new amount is not preserved in Manual page
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6313586_1702585393338.20231214_195558.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: