-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hold for payment 2024-04-17] - Avatar placeholder remains in dark mode when app is in light mode #33161
Comments
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Triggered auto assignment to @puneetlath ( |
This isn't worth blocking the deploy, so I removed the label. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Triggered auto assignment to @dubielzyk-expensify ( |
This is just the image we use for the fallback avatar, so it's not technically a bug. @dubielzyk-expensify do you think we should use a theme-specific image here? |
Sure can. Do you have a link to the original so I can check the export settings? |
Nice! What color are you using for the fallback avatar BG color? We might want to use something like the icon color as the BG here so that we never have any worry about the icon getting lost in the LHN depending on active or hover states. Actually that being said, I think our border color (same BG as buttons) would be a good BG color as it won't collide with rowHover or the active/press state? |
Lovely! Let's do it then! |
|
On it! |
While we're at it, should we check on these colors as well? @dubielzyk-expensify @shawnborton @dannymcclain |
Some of these are definitely unused |
Any updates on this one? |
I think the next step is to continue with the draft PR. |
Yeah going to get this one updated this week as it relates to another bug |
Found a much easier way to do this, going to create a new PR |
PR out on staging |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
PR is on prod. Payment due on 2024-04-17 |
@s77rt do you think a regression test would be helpful here? |
It's unlikely that this bug would resurface again. Let's not add a specific test case here. The generic one should be enough https://expensify.testrail.io/index.php?/cases/view/2990277 |
This issue has not been updated in over 15 days. @s77rt, @grgia, @joekaufmanexpensify, @dubielzyk-expensify eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
Sounds good. TY! |
All set to issue payment here. Only payment is $250 to @s77rt via upwork for C+ review. (Would've normally been $500 based on when the issue was created, but this one had a regression). |
OG upwork job is closed, so I opened a new one. |
@s77rt offer sent for $250! |
@joekaufmanexpensify Accepted! Thanks! |
@s77rt $250 sent and contract ended! |
Upwork job closed. |
All set. Thanks everyone! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v1.4.13-4
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal team
Slack conversation:
Action Performed:
Precondition: App is in light mode.
Expected Result:
The avatar placeholder will be displayed in light mode.
Actual Result:
The avatar placeholder remains in dark mode.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6314487_1702642885688.Screen_Recording_20231215_031248_New_Expensify.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @grgiaThe text was updated successfully, but these errors were encountered: