[$500] iOS - Chat - The screen flashes when I tap on "Delete comment"

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.14.0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Navigate to https://staging.new.expensify.com/
2. Make a workspace
3. Go offline
4. Write any text in the #announce room
5. Delete any text

Expected Result:

There shouldn't be any flashing

Actual Result:

The screen flashes when I tap on "Delete comment". The keyboard appears for a very short time and disappears

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6320203_1703015335397.OTQS8996.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01766b41eca1f7098c
• Upwork Job ID: 1737217847599263744
• Last Price Increase: 2024-02-21

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01766b41eca1f7098c

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

iOS - Chat - The screen flashes when tapping on "Delete comment"

What is the root cause of that problem?

We refocus the Composer and open keyboard when Modals or Popovers are closed:

App/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.js

Lines 481 to 486 in 4b95010

	// We want to focus or refocus the input when a modal has been closed or the underlying screen is refocused.
	// We avoid doing this on native platforms since the software keyboard popping
	// open creates a jarring and broken UX.
	if (!((willBlurTextInputOnTapOutside || shouldAutoFocus) && !isNextModalWillOpenRef.current && !modal.isVisible && isFocused && (prevIsModalVisible || !prevIsFocused))) {
	return;
	}

But here a Popover closes and another Modal opens. This triggers a quick Keyboard focus-dismiss action.

The app currently still has the jarring experience on mweb as there the keyboard stills pops up a lot.

What changes do you think we should make in order to solve the problem?

The software keyboard popping up creates a jarring experience on mobile web also.

We should modify willBlurTextInputOnTapOutside to only be true when we don't have a touch screen (so no software keyboards)

willBlurTextInputOnTapOutside = !DeviceCapabilities.canUseTouchScreen()

This will keep it false for touch screen devices.

[mananjadhav]

I think this should probably get resolved with #32970

[CortneyOfstad]

Not overdue

[mananjadhav]

The linked PR didn't fix this and we're open for proposals here. I'll review the existing proposals by tomorrow.

[CortneyOfstad]

@mananjadhav any updates?

[mananjadhav]

Open for proposals.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[CortneyOfstad]

^^^ can ignore that as the linked PR was not successful.

Added help wanted to get some proposals rolling

[CortneyOfstad]

@lanitochka17 can we confirm the issue is still happening? I just want to double check since this issue has been open for a while 👍

[lanitochka17]

Issue is still reproducible on the latest build 1.4.38-0

MOYN7370.MP4

[CortneyOfstad]

Thank you @lanitochka17!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[CortneyOfstad]

This falls under VIP-VSB and still can see the flashing despite the latest app upgrade. So strange, so getting eyes on this!

[melvin-bot]

Current assignee @mananjadhav is eligible for the External assigner, not assigning anyone new.

[CortneyOfstad]

^^^ not sure what the heck happened, but I changed one tag and everything went insane 🙃

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[CortneyOfstad]

Reached out to Callstack here

[rezkiy37]

Hi, I’m Michael (Mykhailo) from Callstack and I would like to work on this issue.

[quinthar]

I'm not sure I understand the issue -- I watched the video, but can you clarify what you mean by "flash"? I don't see a problem.

[rezkiy37]

I agree with a comment above. I tried to reproduce the bug on a real IOS device, simulator and Android emulator. I haven't seen any flashes. I attach a couple videos.

Videos

IOS.mp4

IOS.Safari.mp4

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[CortneyOfstad]

Not able to recreate on my side either so going to close this 👍

Thanks for the additional testing @mvtglobally and @rezkiy37!