[HOLD for payment 2024-01-17] [$250] Action menu - Double-clicking the "Add Reaction" icon highlights the text of the message.

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.16-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Interna Team
Slack conversation:

Action Performed:

1. Open New Expensify app
2. Log in with any account
3. Navigate to any conversation with the correspondence history
4. Move the cursor over any text message
5. Double-click on the "Add Reaction" icon in the action menu

Expected Result:

Double-clicking the "Add Reaction" icon in the action menu should not cause the text in the message to be highlighted.

Actual Result:

Double-clicking the "Add reaction" icon in the Action menu highlights the text in the message.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6324861_1703334379791.Recording__982.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a6ecd7244e8df2c0
• Upwork Job ID: 1738559790251122688
• Last Price Increase: 2024-01-04
• Automatic offers:
• hoangzinh | Reviewer | 28081103
• bernhardoj | Contributor | 28081105

Issue Owner

Current Issue Owner: @hoangzinh

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a6ecd7244e8df2c0

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Double-clicking the "Add reaction" icon in the Action menu highlights the text in the message.

What is the root cause of that problem?

We don't have userSelectNone style applied to the container of the icon, so when clicking twice it still triggers the text select effect.

What changes do you think we should make in order to solve the problem?

Have userSelectNone style applied to the container of the icon, for example here or here.

Since those mini context menu icons are itself never selectable for the user, it makes sense to apply userSelectNone there.

What alternative solutions did you explore? (Optional)

We can apply the same solution if this happens for other context menu, components, ...

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

We don't apply userSelectNone style and pass dataSet={{[CONST.SELECTION_SCRAPER_HIDDEN_ELEMENT]: true}} prop to the element containing the icon.

App/src/components/BaseMiniContextMenuItem.tsx

Lines 67 to 71 in b74be72

	style={({hovered, pressed}) => [
	styles.reportActionContextMenuMiniButton,
	StyleUtils.getButtonBackgroundColorStyle(getButtonState(hovered, pressed, isDelayButtonStateComplete)),
	isDelayButtonStateComplete && styles.cursorDefault,
	]}

What is the root cause of that problem?

We need to apply these apply userSelectNone and pass dataSet={{[CONST.SELECTION_SCRAPER_HIDDEN_ELEMENT]: true}}.

style={styles.userSelectNone}
dataSet={{[CONST.SELECTION_SCRAPER_HIDDEN_ELEMENT]: true}}

What changes do you think we should make in order to solve the problem?

Result

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Double-clicking the emoji reaction mini context select the message.

What is the root cause of that problem?

We had this kind of issue before here (and many other issues). The message text gets selected because the emoji reaction is just a normal div. In that issue, the solution is to render the pressable as a button by setting the role of the pressable to BUTTON.

What changes do you think we should make in order to solve the problem?

Set a role of BUTTON to mini context menu item.
role={CONST.ROLE.BUTTON}

Text selection won't happen if we press a <button>.
(perhaps we can by default set the pressable role to button?)

[hoangzinh]

@dukenv0307 @Krishna2323 @bernhardoj Thanks for your proposals. All of proposals work, but I like @bernhardoj's proposal because:

• It looks like what we would like to apply to avoid highlighting the text when double-clicking.
• It also avoids the issue [$1000] Web - Profile - The text on the modal Drag, zoom, and rotate your image to your preferred is highlighted when rotate the picture the picture #14139 (comment) if we want to add text to mini context menu items later.

Link to @bernhardoj's proposal #33547 (comment)

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @aldo-expensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[dukenv0307]

@hoangzinh I don’t think that solution will work when the user clicks a bit outside a emoji reaction (outside the Pressable), but still inside the mini context menu, like below

Screen.Recording.2023-12-26.at.10.44.37.AM.mov

[hoangzinh]

I'm unsure if it's worth fixing when user clicks outside icons ^

[dukenv0307]

cc @aldo-expensify @kbecciv to confirm, since I think it should work consistently when clicking on the MiniContextMenu, regardless of clicking inside or outside the icons.

[bernhardoj]

For the context menu container, it's just a plain view/element, not a clickable element, just like a message container. It already works as expected.

The issue here is that double-clicking a button shouldn't select a text.

Previously, we used either user-select none or ControlSelection as the workaround to fix it, but now we already have a proper way to do that by using the native button.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@hoangzinh, @Christinadobrzyn, @aldo-expensify Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@hoangzinh, @Christinadobrzyn, @aldo-expensify Eep! 4 days overdue now. Issues have feelings too...

[aldo-expensify]

Tried to reproduce in the public room https://staging.new.expensify.com/r/5593084223054221 in staging, but couldn't . Can anyone help confirm that this is still reproducible?

Screen.Recording.2024-01-02.at.1.55.07.PM.mov

[aldo-expensify]

I see that the context menu for me closes when I click the second time, meanwhile, in the video shown in this GH issue body this doesn't happen. I guess this difference made the problem go away 🤷

[hoangzinh]

@aldo-expensify this issue could be reproduced easier when double-clicking the "Copy to clipboard" icon.

[aldo-expensify]

@aldo-expensify this issue could be reproduced easier when double-clicking the "Copy to clipboard" icon.

Thanks, now I reproduced

[aldo-expensify]

Hmm, maybe that did it.

[bernhardoj]

I can do it.

[aldo-expensify]

I can do it.

ok!

[bernhardoj]

PR is ready

cc: @hoangzinh

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.23-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix double clicking mini context menu selects the message #33963

If no regressions arise, payment will be issued on 2024-01-17. 🎊

For reference, here are some details about the assignees on this issue:

• @hoangzinh requires payment automatic offer (Reviewer)
• @bernhardoj requires payment automatic offer (Contributor)
• @dukenv0307 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@hoangzinh] The PR that introduced the bug has been identified. Link to the PR:
• [@hoangzinh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@hoangzinh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@hoangzinh] Determine if we should create a regression test for this bug.
• [@hoangzinh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

@hoangzinh, @bernhardoj, @Christinadobrzyn, @aldo-expensify, @dukenv0307 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[aldo-expensify]

Bump @hoangzinh on completing the list

[hoangzinh]

BugZero Checklist:

• The PR that introduced the bug has been identified. Link to the PR: feat: add/remove reaction #15210
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/15210/files#r1461997372
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug. ⛔ it's just a small UI improvement

[Christinadobrzyn]

Hi can you confirm this is correct for payouts due?

Issue Reporter: NA
Contributor: $250 @bernhardoj (paid in Upwork) & $250 @dukenv0307 (paid in Upwork)
Contributor+: $500 @hoangzinh (paid in Upwork)

Eligible for 50% #urgency bonus? N

Upwork job is here.

Also, if everyone is getting paid through Upwork, @hoangzinh can you accept our offer so I can pay you through Upwork?

[aldo-expensify]

That looks good to me

[Christinadobrzyn]

Thanks @aldo-expensify! Paid @bernhardoj and @dukenv0307 - waiting on @hoangzinh to accept the Upwork offer

[hoangzinh]

Accepted. Thanks @Christinadobrzyn

[Christinadobrzyn]

Thanks @hoangzinh! I paid you in Upwork based on this payment summary. So this is all done. Closing.