Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOU - IOU information and badge does not use the correct brand font and color #3387

Closed
isagoico opened this issue Jun 7, 2021 · 12 comments
Closed
Assignees
Labels
Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2

Comments

@isagoico
Copy link

isagoico commented Jun 7, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Expected Result:

All font should be the same through all the areas of the app.

Actual Result:

IOU information and badge does not use the correct brand font and color

Action Performed:

  1. Log in to e.cash
  2. Navigate to a conversation
  3. Request money to the user
  4. Check the badge in the LHN

Workaround:

No need, visual issue.

Platform:

Where is this issue confirmed?

Web ✔️
iOS
Android
Desktop App
Mobile Web

Version Number: 1.0.63-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

image

image

Expensify/Expensify Issue URL:

View all open jobs on Upwork


From @shawnborton and @parasharrajat https://expensify.slack.com/archives/C01GTK53T8Q/p1622831130021700

The XXXX owes XXXX line in the IOU preview component does not use our correct brand font nor the correct font color:
Adding up to it. IOU Badge doesn't have correct font Either. DEV badge as well

@MelvinBot
Copy link

Triggered auto assignment to @johnmlee101 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@rushatgabhane
Copy link
Member

rushatgabhane commented Jun 7, 2021

Proposal

The components ReportActionItemIOUPreview, IOUBadge, EnvironmentBadge etc seem to have this problem.

IOU information (A owes B)

Use style prop = styles.chatItemMessage, for text component.
This gives the right color, and font family.

Result
Screenshot from 2021-06-07 19-12-37

Badge

in src/styles/styles.js
add fontFamily: fontFamily.GTA to badgeText.

Result
Screenshot from 2021-06-07 19-12-56
Screenshot from 2021-06-07 19-12-25

@johnmlee101 johnmlee101 added the External Added to denote the issue can be worked on by a contributor label Jun 7, 2021
@MelvinBot
Copy link

Triggered auto assignment to @MitchExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@johnmlee101
Copy link
Contributor

@shawnborton can you confirm this proposal seems to address this issue?

@MitchExpensify
Copy link
Contributor

@johnmlee101 Shawn is ooo this week just fyi

@parasharrajat
Copy link
Member

I think this one is being already worked by Rory in another issue.

@johnmlee101
Copy link
Contributor

cc @roryabraham can we close this out if you're working on it?

@roryabraham
Copy link
Contributor

Yep, I can create a quickie PR for this (and potentially other undiscovered incorrect font issues)

@MitchExpensify MitchExpensify removed their assignment Jun 8, 2021
@roryabraham roryabraham added Weekly KSv2 and removed Daily KSv2 labels Jun 8, 2021
@shawnborton
Copy link
Contributor

Any update on this one?

@roryabraham
Copy link
Contributor

Oops, sorry for the delay here! IDK why melvin didn't bump me on this. I'll update the PR and get it ready for review ASAP!

@roryabraham
Copy link
Contributor

PR is up and ready for review.

@roryabraham roryabraham added the Reviewing Has a PR in review label Jul 1, 2021
@parasharrajat
Copy link
Member

Could be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants