-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IOU - IOU information and badge does not use the correct brand font and color #3387
Comments
Triggered auto assignment to @johnmlee101 ( |
ProposalThe components ReportActionItemIOUPreview, IOUBadge, EnvironmentBadge etc seem to have this problem. IOU information (A owes B)Use style prop = styles.chatItemMessage, for text component. Badgein src/styles/styles.js |
Triggered auto assignment to @MitchExpensify ( |
@shawnborton can you confirm this proposal seems to address this issue? |
@johnmlee101 Shawn is ooo this week just fyi |
I think this one is being already worked by Rory in another issue. |
cc @roryabraham can we close this out if you're working on it? |
Yep, I can create a quickie PR for this (and potentially other undiscovered incorrect font issues) |
Any update on this one? |
Oops, sorry for the delay here! IDK why melvin didn't bump me on this. I'll update the PR and get it ready for review ASAP! |
PR is up and ready for review. |
Could be closed. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Expected Result:
All font should be the same through all the areas of the app.
Actual Result:
IOU information and badge does not use the correct brand font and color
Action Performed:
Workaround:
No need, visual issue.
Platform:
Where is this issue confirmed?
Web ✔️
iOS
Android
Desktop App
Mobile Web
Version Number: 1.0.63-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Expensify/Expensify Issue URL:
View all open jobs on Upwork
From @shawnborton and @parasharrajat https://expensify.slack.com/archives/C01GTK53T8Q/p1622831130021700
The text was updated successfully, but these errors were encountered: