Fix text styles by removing uses of the non-custom text component #3848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Because 59 files were changed here, this will be a nightmare to keep up-to-date. Quick reviews appreciated 🙇 |
MonilBhavsar
previously approved these changes
Jul 1, 2021
# Conflicts: # src/components/PopoverMenu/BasePopoverMenu.js # src/pages/home/HeaderView.js # src/pages/home/report/EmojiPickerMenu/index.native.js # src/pages/home/report/ReportActionCompose.js # src/pages/settings/Payments/AddPayPalMePage.js
|
Fixed merge conflicts, going to need another review @MonilBhavsar. |
MonilBhavsar
previously approved these changes
Jul 9, 2021
shawnborton
previously approved these changes
Jul 9, 2021
|
Looks like we have a conflict. |
# Conflicts: # src/pages/settings/Profile/ProfilePage.js
roryabraham
dismissed stale reviews from shawnborton and MonilBhavsar
via
b3b3d69
|
Conflicts resolved! |
shawnborton
approved these changes
Jul 9, 2021
MonilBhavsar
approved these changes
Jul 9, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
23 tasks
|
🚀 Deployed to production in version: 1.0.77-5🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Enforces the use of our custom text component throughout the app instead of the default RN text component. This ensures that our default styles are used. Also removes
styles.textP, which is redundant when the default custom text component is used.Fixed Issues
$ #3387
Tests / QA Steps
Click through the various screens and components of the app - verify that everywhere you see the correct use of our fonts. Pro-tip: take a look at the
g's – they look noticeably different in GT America with this distinctive tail:Pay particular attention to IOU actions and previews, because we know these were previously using the incorrect font.
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android