Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: Expensify.cash 2021-07-09 #3958

Closed
23 tasks done
OSBotify opened this issue Jul 9, 2021 · 18 comments
Closed
23 tasks done

Deploy Checklist: Expensify.cash 2021-07-09 #3958

OSBotify opened this issue Jul 9, 2021 · 18 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Jul 9, 2021

Release Version: 1.0.77-5
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

cc @Expensify/applauseleads

@isagoico
Copy link

isagoico commented Jul 9, 2021

@roryabraham Should we start QA on this new checklist today or can we start Monday?

@roryabraham
Copy link
Contributor

Yeah, go ahead and start

@isagoico
Copy link

isagoico commented Jul 9, 2021

Starting QA!

@isagoico isagoico added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Jul 9, 2021
@isagoico
Copy link

Checking off #3715 (comment)

@roryabraham
Copy link
Contributor

#3974 should be fixed in 1.0.77-1

@roryabraham
Copy link
Contributor

#3964 and also probably #3965 should be fixed in 1.0.77-2

@isagoico
Copy link

Both #3974 and #3964 have been fixed! Only deploy blocker remaining is #3965 which is still reproducible.

@isagoico
Copy link

Oh no @roryabraham looks like the issue is back 😟

@roryabraham
Copy link
Contributor

ah, yeah this seems to still happen only when a PR is CP'd

@roryabraham
Copy link
Contributor

roryabraham commented Jul 14, 2021

Updated the list – can we confirm that the last deploy blocker is fixed in 1.0.77-3, then if so run a prod deploy & start a new round of QA?

@roryabraham
Copy link
Contributor

Oops, 1.0.77-3 doesn't actually exist yet. See this PR that had conflicts.

@isagoico
Copy link

isagoico commented Jul 14, 2021

Sure! Waiting on the build to be available since I'm not seeing it in the playstore yet just saw the message above

@roryabraham
Copy link
Contributor

1.0.77-3 is available on all platforms except iOS. Deploy is running here. Let's get ahead of testing it so that we can get this closed out ASAP.

@roryabraham
Copy link
Contributor

Okay, 1.0.77-3 should now be available on all platforms.

@roryabraham
Copy link
Contributor

Please HOLD prod deploy

@isagoico
Copy link

Tested #3965 on Android and it was a pass! New changes look great 😁

@rafecolton
Copy link
Member

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

5 participants