-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix IOU currency routes #3932
Fix IOU currency routes #3932
Conversation
|
Fix IOU currency routes (cherry picked from commit 1cc22a1)
This PR was CP'd in |
@roryabraham Should go ahead and test this PR? |
Yep, it's on staging. Go ahead and test it please 🙇 |
Actually @isagoico I already tested this and closed the linked issue. I'm going to check this off the deploy checklist. |
🚀 Deployed to production in version: 1.0.77-5🚀
|
Details
Just some broken routes – we were trying to go to
/iou/split//currency
, where the missing section is meant to be areportID
. However, in this case it's perfectly legitimate to not have areportID
, because we're creating a new bill split. So instead, we can fix this by going to/iou/split/:reportID/currency
. It actually doesn't matter what's betweensplit/
and/currency
, as long as it's not empty. Justx
seems to work as well.Fixed Issues
$ #3920
Tests / QA Steps
Split Bill
Request Money
Tested On
Screenshots
Web
CurrencyRouteWeb.mov
Mobile Web
CurrencyRouteMWeb.mov
Desktop
CurrencyModalDesktop.mov
iOS
IOUCurrencyIOS.mov
Android