Deploy Checklist: Expensify.cash 2021-07-14

[OSBotify]

Release Version: 1.0.79-3
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Update staging to 1.0.16-0 #2287
• Update app icons for NewDot branding #2635
• feat: New landing page design #3079
• Update Permissions logic to fix IOU regression #3481
• [NO-QA] Bump Onyx commit to fix IOU regression #3483
• Use hrefAttrs for links #3486
• Fix infinite spinner when signing into an account after signing out #3535
• Upgrade react-native-document-picker to 5.1.0 #3550
• Add capturing event listeners to the KeyboardShortcut library #3555
• fix: Document Picker crash on IOS #3581
• Set up app for Expo SDK, add haptic feedback for long presses with Expo Haptics #3607
• Add Venmo to intent filter list in AndroidManifest.xml #3713
• Don't focus input until screen transition has ended #3719
• Preload locales to fix native crash #3749
• Revert suppression of touchstart to fix regressions #3816
• [CP Staging] Revert "Fix Desktop - CMD + K is slow and laggy #3601" #3824
• Start including betas in the call to getSidebarOptions #3840
• Fix: Tooltip and message date position #3864
• [Hold] fixed spaces collapsing in Messages #3869
• Added tapable links to user's login information on DetailsPage #3870
• Using new parameter name #3873
• Add avatars based on svg icons for default rooms #3891
• Get&returnValueList=reportSummaryList #3894
• Improves transition when changing chats #3908
• Treat IOU debts as pinned reports in the LHN #3925
• Fix: blue screen issue on Safari Web #3927
• Fix IOU currency routes #3932
• [No QA] Fix Comment on issues GH action. #3937
• Fix profile menu position #3943
• Only provide a default lineHeight when the fontSize is default #3966
• Add link to Concierge on Validation screen when bank account is verifying #3967
• Revert "[Hold] fixed spaces collapsing in Messages" #3969
• Web/Desktop Press Enter key to go next #3977
• add LHN label for deleted messages #3979
• [Hold - To be deployed with new.expensify.com changes] Scrubbing Expensify Cash for New Expensify #3984
• Update Bank Account RequestorStep UI #3986
• fixed scrolling and layout #3988
• Make button visible in WorkspaceInvitePage #3989
• Give disabled buttons the disabled cursor style #3992
• [TEST] [No QA] - Test E.cash issue lifecycle webhook for employees #3998
• [TEST] [No QA] Testing E.cash issue lifecycle - Delete test.md #4001
• [TEST] [No QA] - Test E.cash issue lifecycle webhook for employees 2 #4003
• Fix wrong active report on LHN #4004
• [Feature] Support to html pasting on web #4009
• [TEST] [No QA] - Test E.cash issue lifecycle webhook for employees 3 #4013
• [No QA] Change expensify.cash => new.expensify.com #4016
• [TEST] [No QA] - Test E.cash issue lifecycle webhook for employees 4 #4017
• Show a growl and redirect when navigating to a chat we can't access #4018
• Fix display of report typing indicator and participant local time #4020
• [TEST] [No QA] - Test E.cash issue lifecycle webhook for employees 5 #4024
• [No QA] fix: suppress distracting log box warnings #4031
• Hide add payment button #4034
• Remove default state AK and require users to enter a state #4035
• [No QA] Fix incorect staging url #4037
• Update version to 1.0.77-6 on staging #4045
• [No QA] Changed App Store Icon #4048
• [NO QA] fix: action failure on invalid String in BASH #4049
• Update version to 1.0.77-7 on staging #4051
• Update version to 1.0.78-0 on staging #4054
• [CP Staging] Don't show all chats in LHN in #focus mode #4059
• Restrict self requests & naming convention changes #4063
• 🍒 Cherry pick PR #4059 to staging 🍒 #4065
• Fix Line-break parsing issue in E.cash. #4067
• Update about page copy #4069
• Remove unnecessary calls to updateLastRead #4078
• fixed text selection on resized web devices #4079
• [No QA] Configured Reanimated 2 for Drawer #4081
• Load policies after we load betas as well #4084
• Reverting 3979 #4085
• 🍒 Cherry pick PR #4085 to staging 🍒 #4088
• [ISSUE-4086] Added initial number in FlatList #4089
• Update version to 1.0.78-3 on staging #4093
• Update version to 1.0.78-4 on staging #4095
• [No QA] Make a dummy change for a test PR #4096
• [No QA] Undo dummy change #4098
• Update version to 1.0.78-5 on staging #4100
• Update version to 1.0.79-0 on staging #4103
• [No QA] Update staging from main #4113
• [CP Staging] Remove duplicate form fields #4117
• fix: paste and Ctrl+z #4131
• Stop call to Get&rvl=reportStuff with reportID = undefined #4139
• [No QA] Use onLayout to record chat switching time #4140
• Don't check participants' whole names in default rooms #4141
• Modify line height so text does not get cut off in LHN #4143
• Use round avatar for E.Cash room avatar #4144
• [No QA] RenameGetPreferredCurrency API command to GetLocalCurrency #4145

Deploy Blockers:

• Sign in - infinite spinner for some users with incorrect NVP structure #4058
• Workspace - Fields appear twice in invite people page #4060
• [Hold for Payment 10 August] Web - Chat - When Pasting the copied text in compose field there are 2 line breaks before and after the text #4066
• Android - Chat - Message sent in offline is not bold after regaining WiFi connection  #4071
• Android - IOU - Request money from a new user from chat conversation asks to select a user  #4072
• Desktop - Chat - User name is not displayed when initiating chat for the first time  #4075
• Android - Chat - "Comment deleted" displayed when IOU request sent for a user with no conversation before #4073
• Android - LHN - Period is displayed in between the user names of group chat in unread messages #4074
• Web - Safari - Login - Signin page looks weird #4110

cc @Expensify/applauseleads

[isagoico]

@roryabraham were good to start QA right?

[mvtglobally]

Starting QA

[Julesssss]

#4066 is unreproducible, so I've checked it off the list

[roryabraham]

@isagoico @mvtglobally I went through and checked a bunch of items that should not be only this checklist. I checked them off instead of deleting them so I don't have to do it again if the issue is updated and they're added back again. Sorry about the 🐛 – it disappeared on its own for a while, then came back on it's own 😠

[roryabraham]

Hello! It seems like we somehow got into a weird state where there was somehow a diff between staging and main at the time of the normal staging deploy for 1.0.78-0. We're still investigating, but it appears that this deploy blocker is not reproducible on main. To resolve this, we want to run another full staging deploy and see if it happens again.

So @isagoico @mvtglobally when QA is done, let's just remove the lock label on this and add it back tomorrow when you're ready to begin QA. Thanks!

[isagoico]

#3988 leaving this PR unchecked so it's tested on the next QA run

[isagoico]

Regression is finished!
Issues found:

1. Desktop - Chat - Copy to clipboard icon is hidden for longer emails in details page #4076
2. Android - LHN - Period is displayed in between the user names of group chat in unread messages #4074
3. Android - Chat - "Comment deleted" displayed when IOU request sent for a user with no conversation before #4073
4. Desktop - Chat - User name is not displayed when initiating chat for the first time  #4075 (same as Android - IOU - Request money from a new user from chat conversation asks to select a user  #4072)
5. Log in - Validation messages are hidden behind keyboard #4080
6. Android - Chat - Message sent in offline is not bold after regaining WiFi connection  #4071 - Not reproducible in 1.0.78-1
7. [Hold for Payment 10 August] Web - Chat - When Pasting the copied text in compose field there are 2 line breaks before and after the text #4066

PRs are finished too.
Comments added:

1. feat: New landing page design #3079 (comment) - Expected behaviour
2. [Hold] fixed spaces collapsing in Messages #3869 (comment)

Internal QA:

1. Get&returnValueList=reportSummaryList #3894
2. Add link to Concierge on Validation screen when bank account is verifying #3967

New PRs recently added to checklist (that will be tested in the next QA run):

1. [Hold - To be deployed with new.expensify.com changes] Scrubbing Expensify Cash for New Expensify #3984
2. Give disabled buttons the disabled cursor style #3992
3. [Feature] Support to html pasting on web #4009 is failing because of [HOLD for payment July 22] Update line break regex for HTML->Markdown to support break tags with styles #4052 (we will retest when the fix is merged)
4. Hide add payment button #4034
5. Remove default state AK and require users to enter a state #4035
6. [CP Staging] Don't show all chats in LHN in #focus mode #4059
7. Restrict self requests & naming convention changes #4063
8. Update about page copy #4069
9. Remove unnecessary calls to updateLastRead #4078
10. fixed text selection on resized web devices #4079
11. Reverting 3979 #4085

Thanks!

[chiragsalian]

#4073 should be resolved on version 1.0.78.2 which is on staging. Feel free to test it on ios or android to confirm.

[roryabraham]

I want to test #3383 on this checklist, so ping me when you're ready to begin QA and I can assign the lock label myself. cc @parasharrajat

[isagoico]

@roryabraham you can go ahead and add the lock label when needed. I can set up and begin QA tomorrow morning so we can start testing early in the day.

[TomatoToaster]

Checking off #4084 (comment) as per the comment confirming it works ✅

[isagoico]

Regression is finished!
Issues found:

1. Web - Safari - Login - Signin page looks weird #4110
2. iOS - Sign in - Sign in Button is hidden under the keyboard #4108

PRs are finished too!
No comments added.

These Internal QA PRs are missing QA (CC @marcaaron) :

1. Get&returnValueList=reportSummaryList #3894
2. Add link to Concierge on Validation screen when bank account is verifying #3967

Thanks!

[marcaaron]

Just a heads up, I think the next E.cash release should be blocked on the next Auth deploy which should include the changes here.

Edit: Oh I see it's already covered by #4075

Going to check off the other PR then it works fine apart from this bug.

[marcaaron]

I'm looking for someone to help test #3967, but I don't think it needs to block the next release build of Expensify.cash. The feature is still behind a beta and we can keep testing until it's ready to come off the beta.

Edit: We tested it and it passed

[marcaaron]

Checking off #4075

[isagoico]

@AndrewGable The checklist issue is back, I think there was a CP and a bunch of PRs (that are not in staging) were added to the list. I gave it a look and I think none of these should be in the checklist:

1. Stop call to Get&rvl=reportStuff with reportID = undefined #4139
2. Show a growl and redirect when navigating to a chat we can't access #4018
3. [NO QA] fix: action failure on invalid String in BASH #4049
4. Stop call to Get&rvl=reportStuff with reportID = undefined #4139
5. [No QA] Use onLayout to record chat switching time #4140
6. Don't check participants' whole names in default rooms #4141
7. Use round avatar for E.Cash room avatar #4144
8. [No QA] RenameGetPreferredCurrency API command to GetLocalCurrency #4145

Thanks in advance!

[AndrewGable]

Mentioned in Slack, but what do we usually do for this type of bug? Do we just check those items off?

[isagoico]

Yes! They can be checked off and we just have to keep an eye if they get added to the new checklist (after the production deploy)

[Jag96]

Went through to double-check those and checked off the following because they haven't been deployed to staging yet:

• Show a growl and redirect when navigating to a chat we can't access #4018
• [NO QA] fix: action failure on invalid String in BASH #4049
• Stop call to Get&rvl=reportStuff with reportID = undefined #4139
• [No QA] Use onLayout to record chat switching time #4140
• Don't check participants' whole names in default rooms #4141
• Use round avatar for E.Cash room avatar #4144
• [No QA] RenameGetPreferredCurrency API command to GetLocalCurrency #4145

I didn't check off the Cherry Pick PRs or the Update version PRs, should those be checked off as well?

[Jag96]

Also checking off #4110 (comment) - based on the comment we're not labeling it a deploy blocker

[Jag96]

It looks like #4131 and #4074 are the only things here that need to be checked off before we can do a production deploy, is that right @isagoico?

[isagoico]

@Jag96 So sorry for the delay, just got home after the flights. Yep we can check off the Cherry Picks and the Update versions (just took care of that)
These two need to be checked off (since they were CPd):

• fix: paste and Ctrl+z #4131
• Modify line height so text does not get cut off in LHN #4143

#4074 can be checked off if #4131 is a pass (I can take care of it right now)

[isagoico]

@AndrewGable @Jag96 I retested both the CPd PRs and the missing deploy blocker issue and it was a pass 🎉 All items are checked and we should have a green light to do a prod deploy.

Only thing that worries me a bit is this issue #4066 which I'm still able to reproduce on Windows 10 (only on staging) but it was discarded as Deploy blocker.

[AndrewGable]

I agree that issue does look relevant still, but I agree we can move forward with a production deploy with that known issue.

[AndrewGable]

[isagoico]

Also.. I was thinking maybe we could get a notification to @Expensify/applauseleads every time there are Cherry Picks that need QA (from us), currently I have to manually check if there has been any CPs and I could take a while before noticing there was one. Let me know what you think guys think, I'm sure it would help us to retest the fixes faster 😬.

[AndrewGable]