Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverting 3979 #4085

Merged
merged 1 commit into from
Jul 15, 2021
Merged

Reverting 3979 #4085

merged 1 commit into from
Jul 15, 2021

Conversation

chiragsalian
Copy link
Contributor

Details

The issue of the GH arises from #3979 so we're reverting it

Fixed Issues

$ #4073

Tests / QA

  1. Request money to someone you've never chatted with before.
  2. Confirm the message in LHN on mobile doesn't show Comment Deleted
    image

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@chiragsalian chiragsalian requested a review from a team as a code owner July 15, 2021 18:33
@chiragsalian chiragsalian self-assigned this Jul 15, 2021
@MelvinBot MelvinBot requested review from Luke9389 and removed request for a team July 15, 2021 18:33
This was referenced Jul 15, 2021
Closed
Merged
@OSBotify
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@chiragsalian chiragsalian merged commit d15c65a into main Jul 15, 2021
@chiragsalian chiragsalian deleted the chirag-revert-3979 branch July 15, 2021 19:05
github-actions bot pushed a commit that referenced this pull request Jul 15, 2021
@chiragsalian
Merge pull request #4085 from Expensify/chirag-revert-3979
c2f92b6 
Reverting 3979

(cherry picked from commit d15c65a)
This was referenced Jul 15, 2021
Merged
Closed
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging in version: 1.0.78-2🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.78-3🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

dklymenk added a commit to dklymenk/Expensify.cash that referenced this pull request Jul 18, 2021
@dklymenk
Revert "Merge pull request Expensify#4085 from Expensify/chirag-rever…
3d88bfd 
…t-3979"

This reverts commit c2f92b6.
This was referenced Jul 23, 2021
Closed
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.79-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

1 similar comment
@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.79-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

chiragsalian added a commit that referenced this pull request Nov 16, 2021
@chiragsalian
Merge pull request #4133 from dklymenk/3743-3293-return-LHN-label-for…
8ca2cbb 
…-deleted-messages

Revert "Merge pull request #4085 from Expensify/chirag-revert-3979"
@OSBotify OSBotify mentioned this pull request Nov 22, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @chiragsalian in version: 1.1.15-18 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.16-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luke9389 Luke9389 Luke9389 approved these changes

Assignees

@chiragsalian chiragsalian

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chiragsalian @OSBotify @Luke9389