Get&returnValueList=reportSummaryList

[marcaaron]

Details

Replaces Get&returnValueList=reportStuff with reportSummaryList.

This cuts initial fetching and re-fetching of reports from ~ 7 seconds to 1.5 seconds on a test account with many large chats and should speed things up for users.

Fixed Issues

$ #3875

Tests

Note: Pull Auth main branch and re-build before testing!

1. Create an account with several hundred reports each having 1000+ comments (clitools can help with this)
2. Sign in and verify that you are able to do so and the LHN populates in a reasonable amount of time less than a couple of seconds and not 5-7 seconds.
3. We are looking for the response time of the command Get&returnValueList=reportSummaryList which can be analyzed in the network tab

QA Steps

For QA we'll do the same steps but ask @JmillsExpensify or someone with a large number of chats to test this out for us on staging.

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

[marcaaron]

This is still on HOLD (waiting for Auth deploy) but I'm moving it into reviews

[Jag96]

Ok, after some back and forth w/ testing it looks like if the user has a pinned chat, the getReportSummaryList command fails in auth

Logs for user without any pinned chats (tested by navigating to https://www.expensify.com/api?command=Get&returnValueList=reportSummaryList&reportIDList=MY_REPORT_ID): logs

Logs for user with pinned chats (same URL, just pinned a chat and refreshed): logs

[Jag96]

With the latest changes in https://github.com/Expensify/Auth/pull/5769 this is working great for me!

[marcaaron]

Looks like the auth change has been deployed so I'm going to merge this guy 🤞

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging in version: 1.0.77-6🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[isagoico]

@marcaaron @JmillsExpensify Hello! let us know when this is tested so we can check it off the list 🙇

[marcaaron]

I think we probably want to make this a blocker and wait until https://github.com/Expensify/Auth/pull/5780 has been deployed. Right, @Jag96 ?

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[marcaaron]

nvm left more context on the checklist we can check this one off I think..

[OSBotify]

🚀 Deployed to production in version: 1.0.79-4🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅