[CP Staging] Don't show all chats in LHN in #focus mode #4059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jag96
changed the title
|
|
|
Applying the CP staging label to fix #focus mode on staging |
marcaaron
approved these changes
Jul 15, 2021
github-actions bot
pushed a commit
that referenced
this pull request
Jul 15, 2021
[CP Staging] Don't show all chats in LHN in #focus mode (cherry picked from commit 951308f)
This was referenced Jul 15, 2021
|
🚀 Cherry-picked to staging in version: 1.0.78-1🚀
|
|
🚀 Deployed to staging in version: 1.0.78-3🚀
|
|
🚀 Deployed to production in version: 1.0.79-4🚀
|
1 similar comment
|
🚀 Deployed to production in version: 1.0.79-4🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@marcaaron will you please review this?
Details
This fixes a bug introduced in #3894 where all chats were showing in focus mode because the unreadActionCount was being set to a non-existent report property. This PR updates the property to match the one returned from the back end.
Fixed Issues
$ #4057
Tests/QA
#focusmode, confirm already-read chats only show up if they are pinned, if they are an IOU, or if they are the currently selected chat.Recentmode, confirm all chats are shownTested On
Screenshots