Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using new parameter name #3873

Merged
merged 1 commit into from
Jul 14, 2021
Merged

Using new parameter name #3873

merged 1 commit into from
Jul 14, 2021

Conversation

joelbettner
Copy link
Contributor

See https://github.com/Expensify/Auth/pull/5721 for context on this change

Since this is a feature that is only in beta for Expensify employees, we can either CP this change or regular deploy it after the auth changes are deployed.

@joelbettner joelbettner requested a review from a team as a code owner July 2, 2021 21:15
@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@MelvinBot MelvinBot requested review from Dal-Papa and removed request for a team July 2, 2021 21:15
@joelbettner
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@joelbettner joelbettner self-assigned this Jul 2, 2021
@joelbettner joelbettner requested review from madmax330 and removed request for Dal-Papa July 2, 2021 22:04
Copy link

@Dal-Papa Dal-Papa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
EDIT: Whoops, didn't realize I wasn't the reviewer anymore. 😅

@joelbettner
Copy link
Contributor Author

I think we can CP this today after https://github.com/Expensify/Auth/pull/5721 is deployed.

@madmax330 madmax330 changed the title [HOLD https://github.com/Expensify/Auth/pull/5721] Using new parameter name Using new parameter name Jul 14, 2021
@madmax330 madmax330 merged commit bb5ae3e into main Jul 14, 2021
@madmax330 madmax330 deleted the joel_tierName branch July 14, 2021 08:42
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.77-6🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.79-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants