Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS - Sign in - Sign in Button is hidden under the keyboard #4108

Closed
kavimuru opened this issue Jul 16, 2021 · 8 comments
Closed

iOS - Sign in - Sign in Button is hidden under the keyboard #4108

kavimuru opened this issue Jul 16, 2021 · 8 comments
Assignees
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@kavimuru
Copy link

kavimuru commented Jul 16, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the app
  2. Enter an email address which has 2FA enabled
  3. Hit enter

Expected Result:

Sign in button is visible below the Two Factor Code field

Actual Result:

Sign in button is hidden under the keyboard

Workaround:

Unknown

Platform:

Where is this issue occurring?

Web
iOS ✔️
Android
Desktop App
Mobile Web

Version Number:
1.0.78-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Bug5153150_IMG_1338_1_

Issue is reproducible only in small sized phones iPhone 6S and iPhone 8

Expensify/Expensify Issue URL:

View all open jobs on Upwork

Upwork job: https://www.upwork.com/jobs/~019447d8dcb5836434

@MelvinBot
Copy link

Triggered auto assignment to @alex-mechler (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@alex-mechler
Copy link
Contributor

Looks like a perfect external issue. Thanks for noting what devices in particular this happens with!

@alex-mechler alex-mechler removed their assignment Jul 16, 2021
@alex-mechler alex-mechler added the External Added to denote the issue can be worked on by a contributor label Jul 16, 2021
@MelvinBot
Copy link

Triggered auto assignment to @puneetlath (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@rdjuric
Copy link
Contributor

rdjuric commented Jul 16, 2021

We can wrap our PasswordForm screen in a KeyboardAvoidingView to reveal the next input box.

@isagoico
Copy link

Issue reproducible during KI retests.

@MelvinBot MelvinBot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 21, 2021
@puneetlath
Copy link
Contributor

@rdjuric your solution sounds good. Can you apply to the up work job here: https://www.upwork.com/jobs/~019447d8dcb5836434?

@puneetlath puneetlath removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 21, 2021
@rdjuric
Copy link
Contributor

rdjuric commented Jul 21, 2021

Hey @puneetlath!

We decided to wrap our login steps (including PasswordForm) in a KeyboardAvoidingView in another issue: #4080

Do I still apply to this Upwork job even if it's the same fix as to #4080?

@puneetlath
Copy link
Contributor

Ah cool! Thanks for pointing that out to me. Let's just close this out since it's a dupe of that one. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

6 participants