Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed text selection on resized web devices #4079

Merged
merged 1 commit into from
Jul 15, 2021

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented Jul 15, 2021

Details

Fixed Issues

$ #4012

Tests | QA Steps

  1. Open any chat on E.cash in a Web browser.
  2. Resize the browser window until LHN is hidden.
  3. Try to select text on the Chat messages.
  4. You should be able to select the text.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

selection-w.mp4

Mobile Web

selection-m.mp4

Desktop

selection-d.mp4

iOS

Android

@parasharrajat parasharrajat requested a review from a team as a code owner July 15, 2021 15:38
@MelvinBot MelvinBot requested review from iwiznia and removed request for a team July 15, 2021 15:38
@iwiznia
Copy link
Contributor

iwiznia commented Jul 15, 2021

Can you please add tests to make sure the feature is not broken on mobile (both web and app)?

@parasharrajat
Copy link
Member Author

parasharrajat commented Jul 15, 2021

@iwiznia yea, In the middle of uploading screenshots.

@iwiznia
Copy link
Contributor

iwiznia commented Jul 15, 2021

Oh cool, leave a message here when you are done and I can merge.

@parasharrajat
Copy link
Member Author

@iwiznia Ready. Thanks.

@iwiznia iwiznia merged commit 8427c45 into Expensify:main Jul 15, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.78-3🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.79-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants