Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] RenameGetPreferredCurrency API command to GetLocalCurrency #4145

Merged
merged 1 commit into from
Jul 20, 2021

Conversation

mountiny
Copy link
Contributor

cc @luacmartins @Beamanator

Details

The API Command GetPreferredCurrency has been renamed to GetLocalCurrency in Web-E and merged https://github.com/Expensify/Web-Expensify/pull/31503.

This PR updates renames the command in API of new.e so it works with current Web-E master.

Fixed Issues

No Issues

Tests

QA Steps

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@mountiny mountiny self-assigned this Jul 20, 2021
@mountiny mountiny requested a review from a team as a code owner July 20, 2021 09:05
@MelvinBot MelvinBot requested review from tgolen and removed request for a team July 20, 2021 09:06
@github-actions
Copy link
Contributor

github-actions bot commented Jul 20, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@mountiny
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@Julesssss
Copy link
Contributor

Screenshot 2021-07-20 at 11 10 09

@Julesssss Julesssss merged commit 5308246 into main Jul 20, 2021
@Julesssss Julesssss deleted the vit-fixAPICommand branch July 20, 2021 10:10
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.79-5🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.80-2🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants