Stop call to Get&rvl=reportStuff with reportID = undefined #4139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcaaron
changed the title
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
This was referenced Jul 20, 2021
|
🚀 Deployed to staging in version: 1.0.79-5🚀
|
|
🚀 Deployed to production in version: 1.0.80-2🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Weird thing I came across on dev that should be fixed. Noticed a 2 second call to
Get&returnValueList=reportStuffthat was being called with areportIDofundefinedand traced it to the IOU code. When we do not find an IOU reportID for any reason we are continuing to fetch the report. Which makes no sense + takes a significant amount of time to process.Basically, we log this:
GetIOUReport returned a reportID of 0, not fetching IOU report dataAnd then go ahead and fetch it anyway which takes 2 seconds for some reason (production web server used)...
Fixed Issues
No issue. Just noticed on dev that this should be cleaned up.
Tests
QA Steps
Test IOU features for any possible regressions.
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android