Hide add payment button

[tugbadogan]

cc @roryabraham @kevinksullivan

Details

Add Payment Method no longer shows paypal.me option if there's an existing Paypal.me username and Add Payment Method button is hidden completely if there is no available payment method to add.

Fixed Issues

Fixes #3960

Tests

Tested by adding and updating Paypal.me username on different platforms.

QA Steps

• Navigate to settings/payments
• Click on "Add new payment method"
• Click on PayPal.me
• Add a Paypal.me account and save
• Go back to Payment Method List
• Make sure "Add new payment method" button is hidden
• Click and edit existing Paypal.me username

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

Screen.Recording.2021-07-14.at.14.16.25-2.mov

Mobile Web

Screen.Recording.2021-07-14.at.14.18.51.mov

Desktop

Screen.Recording.2021-07-14.at.14.24.40-2.mov

iOS

Screen.Recording.2021-07-14.at.15.27.35.mov

Android

Screen.Recording.2021-07-14.at.15.05.32.mov

[tugbadogan]

As I mentioned in the issue, comment these lines to test this PR.
https://github.com/Expensify/Expensify.cash/blob/039b671cc6683372317327fde6dc4f9ecb78818b/src/libs/actions/User.js#L76-L77

[roryabraham]

Actually @tugbadogan I was wrong - no API changes are needed. The bug in getUserDetails is front-end only. Make the following change to the API call in there and it will work:

API.Get({
        returnValueList: 'account, loginList, nameValuePairs',
        nvpNames: [CONST.NVP.BLOCKED_FROM_CONCIERGE, CONST.NVP.PAYPAL_ME_ADDRESS].join(','),
    })

[roryabraham]

Otherwise, the code looks great! Let's get this easy bug fix added to the PR then this should be good-to-go. Thanks and great work!

[tugbadogan]

@roryabraham Thanks for the review. I fixed the API call in getUserDetails function. Now it works without any problem.

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging in version: 1.0.78-3🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production in version: 1.0.79-4🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅