Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment July 22] Update line break regex for HTML->Markdown to support break tags with styles #4052

Closed
Jag96 opened this issue Jul 14, 2021 · 4 comments
Assignees
Labels
Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2

Comments

@Jag96
Copy link
Contributor

Jag96 commented Jul 14, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


More context in #4009 (comment), this is part of #3047, @parasharrajat will handle as a follow-up

Action Performed:

  1. Copy the following text:

Bold text
italic text
Strikethrough text

  1. Paste the text in e.cash

Expected Result:

Line breaks should be included in the pasted message

Actual Result:

Line breaks aren't included in the pasted message

image

Workaround:

The user has to manually insert line breaks

Platform:

Web

Version Number: 1.0.77-6

View all open jobs on Upwork

@Jag96 Jag96 added External Added to denote the issue can be worked on by a contributor Engineering Weekly KSv2 labels Jul 14, 2021
@Jag96 Jag96 self-assigned this Jul 14, 2021
@MelvinBot MelvinBot added Daily KSv2 and removed Weekly KSv2 labels Jul 14, 2021
@Jag96 Jag96 added the Exported label Jul 14, 2021
@MelvinBot MelvinBot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 14, 2021
@Jag96 Jag96 added Weekly KSv2 and removed Help Wanted Apply this label when an issue is open to proposals by contributors Daily KSv2 labels Jul 14, 2021
@parasharrajat
Copy link
Member

  1. It is straightforward like we did for Italic.
    <br(?:"[^"]*"|'[^']*'|[^'">])*>(?![^<]*(<\/pre>|<\/code>))\n?

We need to exclude pre and code tags and Allow any attribute between start tags, with one exception there is no end tag here.

@isagoico
Copy link

Let us know when #3047 is fixed so we can retest this PR :)

@Jag96 Jag96 changed the title Update line break regex for HTML->Markdown to support break tags with styles [HOLD for payment July 22] Update line break regex for HTML->Markdown to support break tags with styles Jul 15, 2021
@Jag96
Copy link
Contributor Author

Jag96 commented Jul 16, 2021

We're going to be doing #3047 in pieces, so #4009 is the latest PR (on staging) to test for this!

@Jag96
Copy link
Contributor Author

Jag96 commented Jul 22, 2021

Paid!

@Jag96 Jag96 closed this as completed Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants