Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed lin-break <br> HTML parsing #394

Merged
merged 1 commit into from
Jul 15, 2021
Merged

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented Jul 14, 2021

@Jag96 will you please review this?

[Explanation of the change or anything fishy that is going on]

Fixed Issues

$ Expensify/App#4052

Tests

  1. What unit/integration tests cover your change? What autoQA tests cover your change?
    Unit
  2. What tests did you perform that validates your changed worked?
    unit

QA

  1. What does QA need to do to validate your changes?
    Try to paste a few messages that contains line breaks in E.cash after this is merged.

  2. What areas to they need to test for regressions?
    E.cash.

@parasharrajat parasharrajat requested a review from a team as a code owner July 14, 2021 22:42
@MelvinBot MelvinBot requested review from thienlnam and removed request for a team July 14, 2021 22:42
Copy link
Contributor

@Jag96 Jag96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jag96 Jag96 merged commit cf78cdc into Expensify:master Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants