Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Line-break parsing issue in E.cash. #4067

Merged
merged 1 commit into from
Jul 15, 2021

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented Jul 15, 2021

Details

Fixed Issues

$ #4052

Tests | QA Steps

  1. Open any chat in e.cash
  2. Copy the following text:

Bold text
italic text
Strikethrough text

  1. Paste the text in e.cash composer
  2. Line breaks should be shown correctly.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Can't capture this effect as I don't have any example of copied content where
contains style but unit test are in place to verify it.

Web

Mobile Web

Desktop

iOS

Android

@parasharrajat parasharrajat requested a review from a team as a code owner July 15, 2021 04:40
@MelvinBot MelvinBot requested review from Jag96 and removed request for a team July 15, 2021 04:40
Copy link
Contributor

@Jag96 Jag96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jag96 Jag96 merged commit f8de6ee into Expensify:main Jul 15, 2021
@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.78-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.79-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants