Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves transition when changing chats #3908

Merged
merged 1 commit into from
Jul 8, 2021
Merged

Improves transition when changing chats #3908

merged 1 commit into from
Jul 8, 2021

Conversation

rdjuric
Copy link
Contributor

@rdjuric rdjuric commented Jul 7, 2021

Details

Changed our loading logic so that the Loading indicator is shown first, and then we attempt to render our ReportView.

Fixed Issues

$ #3729

Tests

  1. Opened a chat
  2. Navigated to another chat
  3. The Loading indicator was shown correctly, previous chat wasn't visible

QA Steps

  1. Open a chat
  2. Navigate to another chat
  3. The previous chat shouldn't be visible. The loading indicator should be shown.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

web.mov

Mobile Web

mWEB.mp4

Desktop

desktop.mov

iOS

iOS.mp4

Android

android.mp4

@rdjuric rdjuric requested a review from a team as a code owner July 7, 2021 21:56
@MelvinBot MelvinBot requested review from roryabraham and removed request for a team July 7, 2021 21:56
Copy link
Contributor

@roryabraham roryabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Nice and simple, tests well!

@roryabraham roryabraham merged commit b1f09a3 into Expensify:main Jul 8, 2021
@OSBotify
Copy link
Contributor

OSBotify commented Jul 8, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions bot pushed a commit that referenced this pull request Jul 9, 2021
Improves transition when changing chats

(cherry picked from commit b1f09a3)
@roryabraham
Copy link
Contributor

CPd in 1.0.76-2 😁

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.77-5🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants