Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS - Conversation page is blinking after select the user #3941

Closed
mvtglobally opened this issue Jul 9, 2021 · 14 comments
Closed

iOS - Conversation page is blinking after select the user #3941

mvtglobally opened this issue Jul 9, 2021 · 14 comments
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2

Comments

@mvtglobally
Copy link

mvtglobally commented Jul 9, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Launch the app
  2. Log in with any credentials
  3. Select user to send a message

Expected Result:

Conversation page isn't blinking after select the user

Actual Result:

Conversation page is blinking after select the user

Workaround:

n/a

Platform:

Where is this issue occurring?

Web
iOS ✔️
Android
Desktop App
Mobile Web

Version Number: 1.0.79-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Device and OS: iPhone 8/iOS 14.2
Reproducible on production: No

Video

View all open jobs on Upwork

@mvtglobally mvtglobally added DeployBlockerCash This issue or pull request should block deployment AutoAssignerTriage Auto assign issues for triage to an available triage team member Engineering labels Jul 9, 2021
@MelvinBot
Copy link

Triggered auto assignment to @stephanieelliott (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@MelvinBot
Copy link

Triggered auto assignment to @tgolen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@MelvinBot MelvinBot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Jul 9, 2021
@github-actions github-actions bot added the Hourly KSv2 label Jul 9, 2021
@OSBotify
Copy link
Contributor

OSBotify commented Jul 9, 2021

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@rdjuric
Copy link
Contributor

rdjuric commented Jul 9, 2021

@tgolen I think this was fixed by #3908

@tgolen
Copy link
Contributor

tgolen commented Jul 9, 2021

OK, thanks! Is there any way to get that CPed to staging now that it's already been merged? I know we can manually do it, but I don't know what will break if we do that. @roryabraham any advice?

@roryabraham
Copy link
Contributor

@tgolen We can manually CP PRs after-the-fact using the GitHub Actions UI:

image

However, right now it's set up so that only members of the Expensify.cash Deployers GH team (AKA @AndrewGable and I) can do that. We had plans to open that up to a wider group of people, but just haven't had that discussion yet.

@roryabraham
Copy link
Contributor

I will manually CP #3908 now

@roryabraham
Copy link
Contributor

#3908 will be available in 1.0.76-2.

@tgolen
Copy link
Contributor

tgolen commented Jul 9, 2021 via email

@roryabraham
Copy link
Contributor

@roryabraham
Copy link
Contributor

Looks like this is the last deploy blocker, so @isagoico can we retest?

@roryabraham
Copy link
Contributor

I am unable to reproduce on iOS 1.0.76-2

@isagoico
Copy link

isagoico commented Jul 9, 2021

We were still able to reproduce in 1.0.76-1. Checking on -2 at the moment

@isagoico
Copy link

isagoico commented Jul 9, 2021

We were unable to reproduce on 1.0.76-2 🎉 Closing the issue

@isagoico isagoico closed this as completed Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

8 participants