Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make button visible in WorkspaceInvitePage #3989

Merged
merged 1 commit into from
Jul 12, 2021
Merged

Make button visible in WorkspaceInvitePage #3989

merged 1 commit into from
Jul 12, 2021

Conversation

roryabraham
Copy link
Contributor

@roryabraham roryabraham commented Jul 12, 2021 •
edited
Loading

Details

Use a KeyboardAvoidingView, FixedFooter, and ScrollView to responsively ensure that the button will always be visible on the workspace invite page.

Fixed Issues

$ #3974

Tests / QA Steps

  1. Create a new workspace if you don't already have one.
  2. Go to Settings -> Workspace -> People -> Invite
  3. Fill out the invite form, and ensure that the button is always visible (not hidden behind keyboard).

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

image

Mobile Web

image

Desktop

image

iOS

Android

image

@roryabraham roryabraham requested a review from a team as a code owner July 12, 2021 21:16
@roryabraham roryabraham self-assigned this Jul 12, 2021
@OSBotify
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@MelvinBot MelvinBot requested review from AndrewGable and removed request for a team July 12, 2021 21:17
@roryabraham
Copy link
Contributor Author

@AndrewGable heads up! This fixes an hourly deploy blocker!

@AndrewGable AndrewGable merged commit bb042f5 into main Jul 12, 2021
@AndrewGable AndrewGable deleted the Rory-FixMobileInviteForm branch July 12, 2021 22:25
github-actions bot pushed a commit that referenced this pull request Jul 12, 2021
@AndrewGable
Merge pull request #3989 from Expensify/Rory-FixMobileInviteForm
4885078 
Make button visible in WorkspaceInvitePage

(cherry picked from commit bb042f5)
This was referenced Jul 12, 2021
Merged
Closed
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging in version: 1.0.77-1🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify OSBotify mentioned this pull request Jul 14, 2021
Closed
95 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.77-5🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.77-6🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.79-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewGable AndrewGable AndrewGable approved these changes

Assignees

@roryabraham roryabraham

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roryabraham @OSBotify @AndrewGable