Don't check participants' whole names in default rooms

[TomatoToaster]

@thienlnam, please review

Details

Now for sure, we won't be showing rooms that user's are in when you're searching their name (unless they share a name with a default room).

Also fixing a Podfile.lock spec checksum that's out of date.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/169139
specifically: https://github.com/Expensify/Expensify/issues/169139#issuecomment-882776491

Tests

Do the Web QA locally.

QA Steps

Since defaultRooms are only available to expensify employees rn, I can test this. Ping @TomatoToaster, if I haven't already checked this off for QA.

1. Search for a person's name and verify it only shows their dms and does not show rooms they are in. You'l have to type their full first name of full last name, to truly verify this works. If their name is a substring of room name, technically it should show that room name 😓 so try a name like amal or shawn.

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Good:

Bad:

Web

[TomatoToaster]

Unrelated to the real problem here, but this should probably be updated according to this: https://expensify.slack.com/archives/C01GTK53T8Q/p1626728088492500

To fully confirm, can you also run pod install in the ios folder on the main branch and verify that you also get a different checksum? Also, run it on this branch, amal-participants-full-name-check, and it should give you the same checksum as me.

[thienlnam]

I got a different checksum for a bunch of things

RNReanimated (2.3.0-alpha.1):
DoubleConversion: cde416483dac037923206447da6e1454df403714
FBReactNativeSpec: 76cede005e0667703f69105017804cc6c5e39fc8
glog: 40a13f7840415b9a77023fbcae0f1e6f43192af3
RNReanimated: 833ebd229b31e18a8933ebd0cd744a0f47d88c42

[TomatoToaster]

Ah hmm let me pull main into this branch and see if that resolves it. If not I might just not mess with this part.

[thienlnam]

Changes look good but it seems like this will remove the ability to find any default room in the search?

[TomatoToaster]

@thienlnam Ah! Don't worry this is not the only code for generating search text.

You can see it more in this PR: #3847 but when we build the search matches for default rooms, we use their reportName and their policy name (or domainName if it is a domain room).

Here's where that code specifically is: https://github.com/Expensify/Expensify.cash/blob/1e1a9a21a2b238749cc3bdc77fc85f4635d1878f/src/libs/OptionsListUtils.js#L154-L177

So the isSearchStringMatch function I'm modifying in this PR will also search those values with matchRegex.test(valueToSearch)

For proof, here's me searching by policy name and room names:

[github-actions]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[thienlnam]

Doing some testing and noticed that a lack of results just outputs the text under the search bar, is this expected behavior?

[thienlnam]

Also, looks like you'll need to sign the #4141 (comment)

[TomatoToaster]

Yeah I think that behavior is expected since it happens on prod too:

Also hmm I just reacknowledged it here since that comment: #4068 (comment)

Have you done it again since the repo name change? (I'll do it again just in case though)

[TomatoToaster]

I have read the CLA Document and I hereby sign the CLA

[thienlnam]

Sweet, thanks!

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging in version: 1.0.79-5🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[isagoico]

@TomatoToaster Heyo! Following PR orders to bump you for QA :)

[TomatoToaster]

This passed qa too checking it off

[OSBotify]

🚀 Deployed to production in version: 1.0.80-2🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅