Added multiple emails invite support to workspace invite page

[parasharrajat]

Details

#4029 (comment)

Fixed Issues

$ #4029

Tests | QA Steps

1 Login to expensify.cash using an account under freePlan beta
2. Create a workspace via Global create (i.e. the green + icon)
3. Go to Settings and access the Workspace
4. Go to People tab
5. Select "Invite"
6. Attempt to invite multiple valid email addresses and separate them by comma
7. You should be able to invite multiple persons as once.

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

invite-w.mp4

Mobile Web

invite-m.mp4

Desktop

iOS

Android

invite-a.mp4

[parasharrajat]

Some open questions #4029 (comment)

[parasharrajat]

Questions:
When any of the input logins is invalid phone backend throws an error but it does not tell which login so we have to delete all the entered logins.

What would be the correct behavior here?

1. Remove the wrong login only. Need backend changes. I think the backend does not add even the correct logins if any one of them is wrong.
2. Or remove all invited as currently backend does.

[timszot]

cc @TomatoToaster since you're working on the OG issue with proposed changes and there are some questions here.

[TomatoToaster]

@parasharrajat goood catch and good question!

I think removing all of them is fine for this PR In the future, I can imagine we might eventually modify the backend to fix the does not add even the correct logins if any one of them is wrong, but it feels like it wouldn't be a common issue. I'll bring it up though and maybe we'll create a follow up for this.

[github-actions]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[TomatoToaster]

Oh dang it, I bet this happens now because we changed the Repo name. I guess we better get this out of the way.

[TomatoToaster]

I have read the CLA Document and I hereby sign the CLA

[parasharrajat]

@TomatoToaster Ok. I will finalize the PR for review.

[TomatoToaster]

recheck

[parasharrajat]

Ready for review.

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging in version: 1.0.79-5🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[isagoico]

iOS - Invite people - Comma not displayed in keyboard to send multiple invites

Action Performed

1. Launch the app and login with expensifail account
2. Tap + > New workspace
3. Enter name for workspace , tap Get started
   4.Tap People > Invite
4. Enter email

Expected Result

Comma displayed to invite multiple email or email and phone number at once

Actual Result

No comma displayed in keyboard. Reproducible in iOS only. Android is working as expected.

Notes/Images/Video
Device and OS: iPhone Xs / 14.6 and iPhone 6s

comma.mp4

[parasharrajat]

This can be fixed by changing the type of keyboard keyboardType={getEmailKeyboardType()} to keeping default for all platforms. But I would like to ask if this is how to want to tackle it. We already have the validations in place.

[TomatoToaster]

@parasharrajat I think that's a good idea. You're right that since we have the email validation already in place, we don't need to restrict the keyboard.

[TomatoToaster]

Removing the deploy blocker since this is still a beta feature and I've got a PR to fix it up.

[OSBotify]

🚀 Deployed to production in version: 1.0.80-2🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅