Load policies after we load betas as well #4084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgolen
approved these changes
Jul 15, 2021
There was a problem hiding this comment.
Looks good! That's quite the gotcha. I'm sure we're not going to be the last people to run into this. I'm kind of wondering if we could make a higher level component that essentially triggers a callback when the betas are available (like withBetas), but it might be kind of awkward to have several nested HOCs all using withOnyx.
It's fine for now, but something we can keep in mind for the future.
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
95 tasks
|
🚀 Deployed to staging in version: 1.0.78-3🚀
|
|
SO clean! The workspaces popped up right away. |
|
🚀 Deployed to production in version: 1.0.79-4🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Luke9389, please review
cc: @tgolen, because we discussed this solution
Details
The first time a user logs in, we will load their betas and based on which betas they are in, we will load their policy infos. Currently, since this all happens in the
componentDidMount()function, the betas aren't loaded for the beta check and so we don't load the policy info for the user. This will work after the user logs in and refreshes, since we store the betas locally.This change will make it so we check for the betas again after we have loaded them in
componentDidUpdate.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/170607
Tests
Web QA done locally, but to get the full effect of this you should change this line to remove the
isDevelopment()otherwise you'll just always load every beta behavior on dev.QA Steps
Requires you to be in the Free Plan beta (reach out to @TomatoToaster to test if you can't access it)
Tested On
Screenshots
Web