Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default state AK and require users to enter a state #4035

Merged
merged 2 commits into from
Jul 15, 2021

Conversation

TomatoToaster
Copy link
Contributor

@TomatoToaster TomatoToaster commented Jul 14, 2021

@pecanoro, please review when you get the chance

Details

Changes the default state in the selection tool to be '' (which will show up as -) instead of AK which users might forget to update and put the wrong address in for. Also added growl errors if the empty state selections (exception of incorporationState, since that'll have its own error from the API). This way they'll have to consciously select a state in every selector. There are appropriate

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/170025

Tests

Did the QA steps locally on web (This is the only platform where we can access bank account setup right now).

QA Steps

  1. Go to staging.expensify.cash/bank-account/new and go through the setup for a new bank account
  2. During the setup in the Company Step, the Requestor Step, and the Benefactors step, verify that the State selectors show up as - by default. Make sure that for each page, it won't let you continue until you choose a valid state (even for Incorporation State). See screenshots below for reference for if anything looks off.
  3. While you're completing this, be sure to jump back steps sometimes and verify that the information is as you entered. Specifically, make sure the State isn't being reset to AK and is what you selected.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

image
image
image
image

Mobile Web

Desktop

iOS

Android

@TomatoToaster TomatoToaster self-assigned this Jul 14, 2021
@TomatoToaster TomatoToaster marked this pull request as ready for review July 14, 2021 20:52
@TomatoToaster TomatoToaster requested a review from a team as a code owner July 14, 2021 20:52
@MelvinBot MelvinBot requested review from pecanoro and removed request for a team July 14, 2021 20:53
@pecanoro pecanoro merged commit 0735efc into main Jul 15, 2021
@pecanoro pecanoro deleted the amal-remove-default-state-pick branch July 15, 2021 16:20
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.78-3🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.79-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants