Remove default state AK and require users to enter a state #4035
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pecanoro, please review when you get the chance
Details
Changes the default state in the selection tool to be
''
(which will show up as-
) instead ofAK
which users might forget to update and put the wrong address in for. Also added growl errors if the empty state selections (exception of incorporationState, since that'll have its own error from the API). This way they'll have to consciously select a state in every selector. There are appropriateFixed Issues
$ https://github.com/Expensify/Expensify/issues/170025
Tests
Did the QA steps locally on web (This is the only platform where we can access bank account setup right now).
QA Steps
State
selectors show up as-
by default. Make sure that for each page, it won't let you continue until you choose a valid state (even for Incorporation State). See screenshots below for reference for if anything looks off.AK
and is what you selected.Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android