-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set default value for requestorAddressState in RequestorStep form #3776
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests pass, LGTM
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Unfortunately the deploy comments are not working right now. This was deployed to staging yesterday. |
PR3776 - [Chat] - Payments - Unable to add bank fully verified accountAction Performed:
Expected Result:User can proceed to add the bank account. Actual Result:User is redirected back to the add bank account options (log in or manually). JS console shows this errror: Is it reproducible in production? : Unable to verify (test credentials don't work in Prod) Build version : 1.0.76-1 Notes/Images/Video Tester login credentials - Email/Phone : applausetester+igadmin@applause.expensifail.com Device and OS: Windows 10 / Chrome |
@isagoico Can you create a separate issue for this? It's almost certainly unrelated to this PR. It will not need to be a deploy blocker, because the bank account stuff is still behind a beta. |
Sure! New issue here #3953 |
Do we know if this is on prod? @roryabraham |
Looks like it was un-done here, so no it doesn't appear to be on production. |
Details
Set the default state if a user does not alter the state picker on the RequestStep form. Otherwise, they will be blocked from proceeding in the VBA setup flow with an error:
402 Missing requestorAddressState in additionalData
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/168661
Tests
/bank-account/new
AK
QA Steps
No QA
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android