Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default value for requestorAddressState in RequestorStep form #3776

Merged
merged 1 commit into from
Jun 30, 2021

Conversation

MariaHCD
Copy link
Contributor

@MariaHCD MariaHCD commented Jun 28, 2021

Details

Set the default state if a user does not alter the state picker on the RequestStep form. Otherwise, they will be blocked from proceeding in the VBA setup flow with an error: 402 Missing requestorAddressState in additionalData

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/168661

Tests

  1. Navigate to /bank-account/new
  2. Follow the instructions here to set up an open bank account
  3. Once on the requestor information form, fill out all the details except for the state, leave this to the default value AK

Screen Shot 2021-06-28 at 4 28 46 PM

  1. Verify that you can proceed to the next step (i.e. Beneficial Owners) in the flow

Screen Shot 2021-06-28 at 4 30 05 PM

QA Steps

No QA

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@MariaHCD MariaHCD self-assigned this Jun 28, 2021
@MariaHCD MariaHCD marked this pull request as ready for review June 28, 2021 12:52
@MariaHCD MariaHCD requested a review from a team as a code owner June 28, 2021 12:52
@MelvinBot MelvinBot requested review from Jag96 and removed request for a team June 28, 2021 12:52
Copy link
Contributor

@Jag96 Jag96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass, LGTM

@Jag96 Jag96 merged commit 1ae1d6e into main Jun 30, 2021
@Jag96 Jag96 deleted the maria-requestor-state-fix branch June 30, 2021 01:36
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@roryabraham
Copy link
Contributor

Unfortunately the deploy comments are not working right now. This was deployed to staging yesterday.

@isagoico
Copy link

isagoico commented Jul 9, 2021

PR3776 - [Chat] - Payments - Unable to add bank fully verified account

Action Performed:

  1. Log in to e.cash
  2. Navigate to /bank-account/new
  3. Click on Log in to bank account
  4. Enter the test credentials

Expected Result:

User can proceed to add the bank account.

Actual Result:

User is redirected back to the add bank account options (log in or manually). JS console shows this errror:

image

Is it reproducible in production? : Unable to verify (test credentials don't work in Prod)

Build version : 1.0.76-1

Notes/Images/Video

Tester login credentials - Email/Phone : applausetester+igadmin@applause.expensifail.com
Tester login credentials - Password : 123456Isa

Device and OS: Windows 10 / Chrome

image

@roryabraham
Copy link
Contributor

@isagoico Can you create a separate issue for this? It's almost certainly unrelated to this PR. It will not need to be a deploy blocker, because the bank account stuff is still behind a beta.

@isagoico
Copy link

isagoico commented Jul 9, 2021

Sure! New issue here #3953

@jasperhuangg
Copy link
Contributor

Do we know if this is on prod? @roryabraham

@roryabraham
Copy link
Contributor

Looks like it was un-done here, so no it doesn't appear to be on production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants