[No QA] Change expensify.cash => new.expensify.com #4016

rafecolton · 2021-07-13T21:20:08Z

Details

Fixed Issues

Part of https://github.com/Expensify/Expensify/issues/161422

Tests

N/A

QA Steps

Tested On

Screenshots

Web

Mobile Web

Desktop

iOS

Android

botify · 2021-07-13T21:20:10Z

npm has a package.json file and a package-lock.json file. It seems you updated one without the other, which is usually a sign of a mistake. If you are updating a package make sure that you update the version in package.json then run npm install

OSBotify · 2021-07-13T21:20:26Z

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

Jag96 · 2021-07-13T21:28:17Z

android/app/src/main/AndroidManifest.xml

-            <action android:name="android.intent.action.VIEW"/>
-            <category android:name="android.intent.category.DEFAULT"/>
-            <category android:name="android.intent.category.BROWSABLE"/>
-            <data android:scheme="https" android:host="www.expensify.cash" />


We previously had a separate filter for expensify.cash and www.expensify.cash, shouldn't we add one here for www.new.expensify.com? Context for this in #2052 (comment)

No idea - @marcaaron?

Jag96 · 2021-07-13T21:32:05Z

src/libs/Navigation/linkingConfig.js

@@ -8,6 +8,7 @@ export default {
        'https://www.expensify.cash',
        'https://staging.expensify.cash',
        'http://localhost',
+        'https://new.expensify.com',


Same question here, do we also need https://www.new.expensify.com?

I wasn't planning on adding it, since I think it's less likely somebody would type in www.new, but that does remind me that I need to add staging.new

roryabraham · 2021-07-13T21:32:12Z

If the actual domain name from which the site is hosted is changing, I think we'll also need to modify this and it's associated usages

rafecolton · 2021-07-13T21:32:59Z

Yep good call @roryabraham, those do need to be updated as well

roryabraham · 2021-07-13T21:33:29Z

I think that one's just used here. IDK if you also want to change the App name or site title as well. Those are just visual changes I believe, so could be handled separately.

roryabraham · 2021-07-13T21:39:44Z

Might also want to change this guy

roryabraham · 2021-07-13T21:40:48Z

Also this and this are important if the cloudflare domain is being changed.

package.json

Jag96

LGTM @roryabraham all yours

roryabraham · 2021-07-13T23:26:52Z

I think this looks good now.

botify · 2021-07-14T18:13:54Z

npm has a package.json file and a package-lock.json file. It seems you updated one without the other, which is usually a sign of a mistake. If you are updating a package make sure that you update the version in package.json then run npm install

[No QA] Change expensify.cash => new.expensify.com (cherry picked from commit 9d900a8)

OSBotify · 2021-07-14T18:55:43Z

🚀 Deployed to staging in version: 1.0.77-4🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2021-07-14T19:32:00Z

🚀 Deployed to production in version: 1.0.77-5🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2021-07-14T19:52:03Z

🚀 Deployed to staging in version: 1.0.77-6🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2021-07-23T21:14:31Z

🚀 Deployed to production in version: 1.0.79-4🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Change expensify.cash => new.expensify.com

aa596d6

rafecolton added the CP Staging label Jul 13, 2021

rafecolton requested a review from stitesExpensify July 13, 2021 21:20

rafecolton requested a review from a team as a code owner July 13, 2021 21:20

rafecolton self-assigned this Jul 13, 2021

MelvinBot requested review from Gonals and removed request for a team July 13, 2021 21:20

Jag96 reviewed Jul 13, 2021

View reviewed changes

roryabraham reviewed Jul 13, 2021

View reviewed changes

package.json Show resolved Hide resolved

Missed this stuff

e4ec7c1

Jag96 approved these changes Jul 13, 2021

View reviewed changes

roryabraham approved these changes Jul 13, 2021

View reviewed changes

rafecolton changed the title ~~[No QA][HOLD] Change expensify.cash => new.expensify.com~~ [No QA] Change expensify.cash => new.expensify.com Jul 14, 2021

rafecolton merged commit 9d900a8 into main Jul 14, 2021

rafecolton deleted the new-expensify-com branch July 14, 2021 18:14

github-actions bot pushed a commit that referenced this pull request Jul 14, 2021

Merge pull request #4016 from Expensify/new-expensify-com

fa5b200

[No QA] Change expensify.cash => new.expensify.com (cherry picked from commit 9d900a8)

This was referenced Jul 14, 2021

🍒 Cherry pick PR #4016 to staging 🍒 #4039

Merged

Deploy Checklist: Expensify.cash 2021-07-09 #3958

Closed

OSBotify mentioned this pull request Jul 14, 2021

Deploy Checklist: Expensify.cash 2021-07-14 #4046

Closed

95 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[No QA] Change expensify.cash => new.expensify.com #4016

[No QA] Change expensify.cash => new.expensify.com #4016

rafecolton commented Jul 13, 2021

botify commented Jul 13, 2021

OSBotify commented Jul 13, 2021

Jag96 Jul 13, 2021

rafecolton Jul 13, 2021

Jag96 Jul 13, 2021

rafecolton Jul 13, 2021

roryabraham commented Jul 13, 2021

rafecolton commented Jul 13, 2021

roryabraham commented Jul 13, 2021 •

edited

Loading

roryabraham commented Jul 13, 2021

roryabraham commented Jul 13, 2021

Jag96 left a comment

roryabraham commented Jul 13, 2021

botify commented Jul 14, 2021

OSBotify commented Jul 14, 2021

OSBotify commented Jul 14, 2021

OSBotify commented Jul 14, 2021

OSBotify commented Jul 23, 2021

[No QA] Change expensify.cash => new.expensify.com #4016

[No QA] Change expensify.cash => new.expensify.com #4016

Conversation

rafecolton commented Jul 13, 2021

Details

Fixed Issues

Tests

QA Steps

Tested On

Screenshots

Web

Mobile Web

Desktop

iOS

Android

botify commented Jul 13, 2021

OSBotify commented Jul 13, 2021

Jag96 Jul 13, 2021

Choose a reason for hiding this comment

rafecolton Jul 13, 2021

Choose a reason for hiding this comment

Jag96 Jul 13, 2021

Choose a reason for hiding this comment

rafecolton Jul 13, 2021

Choose a reason for hiding this comment

roryabraham commented Jul 13, 2021

rafecolton commented Jul 13, 2021

roryabraham commented Jul 13, 2021 • edited Loading

roryabraham commented Jul 13, 2021

roryabraham commented Jul 13, 2021

Jag96 left a comment

Choose a reason for hiding this comment

roryabraham commented Jul 13, 2021

botify commented Jul 14, 2021

OSBotify commented Jul 14, 2021

OSBotify commented Jul 14, 2021

OSBotify commented Jul 14, 2021

OSBotify commented Jul 23, 2021

roryabraham commented Jul 13, 2021 •

edited

Loading